/usr/include/glib-2.0/glib/gstring.h:72:5: error: ignoring return value of ‘g_string_free_and_steal’ declared with attribute ‘warn_unused_result’ [-Werror=unused-result] Reproducible: Always emerge --info Portage 3.0.45.2 (python 3.10.10-final-0, default/linux/amd64/17.1/desktop/plasma/systemd/merged-usr, gcc-12, glibc-2.37-r1, 6.2.6-gentoo x86_64) ================================================================= System uname: Linux-6.2.6-gentoo-x86_64-AMD_Ryzen_9_5900X_12-Core_Processor-with-glibc2.37 KiB Mem: 65787336 total, 61071080 free KiB Swap: 6291452 total, 6291452 free Timestamp of repository gentoo: Thu, 16 Mar 2023 14:17:09 +0000 Head commit of repository gentoo: a0c0efb513b798c2868550f2f6c118e18dad2d90 Head commit of repository audio-overlay: 038c364de867dc34d5dcbd6ad37361f377db83e1 sh bash 5.2_p15-r2 ld GNU ld (Gentoo 2.40 p3) 2.40.0 app-misc/pax-utils: 1.3.7::gentoo app-shells/bash: 5.2_p15-r2::gentoo dev-java/java-config: 2.3.1::gentoo dev-lang/perl: 5.36.0-r2::gentoo dev-lang/python: 3.10.10_p3::gentoo, 3.11.2_p2::gentoo dev-lang/rust: 1.67.1::gentoo dev-util/cmake: 3.26.0::gentoo dev-util/meson: 1.0.1::gentoo sys-apps/baselayout: 2.13-r1::gentoo sys-apps/sandbox: 2.30-r1::gentoo sys-apps/systemd: 253.1::gentoo sys-devel/autoconf: 2.71-r5::gentoo sys-devel/automake: 1.16.5::gentoo sys-devel/binutils: 2.40-r3::gentoo sys-devel/binutils-config: 5.5::gentoo sys-devel/clang: 15.0.7-r1::gentoo sys-devel/gcc: 12.2.1_p20230304::gentoo sys-devel/gcc-config: 2.10::gentoo sys-devel/libtool: 2.4.7-r1::gentoo sys-devel/lld: 15.0.7::gentoo sys-devel/llvm: 15.0.7::gentoo sys-devel/make: 4.4.1::gentoo sys-kernel/linux-headers: 6.2::gentoo (virtual/os-headers) sys-libs/glibc: 2.37-r1::gentoo Repositories: gentoo location: /var/db/repos/gentoo sync-type: git sync-uri: https://anongit.gentoo.org/git/repo/sync/gentoo.git priority: -1000 volatile: False audio-overlay location: /var/db/repos/audio-overlay sync-type: git sync-uri: https://github.com/gentoo-audio/audio-overlay.git masters: gentoo volatile: False local location: /var/db/repos/local masters: gentoo volatile: False ACCEPT_KEYWORDS="amd64 ~amd64" ACCEPT_LICENSE="* -@EULA" AR="ar" CBUILD="x86_64-pc-linux-gnu" CC="gcc" CFLAGS="-O2 -march=native -fomit-frame-pointer -pipe" CHOST="x86_64-pc-linux-gnu" CONFIG_PROTECT="/etc /usr/share/config /usr/share/gnupg/qualified.txt" CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/dconf /etc/env.d /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/revdep-rebuild /etc/sandbox.d" CXX="g++" CXXFLAGS="-O2 -march=native -fomit-frame-pointer -pipe" DISTDIR="/var/cache/distfiles" EMERGE_DEFAULT_OPTS="--with-bdeps y --autounmask-keep-masks" ENV_UNSET="CARGO_HOME DBUS_SESSION_BUS_ADDRESS DISPLAY GDK_PIXBUF_MODULE_FILE GOBIN GOPATH PERL5LIB PERL5OPT PERLPREFIX PERL_CORE PERL_MB_OPT PERL_MM_OPT XAUTHORITY XDG_CACHE_HOME XDG_CONFIG_HOME XDG_DATA_HOME XDG_RUNTIME_DIR XDG_STATE_HOME" FCFLAGS="-O2 -pipe" FEATURES="assume-digests binpkg-docompress binpkg-dostrip binpkg-logs buildpkg-live clean-logs config-protect-if-modified distlocks ebuild-locks fixlafiles ipc-sandbox merge-sync multilib-strict network-sandbox news parallel-fetch pid-sandbox preserve-libs protect-owned qa-unresolved-soname-deps sandbox sfperms strict unknown-features-warn unmerge-logs unmerge-orphans userfetch userpriv usersandbox usersync xattr" FFLAGS="-O2 -pipe" GENTOO_MIRRORS="http://gentoo.osuosl.org/" LANG="en_US.utf8" LDFLAGS="-Wl,-O2 -Wl,--as-needed" LEX="flex" LINGUAS="en_US en" MAKEOPTS="V=1 -j1" NM="nm" PKGDIR="/var/cache/binpkgs" PORTAGE_CONFIGROOT="/" PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --omit-dir-times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages --exclude=/.git" PORTAGE_TMPDIR="/var/tmp" RANLIB="ranlib" SHELL="/bin/bash" USE="X a52 aac aalib acl acpi activities alsa amd64 amr apache2 audiofile bash-completion bluray branding btrfs bzip2 cairo caps cdaudio cdda cddb cdparanoia cdr cdrdao chm chromecast cleartype cli corefonts crypt cups curl dbus declarative djvu dri dssi dts dv dvb dvd dvdr ebook egl encode exif fam fdk ffmpeg flac fortran gdbm gif gmp google gphoto2 gpm gstreamer gtk gtk3 gtk4 gui iconv icu imagemagick imap imlib introspection ipv6 jack java jpeg jpeg2k kde kpathsea kvm kwallet ladspa lame lash lcms libffi libglvnd libinput libnotify libtirpc linguas_en_US lm-sensors lv2 lvm lzma mad marble midi mmap mng mozilla mp3 mp4 mpeg mtp multimedia musicbrainz ncurses network nls nodrm nptl nsplugin ofx ogg opencl openexr opengl openmp opus pam pango pcre pdf pipewire pipewire-alsa plasma png policykit ppds pulseaudio qemu qml qt5 readline rtmp rust sasl scanner screencast sdl seccomp semantic-desktop slp smp sndfile sound speex spell ssl startup-notification subversion svg systemd test-rust theora threads tiff tk transparency truetype type1 udev udisks unicode unwind upower usb v4l vaapi vcd vdpau vim-syntax vorbis vpx vst wav wavpack wayland webp widgets wmf wxwidgets x264 x265 xattr xcb xcomposite xft xine xkb xml xscreensaver xv xvid zlib" ABI_X86="64" ADA_TARGET="gnat_2021" APACHE2_MODULES="authn_core authz_core socache_shmcb unixd actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" CALLIGRA_FEATURES="karbon sheets words" CAMERAS="*" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" CPU_FLAGS_X86="aes avx avx2 f16c fma3 mmx mmxext pclmul popcnt rdrand sha sse sse2 sse3 sse4_1 sse4_2 sse4a ssse3" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock greis isync itrax mtk3301 nmea ntrip navcom oceanserver oldstyle oncore rtcm104v2 rtcm104v3 sirf skytraq superstar2 timing tsip tripmate tnt ublox ubx" GRUB_PLATFORMS="efi-64" INPUT_DEVICES="libinput wacom" KERNEL="linux" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LIBREOFFICE_EXTENSIONS="presenter-console presenter-minimizer" LUA_SINGLE_TARGET="lua5-1" LUA_TARGETS="lua5-1" NGINX_MODULES_HTTP="autoindex fancyindex fastcgi gzip" OFFICE_IMPLEMENTATION="libreoffice" PHP_TARGETS="php7-4 php8-0" POSTGRES_TARGETS="postgres12 postgres13" PYTHON_SINGLE_TARGET="python3_10" PYTHON_TARGETS="python3_10" QEMU_SOFTMMU_TARGETS="x86_64" QEMU_USER_TARGETS="x86_64" RUBY_TARGETS="(-ruby27) (-ruby30) ruby31 ruby32" SANE_BACKENDS="epson epson2" USERLAND="GNU" VIDEO_CARDS="amdgpu radeonsi" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq proto steal rawnat logmark ipmark dhcpmac delude chaos account" Unset: ADDR2LINE, ARFLAGS, AS, ASFLAGS, CCLD, CONFIG_SHELL, CPP, CPPFLAGS, CTARGET, CXXFILT, ELFEDIT, EXTRA_ECONF, F77FLAGS, FC, GCOV, GPROF, INSTALL_MASK, LC_ALL, LD, LFLAGS, LIBTOOL, MAKE, MAKEFLAGS, OBJCOPY, OBJDUMP, PORTAGE_BINHOST, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS, READELF, RUSTFLAGS, SIZE, STRINGS, STRIP, YACC, YFLAGS
emerge -pqv '=app-office/gnucash-4.13::gentoo' [ebuild U ] app-office/gnucash-4.13 [4.12-r1] USE="gui nls python -aqbanking -debug -doc -examples -gnome-keyring -mysql -ofx -postgres -quotes -register2 -smartcard -sqlite -test" PYTHON_SINGLE_TARGET="python3_10 -python3_9 -python3_11"
Created attachment 858009 [details] build log
can confirm this on my machine too, seems like '''cc1: all warnings being treated as errors''' is the cause. This should be upstreams concern, maybe change compile options to ignore warnings for this one?
Could you try the following patches together: 1. https://github.com/Gnucash/gnucash/commit/184669f517744ac7be6e420e5e1f359384f676d5 2. https://github.com/Gnucash/gnucash/commit/abcce5000ca72bf943ca8951867729942388848e 3. https://github.com/Gnucash/gnucash/commit/89e63ef67235d231d242f018894295a6cb38cfc3 And possibly 4. https://github.com/Gnucash/gnucash/commit/47b85d3b2fcf9bed4f68b46a94f764d8cd0f4581 5. https://github.com/Gnucash/gnucash/commit/7f0353adc4b0dc73586bdf056dc5a97eda2599f9
The proper fix is to remove "-Werror": diff -ur gnucash-4.13.orig/CMakeLists.txt gnucash-4.13/CMakeLists.txt --- gnucash-4.13.orig/CMakeLists.txt 2023-03-17 14:04:20.049553807 +0100 +++ gnucash-4.13/CMakeLists.txt 2023-03-17 14:06:12.758614327 +0100 @@ -578,9 +578,9 @@ set(CMAKE_C_EXTENSIONS ON) if (UNIX) - set( CMAKE_C_FLAGS "-Werror -Wdeclaration-after-statement -Wno-pointer-sign -Wall -Wmissing-prototypes -Wmissing-declarations -Wno-unused ${CMAKE_C_FLAGS}") + set( CMAKE_C_FLAGS "-Wdeclaration-after-statement -Wno-pointer-sign -Wall -Wmissing-prototypes -Wmissing-declarations -Wno-unused ${CMAKE_C_FLAGS}") set( CMAKE_C_FLAGS "-Wno-error=deprecated-declarations -Wno-error=parentheses ${CMAKE_C_FLAGS}") - set( CMAKE_CXX_FLAGS "-Werror -Wall -Wmissing-declarations -Wno-unused -Wno-error=parentheses ${CMAKE_CXX_FLAGS}") + set( CMAKE_CXX_FLAGS "-Wall -Wmissing-declarations -Wno-unused -Wno-error=parentheses ${CMAKE_CXX_FLAGS}") set( CMAKE_CXX_FLAGS "-Wno-error=deprecated-declarations ${REGISTER_CXXFLAG} ${CMAKE_CXX_FLAGS}") set( CMAKE_C_FLAGS_RELEASE "-O3 -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 ${CMAKE_C_FLAGS}") endif() More details: https://devmanual.gentoo.org/ebuild-writing/common-mistakes/index.html#-werror-compiler-flag-not-removed
That's not an exclusively proper fix, it's an orthogonal fix (both of which are worth pursuing).
Honestly, I'm not sure that weakening the intended configuration set by upstream (that wants to consider warning as errors) is the right fix.
(In reply to Fabio Coatti from comment #7) > Honestly, I'm not sure that weakening the intended configuration set by > upstream (that wants to consider warning as errors) is the right fix. It's legitimate to strip -Werror given it causes issues when new libraries come out and such (see the links Ștefan gave), I just disagree with his assertion that it's the sole and only "proper" fix.
I think the best option might be to just implement this simple fix while we report this issue to upstream and wait for their official response. Once they patch the code to stop generating warnings and release an update, we should remove the modifications. That ensures minimal deviation from upstream while still providing user experience in the meantime.
(In reply to 9ts641j2 from comment #9) > I think the best option might be to just implement this simple fix while we > report this issue to upstream and wait for their official response. Once > they patch the code to stop generating warnings and release an update, we > should remove the modifications. That ensures minimal deviation from > upstream while still providing user experience in the meantime. I need someone to test the patches I linked, as it might be fixed already.
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=bb04b47145e309e8f7950900cd0c378d4ba66771 commit bb04b47145e309e8f7950900cd0c378d4ba66771 Author: Sam James <sam@gentoo.org> AuthorDate: 2023-03-17 16:02:07 +0000 Commit: Sam James <sam@gentoo.org> CommitDate: 2023-03-17 16:03:19 +0000 app-office/gnucash: drop -Werror Closes: https://bugs.gentoo.org/901485 Signed-off-by: Sam James <sam@gentoo.org> .../gnucash/files/gnucash-4.13-no-werror.patch | 20 ++++++++++++++++++++ app-office/gnucash/gnucash-4.13.ebuild | 1 + 2 files changed, 21 insertions(+)
