Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 901367 - net-p2p/bitcoind-0.21.0 - pubkey.cpp: error: too few arguments to function int secp256k1_schnorrsig_verify(const secp256k1_context
Summary: net-p2p/bitcoind-0.21.0 - pubkey.cpp: error: too few arguments to function in...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Luke-Jr
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks:
 
Reported: 2023-03-15 17:35 UTC by Toralf Förster
Modified: 2023-03-19 04:36 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
emerge-info.txt (emerge-info.txt,18.84 KB, text/plain)
2023-03-15 17:35 UTC, Toralf Förster
Details
emerge-history.txt (emerge-history.txt,186.62 KB, text/plain)
2023-03-15 17:35 UTC, Toralf Förster
Details
environment (environment,87.93 KB, text/plain)
2023-03-15 17:35 UTC, Toralf Förster
Details
etc.clang.tar.bz2 (etc.clang.tar.bz2,688 bytes, application/x-bzip)
2023-03-15 17:35 UTC, Toralf Förster
Details
etc.portage.tar.bz2 (etc.portage.tar.bz2,15.48 KB, application/x-bzip)
2023-03-15 17:35 UTC, Toralf Förster
Details
logs.tar.bz2 (logs.tar.bz2,16.98 KB, application/x-bzip)
2023-03-15 17:35 UTC, Toralf Förster
Details
net-p2p:bitcoind-0.21.0:20230314-225444.log (net-p2p:bitcoind-0.21.0:20230314-225444.log,77.51 KB, text/plain)
2023-03-15 17:35 UTC, Toralf Förster
Details
temp.tar.bz2 (temp.tar.bz2,31.96 KB, application/x-bzip)
2023-03-15 17:35 UTC, Toralf Förster
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Toralf Förster gentoo-dev 2023-03-15 17:35:13 UTC
pubkey.cpp:181:96: error: invalid conversion from secp256k1_xonly_pubkey* to size_t {aka long unsigned int} [-fpermissive]
  181 | erify(secp256k1_context_verify, sigbytes.data(), msg.begin(), &pubkey);
      |                                                               ^~~~~~~
      |                                                               |
      |                                                               secp256k1_xonly_pubkey*

pubkey.cpp:181:39: error: too few arguments to function int secp256k1_schnorrsig_verify(const secp256k1_context*, const unsigned char*, const unsigned char*, size_t, const secp256k1_xonly_pubkey*)
  181 |     return secp256k1_schnorrsig_verify(secp256k1_context_verify, sigbytes.data(), msg.begin(), &pubkey);
      |            ~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

  -------------------------------------------------------------------

  This is an unstable amd64 chroot image at a tinderbox (==build bot)
  name: 17.1_no_multilib_systemd-j5-20230313-020004

  -------------------------------------------------------------------

gcc-config -l:
 [1] x86_64-pc-linux-gnu-13 *
clang/llvm (if any):
clang version 15.0.7
Target: x86_64-pc-linux-gnu
Thread model: posix
InstalledDir: /usr/lib/llvm/15/bin
Configuration file: /etc/clang/clang.cfg
/usr/lib/llvm/15
15.0.7
Python 3.10.10
Available Ruby profiles:
  [1]   ruby27 (with Rubygems)
  [2]   ruby30 (with Rubygems) *
Available Rust versions:
  [1]   rust-1.67.1 *
The following VMs are available for generation-2:
1)	Eclipse Temurin JDK 17.0.6_p10 [openjdk-bin-17]
*)	Eclipse Temurin JDK 8.362_p09 [openjdk-bin-8]
Available Java Virtual Machines:
  [1]   openjdk-bin-8  system-vm
  [2]   openjdk-bin-17 

The Glorious Glasgow Haskell Compilation System, version 9.0.2
php cli (if any):

  HEAD of ::gentoo
commit 5182313171ac524018e4946060fa3eb4ffa57f19
Author: Repository mirror & CI <repomirrorci@gentoo.org>
Date:   Tue Mar 14 22:17:02 2023 +0000

    2023-03-14 22:17:01 UTC

emerge -qpvO net-p2p/bitcoind
[ebuild  N    ] net-p2p/bitcoind-24.0.1  USE="asm berkdb external-signer wallet -examples -nat-pmp -sqlite -systemtap -test -upnp -zeromq"
Comment 1 Toralf Förster gentoo-dev 2023-03-15 17:35:14 UTC
Created attachment 857873 [details]
emerge-info.txt
Comment 2 Toralf Förster gentoo-dev 2023-03-15 17:35:16 UTC
Created attachment 857875 [details]
emerge-history.txt
Comment 3 Toralf Förster gentoo-dev 2023-03-15 17:35:17 UTC
Created attachment 857877 [details]
environment
Comment 4 Toralf Förster gentoo-dev 2023-03-15 17:35:18 UTC
Created attachment 857879 [details]
etc.clang.tar.bz2
Comment 5 Toralf Förster gentoo-dev 2023-03-15 17:35:19 UTC
Created attachment 857881 [details]
etc.portage.tar.bz2
Comment 6 Toralf Förster gentoo-dev 2023-03-15 17:35:20 UTC
Created attachment 857883 [details]
logs.tar.bz2
Comment 7 Toralf Förster gentoo-dev 2023-03-15 17:35:21 UTC
Created attachment 857885 [details]
net-p2p:bitcoind-0.21.0:20230314-225444.log
Comment 8 Toralf Förster gentoo-dev 2023-03-15 17:35:22 UTC
Created attachment 857887 [details]
temp.tar.bz2
Comment 9 Matt Whitlock 2023-03-18 00:20:45 UTC
Thanks for the report. Indeed, the old versions of Bitcoin Core aren't expected to work with the released ABI of libsecp256k1, although it is possible to patch them to work. I'll work on a PR to patch these old versions of Bitcoin Core so we can finally drop the pre-release versions of dev-libs/libsecp256k1.
Comment 10 Larry the Git Cow gentoo-dev 2023-03-19 04:21:57 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=27ea5586c1658b00e2c4b802116fe9a07871be2a

commit 27ea5586c1658b00e2c4b802116fe9a07871be2a
Author:     Matt Whitlock <gentoo@mattwhitlock.name>
AuthorDate: 2023-03-19 03:51:28 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2023-03-19 04:21:40 +0000

    net-p2p/bitcoin-qt: old versions need old dev-util/libsecp256k1
    
    Bug: https://bugs.gentoo.org/901367
    Signed-off-by: Matt Whitlock <gentoo@mattwhitlock.name>
    Closes: https://github.com/gentoo/gentoo/pull/30227
    Signed-off-by: Sam James <sam@gentoo.org>

 .../{bitcoin-qt-0.21.0.ebuild => bitcoin-qt-0.21.0-r1.ebuild}        | 5 +++--
 .../bitcoin-qt/{bitcoin-qt-22.0.ebuild => bitcoin-qt-22.0-r1.ebuild} | 3 ++-
 2 files changed, 5 insertions(+), 3 deletions(-)

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=f385521f1882c7afa95a4616cab90c0089cd10e8

commit f385521f1882c7afa95a4616cab90c0089cd10e8
Author:     Matt Whitlock <gentoo@mattwhitlock.name>
AuthorDate: 2023-03-19 03:50:42 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2023-03-19 04:21:40 +0000

    net-p2p/bitcoind: old versions need old dev-util/libsecp256k1
    
    Bug: https://bugs.gentoo.org/901367
    Signed-off-by: Matt Whitlock <gentoo@mattwhitlock.name>
    Signed-off-by: Sam James <sam@gentoo.org>

 .../bitcoind/{bitcoind-0.21.0.ebuild => bitcoind-0.21.0-r1.ebuild}   | 5 +++--
 net-p2p/bitcoind/{bitcoind-22.0.ebuild => bitcoind-22.0-r1.ebuild}   | 3 ++-
 2 files changed, 5 insertions(+), 3 deletions(-)

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=9631a31c4130e0636f6b33a0dee7feff708876e1

commit 9631a31c4130e0636f6b33a0dee7feff708876e1
Author:     Matt Whitlock <gentoo@mattwhitlock.name>
AuthorDate: 2023-03-19 03:47:08 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2023-03-19 04:21:39 +0000

    dev-util/bitcoin-tx: old versions need old dev-util/libsecp256k1
    
    Bug: https://bugs.gentoo.org/901367
    Signed-off-by: Matt Whitlock <gentoo@mattwhitlock.name>
    Signed-off-by: Sam James <sam@gentoo.org>

 .../{bitcoin-tx-0.21.0-r1.ebuild => bitcoin-tx-0.21.0-r2.ebuild}       | 3 ++-
 .../{bitcoin-tx-22.0-r1.ebuild => bitcoin-tx-22.0-r2.ebuild}           | 3 ++-
 2 files changed, 4 insertions(+), 2 deletions(-)
Comment 11 Matt Whitlock 2023-03-19 04:31:09 UTC
This immediate bug should be avoided now, but I left this bug open because Sam thinks we should stabilize Bitcoin Core 24 and drop all the older versions of both Bitcoin Core and libsecp256k1.
Comment 12 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2023-03-19 04:36:03 UTC
(In reply to Matt Whitlock from comment #11)
> This immediate bug should be avoided now, but I left this bug open because
> Sam thinks we should stabilize Bitcoin Core 24 and drop all the older
> versions of both Bitcoin Core and libsecp256k1.

Filed bug 902099 for that.