Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 901265 - media-video/pipewire-0.3.66-r1 incorrect logic in ebuild
Summary: media-video/pipewire-0.3.66-r1 incorrect logic in ebuild
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Sam James
URL:
Whiteboard:
Keywords: PATCH
Depends on:
Blocks: 901253
  Show dependency tree
 
Reported: 2023-03-15 06:40 UTC by Daniel Harding
Modified: 2023-03-15 21:59 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---

Attachments
media-video/pipewire: fix elog message logic (file_901265.txt,1.97 KB, text/plain)
2023-03-15 06:40 UTC, Daniel Harding 		Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Harding 2023-03-15 06:40:30 UTC 
Created attachment 857759 [details]
media-video/pipewire: fix elog message logic

Commit 619021553a64bbdd01bda58dbd0858d40b147977 reworked the elog logic when installing media-video/pipewire, but it has a minor bug:  in pkg_preinst(), HAD_SOUND_SERVER should indicate if media-vidoe/pipewire was previously installed with USE=sound-server, but it never gets set to 1:

https://gitweb.gentoo.org/repo/gentoo.git/tree/media-video/pipewire/pipewire-0.3.66-r1.ebuild?id=619021553a64bbdd01bda58dbd0858d40b147977#n327

See the attached patch for a fix.
Comment 1 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2023-03-15 06:47:51 UTC 
cheers Daniel
Comment 2 Larry the Git Cow gentoo-dev 2023-03-15 06:48:01 UTC 
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=cffb448329920bf0630c4bbeb0b9d46a08e044fb

commit cffb448329920bf0630c4bbeb0b9d46a08e044fb
Author:     Daniel Harding <dharding@living180.net>
AuthorDate: 2023-03-15 06:37:11 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2023-03-15 06:47:49 +0000

    media-video/pipewire: fix elog message logic
    
    Closes: https://bugs.gentoo.org/901265
    Signed-off-by: Daniel Harding <dharding@living180.net>
    Signed-off-by: Sam James <sam@gentoo.org>

 media-video/pipewire/pipewire-0.3.66-r1.ebuild | 2 +-
 media-video/pipewire/pipewire-0.3.67.ebuild    | 2 +-
 media-video/pipewire/pipewire-9999.ebuild      | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)