901017 – go-module.eclass: calls tc-endian without inheriting toolchain-funcs

Bug 901017 - go-module.eclass: calls tc-endian without inheriting toolchain-funcs

Summary: go-module.eclass: calls tc-endian without inheriting toolchain-funcs

Status:	RESOLVED FIXED

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	Eclasses (show other bugs)
Hardware:	All Linux

Importance:	Normal normal (vote)
Assignee:	William Hubbs

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2023-03-13 15:20 UTC by Michał Górny
Modified:	2023-03-13 21:34 UTC (History)
CC List:	1 user (show)

See Also:
Package list:
Runtime testing required:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Michał Górny archtester

2023-03-13 15:20:06 UTC

Noticed while building docker-buildx on ppc64.

The eclass has:

go-module_src_unpack() {
	if use amd64 || use arm || use arm64 ||
		( use ppc64 && [[ $(tc-endian) == "little" ]] ) || use s390 || use x86; then
			GOFLAGS="-buildmode=pie ${GOFLAGS}"
	fi


but it doesn't inherit toolchain-funcs.

Comment 1 Sam James archtester

2023-03-13 15:31:57 UTC

I'll fix it later or you can now, as I'm out

Comment 2 Larry the Git Cow gentoo-dev

2023-03-13 21:34:16 UTC

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=c8e928d996b520af0cbe1eb48224c8184a9a7e2a

commit c8e928d996b520af0cbe1eb48224c8184a9a7e2a
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2023-03-13 21:34:02 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2023-03-13 21:34:02 +0000

    go-module.eclass: inherit toolchain-funcs for tc-endian
    
    Closes: https://bugs.gentoo.org/901017
    Fixes: d4ff29b30952ca957b58b5878550f5d23f908dbf
    Signed-off-by: Sam James <sam@gentoo.org>

 eclass/go-module.eclass | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)