SCons build fails when using scons 4.5.1 Reproducible: Always Steps to Reproduce: 1. Install scons 4.5.1 2. Try to build godot 4.0 Actual Results: Build fails Expected Results: Build succeeds Portage 3.0.45.2 (python 3.11.2-final-0, default/linux/amd64/17.1/desktop/plasma, gcc-12, glibc-2.37-r1, 6.0.5-gentoo-dist x86_64) ================================================================= System uname: Linux-6.0.5-gentoo-dist-x86_64-AMD_Ryzen_9_5900X_12-Core_Processor-with-glibc2.37 KiB Mem: 49241496 total, 8296608 free KiB Swap: 0 total, 0 free Timestamp of repository gentoo: Mon, 13 Mar 2023 07:30:01 +0000 Head commit of repository gentoo: 46ae5fc1a47411431e99a093a5d69e6193577702 Timestamp of repository Drauthius: Sun, 19 Feb 2023 19:48:28 +0000 Head commit of repository Drauthius: 12799a5c85e1a9943c8455c99512cbbcb0b3bdae Timestamp of repository riru: Fri, 03 Mar 2023 06:02:29 +0000 Head commit of repository riru: df948c82e1088a9b15faf5b33dc3affbcbb164b0 Timestamp of repository steam-overlay: Sat, 11 Mar 2023 19:32:01 +0000 Head commit of repository steam-overlay: bf47276e1d5755ae4f3083605c729fd66a1c300b sh bash 5.2_p15-r2 ld GNU ld (Gentoo 2.40 p3) 2.40.0 app-misc/pax-utils: 1.3.7::gentoo app-shells/bash: 5.2_p15-r2::gentoo dev-java/java-config: 2.3.1::gentoo dev-lang/perl: 5.36.0-r2::gentoo dev-lang/python: 3.10.10_p2::gentoo, 3.11.2_p1::gentoo dev-lang/rust: 1.67.1::gentoo dev-util/cmake: 3.25.3::gentoo dev-util/meson: 1.0.1::gentoo sys-apps/baselayout: 2.13-r1::gentoo sys-apps/openrc: 0.46::gentoo sys-apps/sandbox: 2.30-r1::gentoo sys-devel/autoconf: 2.13-r7::gentoo, 2.71-r5::gentoo sys-devel/automake: 1.16.5::gentoo sys-devel/binutils: 2.40-r3::gentoo sys-devel/binutils-config: 5.5::gentoo sys-devel/clang: 15.0.7-r1::gentoo sys-devel/gcc: 12.2.1_p20230121-r1::gentoo sys-devel/gcc-config: 2.10::gentoo sys-devel/libtool: 2.4.7-r1::gentoo sys-devel/lld: 15.0.7::gentoo sys-devel/llvm: 15.0.7::gentoo sys-devel/make: 4.4.1::gentoo sys-kernel/linux-headers: 6.2::gentoo (virtual/os-headers) sys-libs/glibc: 2.37-r1::gentoo Repositories: gentoo location: /var/db/repos/gentoo sync-type: rsync sync-uri: rsync://rsync.gentoo.org/gentoo-portage priority: -1000 volatile: False sync-rsync-extra-opts: sync-rsync-verify-jobs: 1 sync-rsync-verify-metamanifest: yes sync-rsync-verify-max-age: 24 Drauthius location: /var/db/repos/Drauthius sync-type: git sync-uri: https://github.com/gentoo-mirror/Drauthius.git masters: gentoo volatile: False local location: /var/db/repos/local masters: gentoo volatile: False riru location: /var/db/repos/riru sync-type: git sync-uri: https://github.com/gentoo-mirror/riru.git masters: gentoo volatile: False steam-overlay location: /var/db/repos/steam-overlay sync-type: git sync-uri: https://github.com/gentoo-mirror/steam-overlay.git masters: gentoo volatile: False ACCEPT_KEYWORDS="amd64 ~amd64" ACCEPT_LICENSE="@FREE" CBUILD="x86_64-pc-linux-gnu" CFLAGS="-O2 -pipe" CHOST="x86_64-pc-linux-gnu" CONFIG_PROTECT="/etc /usr/share/config /usr/share/gnupg/qualified.txt" CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/dconf /etc/env.d /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo /etc/texmf/language.dat.d /etc/texmf/language.def.d /etc/texmf/updmap.d /etc/texmf/web2c" CXXFLAGS="-O2 -pipe" DISTDIR="/var/cache/distfiles" ENV_UNSET="CARGO_HOME DBUS_SESSION_BUS_ADDRESS DISPLAY GDK_PIXBUF_MODULE_FILE GOBIN GOPATH PERL5LIB PERL5OPT PERLPREFIX PERL_CORE PERL_MB_OPT PERL_MM_OPT XAUTHORITY XDG_CACHE_HOME XDG_CONFIG_HOME XDG_DATA_HOME XDG_RUNTIME_DIR XDG_STATE_HOME" FCFLAGS="-O2 -pipe" FEATURES="assume-digests binpkg-docompress binpkg-dostrip binpkg-logs buildpkg-live config-protect-if-modified distlocks ebuild-locks fixlafiles ipc-sandbox merge-sync multilib-strict network-sandbox news parallel-fetch pid-sandbox preserve-libs protect-owned qa-unresolved-soname-deps sandbox sfperms strict unknown-features-warn unmerge-logs unmerge-orphans userfetch userpriv usersandbox usersync xattr" FFLAGS="-O2 -pipe" GENTOO_MIRRORS="https://mirror.yandex.ru/gentoo-distfiles/ https://gentoo.bloodhost.ru/" LANG="en_US.UTF-8" LDFLAGS="-Wl,-O1 -Wl,--as-needed" LEX="flex" MAKEOPTS="-j20" PKGDIR="/var/cache/binpkgs" PORTAGE_CONFIGROOT="/" PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --omit-dir-times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages --exclude=/.git" PORTAGE_TMPDIR="/var/tmp" SHELL="/bedrock/cross/bin/bash" USE="X a52 aac acl acpi activities alsa amd64 appindicator branding bzip2 cairo cdda cdr cli crypt dbus declarative dist-kernel dri dts dvd dvdr elogind emacs encode exif flac fortran gdbm gif gpm gtk gui iconv icu ipv6 jpeg kde kwallet lcms libglvnd libnotify libtirpc mad mng mp3 mp4 mpeg multilib ncurses networkmanager nls nptl ogg opengl openmp pam pango pcre pdf plasma png policykit ppds pulseaudio qml qt5 readline sdl seccomp semantic-desktop sound spell split-usr ssl startup-notification svg test-rust tiff truetype udev udisks unicode upower usb vorbis widgets wxwidgets x264 xattr xcb xft xml xv xvid zlib" ABI_X86="64" ADA_TARGET="gcc_12_2_0" APACHE2_MODULES="authn_core authz_core socache_shmcb unixd actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" CALLIGRA_FEATURES="karbon sheets words" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" CPU_FLAGS_X86="mmx mmxext sse sse2 aes avx avx2 f16c fma3 pclmul popcnt rdrand sha sse3 sse4_1 sse4_2 sse4a ssse3" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock greis isync itrax mtk3301 nmea ntrip navcom oceanserver oldstyle oncore rtcm104v2 rtcm104v3 sirf skytraq superstar2 timing tsip tripmate tnt ublox ubx" INPUT_DEVICES="libinput joystick wacom" KERNEL="linux" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LIBREOFFICE_EXTENSIONS="presenter-console presenter-minimizer" LUA_SINGLE_TARGET="lua5-1" LUA_TARGETS="lua5-1" OFFICE_IMPLEMENTATION="libreoffice" PHP_TARGETS="php7-4 php8-0" POSTGRES_TARGETS="postgres12 postgres13" PYTHON_SINGLE_TARGET="python3_10" PYTHON_TARGETS="python3_10 python3_11" QEMU_USER_TARGETS="riscv64" RUBY_TARGETS="ruby27 ruby30" USERLAND="GNU" VIDEO_CARDS="amdgpu radeonsi" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq proto steal rawnat logmark ipmark dhcpmac delude chaos account" Unset: ADDR2LINE, AR, ARFLAGS, AS, ASFLAGS, CC, CCLD, CONFIG_SHELL, CPP, CPPFLAGS, CTARGET, CXX, CXXFILT, ELFEDIT, EMERGE_DEFAULT_OPTS, EXTRA_ECONF, F77FLAGS, FC, GCOV, GPROF, INSTALL_MASK, LC_ALL, LD, LFLAGS, LIBTOOL, LINGUAS, MAKE, MAKEFLAGS, NM, OBJCOPY, OBJDUMP, PORTAGE_BINHOST, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS, RANLIB, READELF, RUSTFLAGS, SIZE, STRINGS, STRIP, YACC, YFLAGS
Created attachment 857455 [details] Build log
Godot's upstream points to it being a scons regression and [2] seems to fix it for me (note need USE=pulseaudio to reproduce, should fail right away). Assigning to scons maintainer, workaround would be simple but probably doesn't make much sense to handle it here as it may affect other packages. [1] https://github.com/godotengine/godot/issues/74683 [2] https://github.com/SCons/scons/pull/4322
Do you consider this urgent enough to warrant a backport or should we just wait for the next release?
(In reply to Michał Górny from comment #3) > Do you consider this urgent enough to warrant a backport or should we just > wait for the next release? Well I wouldn't call it urgent and can wait a bit to see. It'll start to be annoying if the release keeps dragging for another week+ and/or if there's a new godot release that needs to be able to build.
Ok, please ping me or comment on the bug when that happens ;-).
(In reply to Michał Górny from comment #5) > Ok, please ping me or comment on the bug when that happens ;-). Well, godot 4.0.1 was just released and but there's still no new scons. Either needs a fix or I'll have to put a <4.5.1 >4.5.1 range
(In reply to Ionen Wolkens from comment #6) > (In reply to Michał Górny from comment #5) > > Ok, please ping me or comment on the bug when that happens ;-). > Well, godot 4.0.1 was just released and but there's still no new scons. > Either needs a fix or I'll have to put a <4.5.1 >4.5.1 range well, I guess I'll do that either way to ensure it's updated first if there's a fix.
Ok, I'll push 4.5.1-r1 shortly.
(In reply to Michał Górny from comment #8) > Ok, I'll push 4.5.1-r1 shortly. Thanks, I'll check if it works with it and do the bump if all good then.
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=0e52f021220e829b020786e14e15eb07fa9bc2ab commit 0e52f021220e829b020786e14e15eb07fa9bc2ab Author: Michał Górny <mgorny@gentoo.org> AuthorDate: 2023-03-20 19:04:52 +0000 Commit: Michał Górny <mgorny@gentoo.org> CommitDate: 2023-03-20 19:29:21 +0000 dev-util/scons: Backport MergeFlags fix to 4.5.1 Closes: https://bugs.gentoo.org/900971 Signed-off-by: Michał Górny <mgorny@gentoo.org> dev-util/scons/Manifest | 1 + .../{scons-4.5.1.ebuild => scons-4.5.1-r1.ebuild} | 18 ++++++++---------- 2 files changed, 9 insertions(+), 10 deletions(-)
Was scratching my head as to why it didn't work but then I seen what's going on in this ebuild, it may have been simpler to pick only the Environment.py change from the patch so it applies to the non-gh version. This is patching SCons/Environment.py but it's actually using src/SCons/Environment.py
I pushed the godot update anyway, except excluded the broken -r1 as well. Seems(?) other packages are affected wrt bug #902463, not that I looked too closely at that but it has CPPDEFINES in the error which is related.
>https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=17774331ffea >Apparently it didn't work. This project is such a mess. It does work, the patch was just not actually applied on the installed files, see last line on comment #11 That aside, if you prefer not to adjust the patch/ebuild, could mask it until next release.
I get what happened. I need to look into making the ebuild not use two disjoint source trees, sigh.
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=0b84ed55f8f36b3307ea5b9ea44be8f76f0adf2d commit 0b84ed55f8f36b3307ea5b9ea44be8f76f0adf2d Author: Michał Górny <mgorny@gentoo.org> AuthorDate: 2023-03-20 19:04:52 +0000 Commit: Michał Górny <mgorny@gentoo.org> CommitDate: 2023-03-21 12:43:59 +0000 dev-util/scons: Backport MergeFlags fix to 4.5.1 Closes: https://bugs.gentoo.org/900971 Signed-off-by: Michał Górny <mgorny@gentoo.org> dev-util/scons/Manifest | 1 + dev-util/scons/scons-4.5.1-r2.ebuild | 20 ++++++++++---------- 2 files changed, 11 insertions(+), 10 deletions(-)
