Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 900885 - net-p2p/transmission: add gui-libs/gtk:4 support
Summary: net-p2p/transmission: add gui-libs/gtk:4 support
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal enhancement
Assignee: Mike Gilbert
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-03-11 18:02 UTC by Vladislav Mikhailikov
Modified: 2023-05-06 00:40 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Proposed ebuild (transmission-4.0.1-r3.ebuild,3.93 KB, text/plain)
2023-03-11 18:05 UTC, Vladislav Mikhailikov
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Vladislav Mikhailikov 2023-03-11 18:02:49 UTC
net-p2p/transmission-4.x fully supports gtk4 but ebuild lacks support for gtk4, glibmm:2.68 and gtkmm:4.x

Reproducible: Always

Steps to Reproduce:
1. Try to build with glibmm:2.68 and gtkmm:4.x
2. Build fails
Actual Results:  
Build fails

Expected Results:  
Build ok
Comment 1 Vladislav Mikhailikov 2023-03-11 18:05:42 UTC
Created attachment 857303 [details]
Proposed ebuild

The proposed ebuild can use either gtk3 or gtk4 with newer glibmm:2.68 and gtkmm:4.x as GTK stack and Qt5/Qt6 builds for Qt. Builds find for me. I throw off gtk and add gtk3 and gtk4 options. Please check it!
Comment 2 Mike Gilbert gentoo-dev 2023-03-11 19:05:25 UTC
Current GNOME policy is to only support a single GTK+ slot for applications like transmission.

https://wiki.gentoo.org/wiki/Project:GNOME/Gnome_Team_Ebuild_Policies#GTK.2B_USE-flag_and_slots_usage
Comment 3 Vladislav Mikhailikov 2023-03-12 12:08:51 UTC
(In reply to Mike Gilbert from comment #2)
> Current GNOME policy is to only support a single GTK+ slot for applications
> like transmission.
> 
> https://wiki.gentoo.org/wiki/Project:GNOME/Gnome_Team_Ebuild_Policies#GTK.
> 2B_USE-flag_and_slots_usage

Hi Mike! Thank you for suggestion. I read the policy and first that I see is this:

"package is an application with support for multiple gtk+, maintainer is free to select whatever slot he desires to support. It is strongly advised to use gtk+-3 if functionality is equivalent. This is to reduce workload of bugs being triggered with one slot but not the other"

Transmission now supports next UI`s:
- Qt5
- Qt6
- GTK+3/GlibMM:0/GTKMM:3.0
- GTK+4/GlibMM:2.68/GTKMM:4.0

I tried to solve by use of qt5, qt6, gtk3 and gtk4 switches and it fits to the clause above. Am I wrong?
Comment 4 Mike Gilbert gentoo-dev 2023-03-12 15:11:20 UTC
(In reply to Vladislav Mikhailikov from comment #3)

You have misinterpreted the policy. The policy is that transmission may support either gtk:3 or gtk:4, but not both simultaneously.
Comment 5 Vladislav Mikhailikov 2023-03-13 21:00:00 UTC
(In reply to Mike Gilbert from comment #4)
> (In reply to Vladislav Mikhailikov from comment #3)
> 
> You have misinterpreted the policy. The policy is that transmission may
> support either gtk:3 or gtk:4, but not both simultaneously.

Ah, ok. I rewrite the ebuild and submit it once again.
Comment 6 Matt Turner gentoo-dev 2023-04-29 00:14:48 UTC
Is there a reason not to move from gtk3 -> gtk4?
Comment 7 Mike Gilbert gentoo-dev 2023-04-29 01:29:01 UTC
(In reply to Matt Turner from comment #6)
> Is there a reason not to move from gtk3 -> gtk4?

I'm not aware of any reason, but I also don't use the GTK client.
Comment 8 Larry the Git Cow gentoo-dev 2023-05-06 00:40:29 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=f5702821a11671c463d2cc98671e1773619bd292

commit f5702821a11671c463d2cc98671e1773619bd292
Author:     Matt Turner <mattst88@gentoo.org>
AuthorDate: 2023-05-05 18:53:40 +0000
Commit:     Matt Turner <mattst88@gentoo.org>
CommitDate: 2023-05-06 00:39:37 +0000

    net-p2p/transmission: Switch from GTK3 to GTK4
    
    Closes: https://bugs.gentoo.org/900885
    Closes: https://github.com/gentoo/gentoo/pull/30882
    Signed-off-by: Matt Turner <mattst88@gentoo.org>

 net-p2p/transmission/transmission-4.0.3-r1.ebuild | 153 ++++++++++++++++++++++
 net-p2p/transmission/transmission-9999.ebuild     |   6 +-
 2 files changed, 156 insertions(+), 3 deletions(-)