Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 900863 - media-libs/alsa-lib media-plugins/alsa-plugins: minor ebuild issue
Summary: media-libs/alsa-lib media-plugins/alsa-plugins: minor ebuild issue
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal minor
Assignee: Gentoo ALSA team [DISABLED]
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-03-11 12:37 UTC by Rafał Mużyło
Modified: 2023-05-05 04:13 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Rafał Mużyło 2023-03-11 12:37:18 UTC
So, I've been wondering for quite awhile (not sure whether or not I've mentioned this in any of the relevant bugs I've filed in the past)...

Why exactly media-libs/alsa-lib and media-plugins/alsa-plugins remove static libs in the multilib_src_install_all, instead of doing the same thing overwhelming majority of other such packages do - simply passing '--disable-static' in src_configure and not building them in the first place ?

AFAICT, the later works just fine...
Comment 1 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2023-05-05 04:12:36 UTC
No idea, historical cruft I guess. EAPI 8 passes --disable-static by default anyway.

Of course, we have to keep the .la removal, but cleaned up now. Thanks.
Comment 2 Larry the Git Cow gentoo-dev 2023-05-05 04:13:50 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=94f0aaa70d2d7932964b54dc3ede833255783772

commit 94f0aaa70d2d7932964b54dc3ede833255783772
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2023-05-05 04:13:22 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2023-05-05 04:13:22 +0000

    media-plugins/alsa-plugins: tidy up static libs removal
    
    No need now we have --disable-static by default w/ EAPI 8.
    
    Closes: https://bugs.gentoo.org/900863
    Signed-off-by: Sam James <sam@gentoo.org>

 media-plugins/alsa-plugins/alsa-plugins-1.2.7.1-r1.ebuild | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=c84090acc76794ed7332fef9a77c97ff17bb10df

commit c84090acc76794ed7332fef9a77c97ff17bb10df
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2023-05-05 04:04:33 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2023-05-05 04:11:26 +0000

    media-libs/alsa-lib: add 1.2.9
    
    Closes: https://bugs.gentoo.org/900863
    Signed-off-by: Sam James <sam@gentoo.org>

 media-libs/alsa-lib/Manifest              |  1 +
 media-libs/alsa-lib/alsa-lib-1.2.9.ebuild | 98 +++++++++++++++++++++++++++++++
 2 files changed, 99 insertions(+)