Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 900727 - sci-libs/rocFFT-5.1.3: header install location /usr/include/rocFFT is inconsistent with other rocXYZ libraries, which use lowercase include directories
Summary: sci-libs/rocFFT-5.1.3: header install location /usr/include/rocFFT is inconsi...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: AMD64 Linux
: Normal normal (vote)
Assignee: Gentoo Science Related Packages
URL:
Whiteboard:
Keywords: PATCH
Depends on:
Blocks:
 
Reported: 2023-03-10 14:40 UTC by Jan-Matthias Braun
Modified: 2023-07-30 04:39 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Change the install location to /usr/include/rocfft (rocFFT-include-install-dir.patch,778 bytes, patch)
2023-03-10 14:41 UTC, Jan-Matthias Braun
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jan-Matthias Braun 2023-03-10 14:40:42 UTC
Examples for other include directories are /usr/include/{rocblas, rocprim, rocrand, rocsolver, rocsparse, roctracer}, a scheme which is broken by /usr/include/rocFFT

While this is not a big issue, it feels like consistency helps with small issues. In my case I am trying to reproduce a rocm enabled tensorflow build following bug 705712 - sci-libs/tensorflow - enable rocm backend support for AMD video cards. Most of the patches seem to resolve issues with include locations in gentoo rocm deployment, the mentioned rocFFT inconsistency being a minor source of confusion. :-)

Reproducible: Always
Comment 1 Jan-Matthias Braun 2023-03-10 14:41:15 UTC
Created attachment 857171 [details, diff]
Change the install location to /usr/include/rocfft
Comment 2 Larry the Git Cow gentoo-dev 2023-07-30 04:39:04 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=4949344c990b09713c1f8a3895c902916170fed0

commit 4949344c990b09713c1f8a3895c902916170fed0
Author:     Benda Xu <heroxbd@gentoo.org>
AuthorDate: 2023-07-29 07:27:48 +0000
Commit:     Benda Xu <heroxbd@gentoo.org>
CommitDate: 2023-07-30 04:35:33 +0000

    sci-libs/rocFFT: normalize the header directory.
    
    Closes: https://bugs.gentoo.org/900727
    Suggested-by: Jan-Matthias Braun <jan_braun@gmx.net>
    Signed-off-by: Benda Xu <heroxbd@gentoo.org>

 sci-libs/rocFFT/rocFFT-5.1.3-r1.ebuild | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)