Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 900707 - dev-cpp/opentelemetry-cpp-1.6.0 fails to compile (MUSL-CLANG-SYSTEM): TUDPTransport.cc:71:7: error: no type named close in the global namespace
Summary: dev-cpp/opentelemetry-cpp-1.6.0 fails to compile (MUSL-CLANG-SYSTEM): TUDPTra...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Patrick McLean
URL:
Whiteboard:
Keywords: PullRequest
: 908653 908686 (view as bug list)
Depends on:
Blocks:
 
Reported: 2023-03-10 11:32 UTC by Agostino Sarubbo
Modified: 2024-12-01 12:52 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log (build.log,345.79 KB, text/plain)
2023-03-10 11:32 UTC, Agostino Sarubbo
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Agostino Sarubbo gentoo-dev 2023-03-10 11:32:27 UTC
https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: dev-cpp/opentelemetry-cpp-1.6.0 fails to compile (MUSL-CLANG-SYSTEM).
Discovered on: amd64 (internal ref: tinderbox_musl)

NOTE:
(MUSL-CLANG-SYSTEM) in the summary means that bug was found on a machine that runs MUSL libc + clang16 but this bug MAY or MAY NOT BE related to musl/clang16.
Comment 1 Agostino Sarubbo gentoo-dev 2023-03-10 11:32:30 UTC
Created attachment 857155 [details]
build.log

build log and emerge --info
Comment 2 Agostino Sarubbo gentoo-dev 2023-03-10 11:32:31 UTC
Error(s) that match a know pattern in addition to what has been reported in the summary:


FAILED: exporters/jaeger/CMakeFiles/opentelemetry_exporter_jaeger_trace.dir/src/TUDPTransport.cc.o 
/var/tmp/portage/dev-cpp/opentelemetry-cpp-1.6.0/work/opentelemetry-cpp-1.6.0/exporters/jaeger/src/TUDPTransport.cc:71:7: error: no type named 'close' in the global namespace
Comment 3 Agostino Sarubbo gentoo-dev 2024-01-16 17:16:50 UTC
*** Bug 908653 has been marked as a duplicate of this bug. ***
Comment 4 Agostino Sarubbo gentoo-dev 2024-01-16 17:16:52 UTC
*** Bug 908686 has been marked as a duplicate of this bug. ***
Comment 5 Yiyang Wu 2024-08-14 12:54:08 UTC
I reproduced this issue on x86_64-pc-linux-gnu with =dev-libs/thrift-0.18.1-r1

The issue is resolved either with =dev-libs/thrift-0.20.0 or bumping 
opentelemetry-cpp to 1.16.1 (because it removed jaeger in
https://github.com/open-telemetry/opentelemetry-cpp/pull/2031)

and I can successfully build opentelemetry-cpp 1.6.0 with thrift 0.20.0
on musl clang system.
Comment 6 Yiyang Wu 2024-08-14 13:03:32 UTC
(In reply to Yiyang Wu from comment #5)
> I reproduced this issue on x86_64-pc-linux-gnu with
> =dev-libs/thrift-0.18.1-r1
> 
> The issue is resolved either with =dev-libs/thrift-0.20.0 or bumping 
> opentelemetry-cpp to 1.16.1 (because it removed jaeger in
> https://github.com/open-telemetry/opentelemetry-cpp/pull/2031)
> 
> and I can successfully build opentelemetry-cpp 1.6.0 with thrift 0.20.0
> on musl clang system.

=dev-libs/thrift-0.16.0-r2 is also fine, so the stable musl clang profile 
have no issue.
Comment 7 Larry the Git Cow gentoo-dev 2024-12-01 12:52:19 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=553a1dc43f616730fc4891fdd72a0aeeff70bf9a

commit 553a1dc43f616730fc4891fdd72a0aeeff70bf9a
Author:     Yiyang Wu <xgreenlandforwyy@gmail.com>
AuthorDate: 2024-08-14 13:01:09 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2024-12-01 12:50:35 +0000

    dev-cpp/opentelemetry-cpp: thrift-0.18.1 cause build error
    
    Closes: https://bugs.gentoo.org/900707
    Signed-off-by: Yiyang Wu <xgreenlandforwyy@gmail.com>
    Signed-off-by: Sam James <sam@gentoo.org>

 ...{opentelemetry-cpp-1.6.0.ebuild => opentelemetry-cpp-1.6.0-r1.ebuild} | 1 +
 1 file changed, 1 insertion(+)

Additionally, it has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=ed2effe507a2e8779920f8f0d5be6a19d5bff3a4

commit ed2effe507a2e8779920f8f0d5be6a19d5bff3a4
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2024-12-01 12:51:38 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2024-12-01 12:51:38 +0000

    dev-cpp/opentelemetry-cpp: drop blocker
    
    Blockers aren't the right mechanism for this (they're only for file collisions) but
    we have newer thrift in tree now anyway.
    
    Bug: https://bugs.gentoo.org/900707
    Signed-off-by: Sam James <sam@gentoo.org>

 dev-cpp/opentelemetry-cpp/opentelemetry-cpp-1.6.0-r1.ebuild | 1 -
 1 file changed, 1 deletion(-)

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=6adc7de0200a987ef3602e9235c8c933fa514114

commit 6adc7de0200a987ef3602e9235c8c933fa514114
Author:     Yiyang Wu <xgreenlandforwyy@gmail.com>
AuthorDate: 2024-08-14 09:55:11 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2024-12-01 12:50:34 +0000

    dev-cpp/opentelemetry-cpp: add 1.16.1
    
    IUSE=jager and dev-libs/thrift dependency is removed by
    https://github.com/open-telemetry/opentelemetry-cpp/pull/2031
    
    Add remote-id to metadata
    
    Bug: https://bugs.gentoo.org/900707
    Signed-off-by: Yiyang Wu <xgreenlandforwyy@gmail.com>
    Signed-off-by: Sam James <sam@gentoo.org>

 dev-cpp/opentelemetry-cpp/Manifest                 |  1 +
 dev-cpp/opentelemetry-cpp/metadata.xml             |  3 ++
 .../opentelemetry-cpp-1.16.1.ebuild                | 48 ++++++++++++++++++++++
 3 files changed, 52 insertions(+)