Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 900230 - net-misc/udpcast-20211207 lost --fec option because of missing entry in CFLAGS
Summary: net-misc/udpcast-20211207 lost --fec option because of missing entry in CFLAGS
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: AMD64 Linux
: Normal normal (vote)
Assignee: Gentoo Netmon project
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-03-08 04:54 UTC by Robert Theron Brockman II
Modified: 2023-03-10 08:24 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Robert Theron Brockman II 2023-03-08 04:54:44 UTC
The latest ebuild for udpcast has lost the --fec option for udp-receiver.  A simple compile from source still works.

The ebuild version:

wizard /dev/shm/udpcast-20211207 # udp-sender --fec
udp-sender: unrecognized option '--fec'
udp-sender [--file file] [--full-duplex] [--pipe pipe] [--portbase portbase] [--blocksize size] [--interface net-interface] [--mcast-data-address data-mcast-address] [--mcast-rdv-address mcast-rdv-address] [--max-bitrate bitrate] [--pointopoint|--nopointopoint] [--async] [--log file] [--no-progress] [--min-slice-size min] [--max-slice-size max] [--slice-size] [--ttl time-to-live] [--fec <stripes>x<redundancy>/<stripesize>] [--print-seed] [--rexmit-hello-interval interval] [--autostart autostart] [--broadcast] [--min-receivers receivers] [--min-wait sec] [--max-wait sec] [--start-timeout n] [--retries-until-drop n] [--nokbd] [--bw-period n] [--streaming] [--rehello-offset offs] [--rate-governor module:parameters] [--autorate][--license]


The source version:

wizard /dev/shm/udpcast-20211207 # ./udp-sender --fec
./udp-sender: option '--fec' requires an argument
./udp-sender [--file file] [--full-duplex] [--pipe pipe] [--portbase portbase] [--blocksize size] [--interface net-interface] [--mcast-data-address data-mcast-address] [--mcast-rdv-address mcast-rdv-address] [--max-bitrate bitrate] [--pointopoint|--nopointopoint] [--async] [--log file] [--no-progress] [--min-slice-size min] [--max-slice-size max] [--slice-size] [--ttl time-to-live] [--fec <stripes>x<redundancy>/<stripesize>] [--print-seed] [--rexmit-hello-interval interval] [--autostart autostart] [--broadcast] [--min-receivers receivers] [--min-wait sec] [--max-wait sec] [--start-timeout n] [--retries-until-drop n] [--nokbd] [--bw-period n] [--streaming] [--rehello-offset offs] [--rate-governor module:parameters] [--autorate][--license]

This is caused by a missing CFLAGS entry in the Makefile, namely -DBB_FEATURE_UDPCAST_FEC.  

The ebuild version:

CFLAGS     = -O2 -pipe -Wall
CPPFLAGS   = -I.  -I.  -DUSE_ASSEMBLER

The source version:
CFLAGS     = -O3 -Wall -DBB_FEATURE_UDPCAST_FEC -DUSE_SYSLOG -DUSE_ASSEMBLER -Wall
CPPFLAGS   = -I.  -I. 

Adding -DBB_FEATURE_UDPCAST_FEC to CFLAGS in /etc/portage/make.conf fixes the problem.  More digging reveals that the patch for the previous ebuild was correctly adding this entry whereas the new patch does not.  The maintainer simply needs to add the functionality of udpcast-20200328-gentoo.patch back in for the new version.

Should be an trivial fix.
Comment 1 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2023-03-08 05:21:24 UTC
The old patch was just touching -DUSE_ASSEMBLER -O6. It didn't add -DBB_FEATURE_UDPCAST_FEC as it was already there, going off `git diff 72eaf7b386b238b203b1add1d4ef4b2e8df83e7c~1..72eaf7b386b238b203b1add1d4ef4b2e8df83e7c`.

Anyway, let's add append-cppflags -DBB_FEATURE_UDPCAST_FEC in the ebuild then.
Comment 2 Larry the Git Cow gentoo-dev 2023-03-08 05:22:54 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=63fc2ba529edd89eb6221807a2a93a9bea64f83d

commit 63fc2ba529edd89eb6221807a2a93a9bea64f83d
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2023-03-08 05:22:31 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2023-03-08 05:22:45 +0000

    net-misc/udpcast: restore FEC
    
    Closes: https://bugs.gentoo.org/900230
    Signed-off-by: Sam James <sam@gentoo.org>

 net-misc/udpcast/udpcast-20211207-r1.ebuild | 35 +++++++++++++++++++++++++++++
 1 file changed, 35 insertions(+)
Comment 3 Robert Theron Brockman II 2023-03-08 16:47:09 UTC
Yay, it works again now!  Thank you!
Comment 4 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2023-03-10 08:24:14 UTC
:)