Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 899958 - sys-kernel/linux-firmware: add option to compress firmware files with zstd
Summary: sys-kernel/linux-firmware: add option to compress firmware files with zstd
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Chí-Thanh Christopher Nguyễn
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks:
 
Reported: 2023-03-06 20:46 UTC by Alexander Tsoy
Modified: 2023-04-01 17:00 UTC (History)
4 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Alexander Tsoy 2023-03-06 20:46:57 UTC
linux supports loading zstd-compressed firmware since version 5.19.
Comment 1 Larry the Git Cow gentoo-dev 2023-03-12 15:37:07 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=f238d9fa4750bf7f89ed1fcb78546fae15b6f032

commit f238d9fa4750bf7f89ed1fcb78546fae15b6f032
Author:     Alexander Tsoy <alexander@tsoy.me>
AuthorDate: 2023-03-06 20:43:14 +0000
Commit:     Mike Pagano <mpagano@gentoo.org>
CommitDate: 2023-03-12 15:36:43 +0000

    sys-kernel/linux-firmware: add option to compress with zstd
    
    With compression level 15 zstd is still much faster than xz and allows
    to save some space compared to default level 3:
    * uncompressed: 872M
    * zstd:         412M
    * zstd (-15):   400M
    * xz:           364M
    
    Also some fixes:
    * do not rename symlinks pointing to directories
    * add missing build-time dependencies
    * call linux_config_exists before doing kernel config checks
    
    Closes: https://bugs.gentoo.org/899958
    Signed-off-by: Alexander Tsoy <alexander@tsoy.me>
    Closes: https://github.com/gentoo/gentoo/pull/29963
    Signed-off-by: Mike Pagano <mpagano@gentoo.org>

 .../linux-firmware/linux-firmware-99999999.ebuild  | 58 +++++++++++++++++-----
 sys-kernel/linux-firmware/metadata.xml             |  2 +
 2 files changed, 48 insertions(+), 12 deletions(-)
Comment 2 Larry the Git Cow gentoo-dev 2023-03-12 19:09:27 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=1a6415e74760374e09b3971adc32b222e42c6789

commit 1a6415e74760374e09b3971adc32b222e42c6789
Author:     Mike Pagano <mpagano@gentoo.org>
AuthorDate: 2023-03-12 19:08:32 +0000
Commit:     Mike Pagano <mpagano@gentoo.org>
CommitDate: 2023-03-12 19:08:32 +0000

    sys-kernel/linux-firmware: add option to compress with zstd
    
    Thanks to Alexander Tsoy
    
    Bug: https://bugs.gentoo.org/899958
    
    Signed-off-by: Mike Pagano <mpagano@gentoo.org>

 .../linux-firmware-20230310-r1.ebuild              | 407 +++++++++++++++++++++
 1 file changed, 407 insertions(+)
Comment 3 Larry the Git Cow gentoo-dev 2023-03-18 14:58:19 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=624ae2809186f915f6cd343daf719ab382141e51

commit 624ae2809186f915f6cd343daf719ab382141e51
Author:     Mike Pagano <mpagano@gentoo.org>
AuthorDate: 2023-03-18 14:57:13 +0000
Commit:     Mike Pagano <mpagano@gentoo.org>
CommitDate: 2023-03-18 14:57:13 +0000

    sys-kernel/linux-firmware: fix kernel config checking
    
    Remove the ! linux_config_exists check because the function will
    always fail when /proc/config.gz support is not enabled because
    KV_OUT_DIR needed by linux_config_src_exists is not populated yet
    
    die if USE=compress-zstd is set with an unsupported kernel
    Thanks to xxc3nsoredxx
    
    Closes: https://bugs.gentoo.org/899958
    Closes: https://github.com/gentoo/gentoo/pull/30148
    
    Author: xxc2ensoredxx
    Signed-off-by: Mike Pagano <mpagano@gentoo.org>

 .../linux-firmware-20230310-r2.ebuild              | 403 +++++++++++++++++++++
 1 file changed, 403 insertions(+)

Additionally, it has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=b5f6b85b5d1516749d2a310746b6b460de266d30

commit b5f6b85b5d1516749d2a310746b6b460de266d30
Author:     Mike Pagano <mpagano@gentoo.org>
AuthorDate: 2023-03-18 14:51:03 +0000
Commit:     Mike Pagano <mpagano@gentoo.org>
CommitDate: 2023-03-18 14:51:03 +0000

    sys-kernel/linux-firmware: fix kernel config checking for -99999999
    
    Remove the ! linux_config_exists check because the function will
    always fail when /proc/config.gz support is not enabled because
    KV_OUT_DIR needed by linux_config_src_exists is not populated yet
    
    die if USE=compress-zstd is set with an unsupported kernel
    Thanks to xxc3nsoredxx
    
    Bug: https://bugs.gentoo.org/899958
    
    Author: xxc2ensoredxx
    Signed-off-by: Mike Pagano <mpagano@gentoo.org>

 .../linux-firmware/linux-firmware-99999999.ebuild  | 22 +++++++++-------------
 1 file changed, 9 insertions(+), 13 deletions(-)