Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 899714 - media-libs/libplacebo * keywording request for media-video/ffmpeg(?)
Summary: media-libs/libplacebo * keywording request for media-video/ffmpeg(?)
Status: RESOLVED WONTFIX
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Keywording (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Ionen Wolkens
URL:
Whiteboard:
Keywords:
: 899716 899720 899722 899724 899726 899728 899730 (view as bug list)
Depends on:
Blocks:
 
Reported: 2023-03-05 21:31 UTC by Craig Andrews
Modified: 2023-03-12 18:53 UTC (History)
4 users (show)

See Also:
Package list:
media-libs/libplacebo ~arm ~arm64 ~hppa ~loong ~ppc ~riscv media-libs/shaderc ^ dev-util/glslang ^ dev-util/vulkan-headers ^ media-libs/shaderc ^ dev-util/spirv-headers ^ dev-util/spirv-tools ^
Runtime testing required: ---
nattka: sanity-check+


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Craig Andrews gentoo-dev 2023-03-05 21:31:54 UTC
media-libs/libplacebo is a dependency of ffmpeg
[+] Comment 1 NATTkA bot gentoo-dev Security 2023-03-05 21:36:21 UTC Comment hidden (obsolete)
[+] Comment 2 NATTkA bot gentoo-dev Security 2023-03-05 21:40:25 UTC Comment hidden (obsolete)
Comment 3 Andreas Sturmlechner gentoo-dev 2023-03-05 22:02:23 UTC
media-libs/libplacebo IUSE is masked on most arches, so why are you creating x different bugs for it and adding arches without maintainer input?
Comment 4 Andreas Sturmlechner gentoo-dev 2023-03-05 22:08:49 UTC
*** Bug 899716 has been marked as a duplicate of this bug. ***
Comment 5 Andreas Sturmlechner gentoo-dev 2023-03-05 22:09:01 UTC
*** Bug 899720 has been marked as a duplicate of this bug. ***
Comment 6 Andreas Sturmlechner gentoo-dev 2023-03-05 22:09:13 UTC
*** Bug 899722 has been marked as a duplicate of this bug. ***
Comment 7 Andreas Sturmlechner gentoo-dev 2023-03-05 22:09:26 UTC
*** Bug 899724 has been marked as a duplicate of this bug. ***
Comment 8 Andreas Sturmlechner gentoo-dev 2023-03-05 22:09:50 UTC
*** Bug 899726 has been marked as a duplicate of this bug. ***
Comment 9 Andreas Sturmlechner gentoo-dev 2023-03-05 22:10:02 UTC
*** Bug 899728 has been marked as a duplicate of this bug. ***
Comment 10 Andreas Sturmlechner gentoo-dev 2023-03-05 22:10:31 UTC
*** Bug 899730 has been marked as a duplicate of this bug. ***
Comment 11 Craig Andrews gentoo-dev 2023-03-05 22:11:34 UTC
(In reply to Andreas Sturmlechner from comment #3)
> media-libs/libplacebo IUSE is masked on most arches, so why are you creating
> x different bugs for it and adding arches without maintainer input?

Where is it masked on most arches?

I see the libplacebo flag masked for the media-video/vlc for few arches, for example:
https://github.com/gentoo/gentoo/blob/e678177aed8f5be31a8fb35a9a135f9f8f45128c/profiles/arch/powerpc/ppc64/package.use.mask#L111

My reading of the comments is that the problem is that media-libs/libplacebo is simply not keyworded for other arches yet - so I'm trying to help out and get the things moving on adding those arch keywords.

And I see nothing about media-libs/libplacebo the package being masked on any arch, and the ebuild doesn't have any minus arch keywords https://github.com/gentoo/gentoo/blob/e678177aed8f5be31a8fb35a9a135f9f8f45128c/media-libs/libplacebo/libplacebo-5.229.2.ebuild#L18 nor does the ebuild have comments about not working on other arches... so why not make the keywording requests?
Comment 12 Andreas Sturmlechner gentoo-dev 2023-03-05 22:14:54 UTC
That's why I would wait for maintainer input before adding dead arches to media-libs/libplacebo and Vulkan.
[+] Comment 13 NATTkA bot gentoo-dev Security 2023-03-05 22:16:20 UTC Comment hidden (obsolete)
Comment 14 Andreas Sturmlechner gentoo-dev 2023-03-05 22:19:17 UTC
(In reply to Craig Andrews from comment #11)
> ... so why not make the keywording requests?
Also please check out what NATTkA can do for you in the package list before even CCing arches yet.
Comment 15 Andreas Sturmlechner gentoo-dev 2023-03-05 22:22:16 UTC
So, ~ia64 would require keywording dev-ruby/asciidoctor, and with it even dev-lang/ruby. Or masking media-libs/shaderc[doc] IUSE.
Comment 16 Andreas Sturmlechner gentoo-dev 2023-03-05 22:23:58 UTC
...but ruby was dekeyworded, because ia64 is a dead arch, so going further there makes no sense.
Comment 17 Andreas Sturmlechner gentoo-dev 2023-03-05 22:28:25 UTC
Dropping ~ia64 then. It can be added back when an appropriate USE mask is in place, in theory.
[+] Comment 18 NATTkA bot gentoo-dev Security 2023-03-05 22:32:20 UTC Comment hidden (obsolete)
Comment 19 Andreas Sturmlechner gentoo-dev 2023-03-05 22:34:22 UTC
Same for sparc.
Comment 20 Andreas Sturmlechner gentoo-dev 2023-03-05 22:42:11 UTC
Now you can give maintainers some time to react, or add CC-ARCHES anyway after timeout.

Btw this would be easier if you were on IRC to reach out.
Comment 21 Matt Turner gentoo-dev 2023-03-06 01:25:25 UTC
Keywording the vulkan stack on ppc and hppa doesn't make any sense to me.
Comment 22 Ionen Wolkens gentoo-dev 2023-03-06 02:58:02 UTC
(In reply to Matt Turner from comment #21)
> Keywording the vulkan stack on ppc and hppa doesn't make any sense to me.

Yeah, long story short I don't think this is useful? It's just adding keywords for the sake of adding keywords.
Comment 23 Ionen Wolkens gentoo-dev 2023-03-06 02:58:59 UTC
If going to add keywords I'd like to hear from someone that actually make use of these things on these arches rather than "it's a dependency of ffmpeg".
Comment 24 Ionen Wolkens gentoo-dev 2023-03-06 03:02:59 UTC
(In reply to Ionen Wolkens from comment #23)
> If going to add keywords I'd like to hear from someone that actually make
> use of these things on these arches rather than "it's a dependency of
> ffmpeg".
But anyhow, libplacebo is trivial unlike the vulkan stack, so up to vulkan maintainers.
Comment 25 Nick Sarnie gentoo-dev 2023-03-06 04:02:37 UTC
I agree it seems a bit strange from my pov as one of the vulkan maintainers.

I would prefer we just mask ffmpeg USE=vulkan/libplacebo on these arches.
Comment 26 Ionen Wolkens gentoo-dev 2023-03-09 19:28:02 UTC
I'll go ahead and close this, if someone actually use this and/or vulkan on these arches they're welcome to do keywording/requests as needed -- and then we can remove the USE masks much like what happened for libplacebo's ppc64 (for something simple, can check if mpv[libplacebo]'s `mpv -vo gpu-next` works)

ffmpeg being keyworded a bit everywhere can make sense, but GPU-accelerated features that aren't usable everywhere tend to make less sense -- and libplacebo is currently gated behind a USE flag on ffmpeg-5 that can be masked and so there's no hard requirement for doing this.
Comment 27 Larry the Git Cow gentoo-dev 2023-03-12 18:53:24 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=3d69680669446f44c4c1c611b60f24fcc46b7de6

commit 3d69680669446f44c4c1c611b60f24fcc46b7de6
Author:     Craig Andrews <candrews@gentoo.org>
AuthorDate: 2023-03-09 19:44:24 +0000
Commit:     Craig Andrews <candrews@gentoo.org>
CommitDate: 2023-03-12 18:53:09 +0000

    profiles: mask media-video/ffmpeg[libplacebo] except ppc64,x86,amd64
    
    libplacebo is only available on ppc64,x86,amd64, so mask it everywhere
    except on those archs.
    
    Bug: https://bugs.gentoo.org/899714
    Closes: https://github.com/gentoo/gentoo/pull/29948
    Signed-off-by: Craig Andrews <candrews@gentoo.org>

 profiles/arch/amd64/package.use.mask              | 4 ++++
 profiles/arch/base/package.use.mask               | 4 ++++
 profiles/arch/powerpc/ppc64/64le/package.use.mask | 4 ++++
 profiles/arch/x86/package.use.mask                | 4 ++++
 4 files changed, 16 insertions(+)