Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 899684 - net-libs/xdp-tools-1.3.1 fails to compile: ERROR: Cannot find tool bpftool
Summary: net-libs/xdp-tools-1.3.1 fails to compile: ERROR: Cannot find tool bpftool
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Jason A. Donenfeld
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-03-05 13:46 UTC by Agostino Sarubbo
Modified: 2023-03-05 14:50 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log (build.log,45.68 KB, text/plain)
2023-03-05 13:46 UTC, Agostino Sarubbo
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Agostino Sarubbo gentoo-dev 2023-03-05 13:46:09 UTC
https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: net-libs/xdp-tools-1.3.1 fails to compile.
Discovered on: amd64 (internal ref: ci)
Comment 1 Agostino Sarubbo gentoo-dev 2023-03-05 13:46:11 UTC
CC'ing also the author of the commit (8eea55ff639c63ce54f5feba1d3300e40d4814b9)
Comment 2 Agostino Sarubbo gentoo-dev 2023-03-05 13:46:12 UTC
Created attachment 856196 [details]
build.log

build log and emerge --info
Comment 3 Holger Hoffstätte 2023-03-05 13:59:37 UTC
I have bpftool installed separately - it seems that it is a recently-added hard requirement.
Comment 4 Holger Hoffstätte 2023-03-05 14:02:37 UTC
Other people have tripped over this as well: https://github.com/xdp-project/xdp-tools/issues/286
Comment 5 Holger Hoffstätte 2023-03-05 14:08:25 UTC
Sam, can you quickly jam "dev-util/bpftool" into DEPEND? That should fix it.
Comment 6 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2023-03-05 14:13:21 UTC
(In reply to Holger Hoffstätte from comment #5)
> Sam, can you quickly jam "dev-util/bpftool" into DEPEND? That should fix it.

onit
Comment 7 Holger Hoffstätte 2023-03-05 14:22:37 UTC
This was introdued in https://github.com/xdp-project/xdp-tools/commit/afe49438fbe0b06002fea1c17aa7fd453eba8e5c

Apparently LLVM also needs to be at least 11.
Comment 8 Larry the Git Cow gentoo-dev 2023-03-05 14:38:36 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=9ab962ab16855ce94236098f802219a5fab279a0

commit 9ab962ab16855ce94236098f802219a5fab279a0
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2023-03-05 14:34:11 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2023-03-05 14:36:34 +0000

    net-libs/xdp-tools: add bpftool dep
    
    Closes: https://bugs.gentoo.org/899684
    Signed-off-by: Sam James <sam@gentoo.org>

 net-libs/xdp-tools/xdp-tools-1.3.1.ebuild | 18 ++++++++++--------
 1 file changed, 10 insertions(+), 8 deletions(-)

Additionally, it has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=fa369e7cae03f9e3668ae3e44cfaab8168784fee

commit fa369e7cae03f9e3668ae3e44cfaab8168784fee
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2023-03-05 14:37:50 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2023-03-05 14:38:15 +0000

    net-libs/xdp-tools: restore 1.2.8
    
    Needed because bpftool isn't keyworded everywhere. Rescued from
    8eea55ff639c63ce54f5feba1d3300e40d4814b9.
    
    Bug: https://bugs.gentoo.org/899684
    Signed-off-by: Sam James <sam@gentoo.org>

 net-libs/xdp-tools/Manifest               |  1 +
 net-libs/xdp-tools/xdp-tools-1.2.8.ebuild | 52 +++++++++++++++++++++++++++++++
 2 files changed, 53 insertions(+)
Comment 9 Holger Hoffstätte 2023-03-05 14:48:02 UTC
With 1.2.8 restored I'm afraid you brought back the original bug with the stack-protector (#889842), just add 1.3.1-disable-stack-protector.patch to that as well.

*sigh* all I wanted to do yesterday was write a packet filter.. :(
Comment 10 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2023-03-05 14:50:02 UTC
(In reply to Holger Hoffstätte from comment #9)
> With 1.2.8 restored I'm afraid you brought back the original bug with the
> stack-protector (#889842), just add 1.3.1-disable-stack-protector.patch to
> that as well.

That's fine, as the only people suffering from that are on arm/arm64, and they may not be using Clang. It's only temporary until the keywording is done.