Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 899546 - dev-qt/qtbase[-gui] should not pull in media-libs/libglvnd and dev-util/gtk-update-icon-cache
Summary: dev-qt/qtbase[-gui] should not pull in media-libs/libglvnd and dev-util/gtk-u...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Qt Bug Alias
URL: https://github.com/gentoo/gentoo/pull...
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks:
 
Reported: 2023-03-04 06:35 UTC by microcai
Modified: 2023-09-05 13:05 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description microcai 2023-03-04 06:35:57 UTC
qtbase unconditionally depends on gtk-icon-update and libglvnd whitch is not correct.
I suspect this error is intruduced by qtgui:5, that qtgui does not need to specify a condition when pulls in libglvnd.

also a pull request is sent by me at https://github.com/gentoo/gentoo/pull/29919
Comment 1 Larry the Git Cow gentoo-dev 2023-09-05 13:05:38 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=349d599c0fa3dfc93991ee42f83127a3a28a95a5

commit 349d599c0fa3dfc93991ee42f83127a3a28a95a5
Author:     Ionen Wolkens <ionen@gentoo.org>
AuthorDate: 2023-08-25 00:02:27 +0000
Commit:     Ionen Wolkens <ionen@gentoo.org>
CommitDate: 2023-09-05 13:01:08 +0000

    dev-qt/qtbase: refactor use/dependences handling
    
    Lot of changes here give a full review and re-organizing,
    so unfortunately not going to talk about everything.
    
    For IUSE removals:
    * freetds (disabled): was a no-op, upstream has the subdir
      commented out with a "TODO"
    * jpeg (enabled): we already do this for png and IMO should be
      extended to jpeg as about anyone with USE=gui will have
      libjpeg-turbo either way and it saves headaches for revdeps
    * egl (enabled with USE=opengl): same dependency as USE=opengl
      and if we try to force egl without opengl (like we were despite
      upstream otherwise auto-disables) this results in a build failure
    * vnc+tuio (enabled with USE="gui network"): being a USE made
      more sense in qt5 given needed to depend on qtnetwork
    
    Notable REQUIRED_USE changes:
    * add wayland as an alternative to X and eglfs, eglfs is intended
      for embedded devices (without a WM) and is not necessary for
      normal wayland to work (technically this requirement is still
      not entirely right given other options exists, a postinst to
      warn when have nothing set could be an alternative)
    * drop || ( evdev libinput ) as a requirement, normally Qt does not
      need to handle mouse&keyboard events by itself and this again is for
      embedded devices (however keeping libinput by default as I believe
      it may be needed for gamepads and other special devices)
    
    Tried to make this bit easier to maintain by making the split between
    groups clearer, and also removed some options and left them to
    Qt to set based on others (there is a *lot* that could be passed
    and it'd be unmaintainable -- can always consider specifics if
    users need something special though).
    
    About options, -DFEATURE_reduce_relocations=ON is notably better
    removed as it can apparently break things on some arches if forced.
    
    wrt bug #899546, libglvnd is now optional (with [X?] too), and this
    removes gtk-update-icon-cache altegether. Latter is only used by one
    sub-test (unimportant and auto-skipped if missing), albeit qtgui can
    use icon cache if *other* packages used this command which means it
    really belong in their IDEPEND (xdg.eclass does this for EAPI=8).
    
    Closes: https://bugs.gentoo.org/899546
    Signed-off-by: Ionen Wolkens <ionen@gentoo.org>

 dev-qt/qtbase/metadata.xml                         |   2 -
 ...{qtbase-6.5.2.ebuild => qtbase-6.5.2-r1.ebuild} | 225 +++++++++++----------
 dev-qt/qtbase/qtbase-6.5.9999.ebuild               | 225 +++++++++++----------
 dev-qt/qtbase/qtbase-6.9999.ebuild                 | 225 +++++++++++----------
 4 files changed, 366 insertions(+), 311 deletions(-)