Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 898940 - dev-libs/libgpg-error: Always downloads .sig even with USE=-verify-sig
Summary: dev-libs/libgpg-error: Always downloads .sig even with USE=-verify-sig
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo's Team for Core System packages
URL:
Whiteboard:
Keywords: PATCH
Depends on:
Blocks:
 
Reported: 2023-03-02 17:20 UTC by Allen Webb
Modified: 2023-04-01 17:18 UTC (History)
4 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Allen Webb 2023-03-02 17:20:01 UTC
dev-libs/libgpg-error 1.46-r1 always downloads the signature file even when USE=-verify-sig is set. This can lead to build issues if the .sig files are not mirrored.

This resolves the issue:
```
diff --git a/dev-libs/libgpg-error/libgpg-error-1.46-r1.ebuild b/dev-libs/libgpg-error/libgpg-error-1.46-r1.ebuild
index a8e2ea663..b69790d61 100644
--- a/dev-libs/libgpg-error/libgpg-error-1.46-r1.ebuild
+++ b/dev-libs/libgpg-error/libgpg-error-1.46-r1.ebuild
@@ -15,7 +15,7 @@ inherit autotools multilib-minimal toolchain-funcs prefix verify-sig
 DESCRIPTION="Contains error handling functions used by GnuPG software"
 HOMEPAGE="https://www.gnupg.org/related_software/libgpg-error"
 SRC_URI="mirror://gnupg/${PN}/${P}.tar.bz2"
-SRC_URI+=" mirror://gnupg/${PN}/${P}.tar.bz2.sig"
+SRC_URI+=" verify-sig? ( mirror://gnupg/${PN}/${P}.tar.bz2.sig )"
 
 LICENSE="GPL-2 LGPL-2.1"
 SLOT="0"
```


Reproducible: Always
Comment 1 Larry the Git Cow gentoo-dev 2023-04-01 17:18:51 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=62ebab453f2ffabce835a1f2fca92286bed20d1c

commit 62ebab453f2ffabce835a1f2fca92286bed20d1c
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2023-04-01 17:18:00 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2023-04-01 17:18:00 +0000

    dev-libs/libgpg-error: conditionally download sig for verify-sig
    
    Closes: https://bugs.gentoo.org/898940
    Thanks-to: Allen Webb <allenwebb@google.com>
    Signed-off-by: Sam James <sam@gentoo.org>

 dev-libs/libgpg-error/libgpg-error-1.46-r1.ebuild | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)