Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 898446 - app-editors/vim: bash (and therefore ebuild) syntax highlight broken in 9.0.1341
Summary: app-editors/vim: bash (and therefore ebuild) syntax highlight broken in 9.0.1341
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Oskari Pirhonen
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-02-28 15:11 UTC by Joonas Niilola
Modified: 2023-02-28 20:57 UTC (History)
5 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Joonas Niilola gentoo-dev 2023-02-28 15:11:49 UTC
Hey, 

after an update from 9.0.1157 to 9.0.1341 the ebuild syntax highlight seems broken. Everything else seems to be working, so it's probably not a vim issue. If it is, then we should package.mask the latest vim version stack. (vim, vim-core, gvim).
Comment 1 Larry the Git Cow gentoo-dev 2023-02-28 15:16:35 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=a1845d3da41dd018a1c5c4659c40b1ea8dcc6f79

commit a1845d3da41dd018a1c5c4659c40b1ea8dcc6f79
Author:     Joonas Niilola <juippis@gentoo.org>
AuthorDate: 2023-02-28 15:15:44 +0000
Commit:     Joonas Niilola <juippis@gentoo.org>
CommitDate: 2023-02-28 15:15:44 +0000

    profiles: mask the latest vim stack due to syntax highlight issues
    
    Bug: https://bugs.gentoo.org/898446
    Signed-off-by: Joonas Niilola <juippis@gentoo.org>

 profiles/package.mask | 7 +++++++
 1 file changed, 7 insertions(+)
Comment 2 Joonas Niilola gentoo-dev 2023-02-28 15:20:53 UTC
https://github.com/vim/vim/issues/11937
https://github.com/vim/vim/issues/11977

So a version bump should fix it.
Comment 3 Ben Kohler gentoo-dev 2023-02-28 15:42:13 UTC
FWIW I have locally bumped to 9.0.1363 and things seem to be working well.  I'd be happy to push the bump but I don't know if vim tends to be a rename-only bump or if there are often more changes needed.
Comment 4 Joonas Niilola gentoo-dev 2023-02-28 16:20:00 UTC
(In reply to Ben Kohler from comment #3)
> FWIW I have locally bumped to 9.0.1363 and things seem to be working well. 
> I'd be happy to push the bump but I don't know if vim tends to be a
> rename-only bump or if there are often more changes needed.

Please go ahead and bump. Not like much could've changed between these releases...

pkgdiff -b reports no changes between these versions.
  # pkgdiff-mg vim-9.0.1341.ebuild vim-9.0.1363.ebuild 

Please bump the whole stack, remove broken versions and clear package.mask? :)
Comment 5 Larry the Git Cow gentoo-dev 2023-02-28 16:28:47 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=6a12f9373bd13a69b9d7258027e7d030b7d876dd

commit 6a12f9373bd13a69b9d7258027e7d030b7d876dd
Author:     Ben Kohler <bkohler@gentoo.org>
AuthorDate: 2023-02-28 16:27:28 +0000
Commit:     Ben Kohler <bkohler@gentoo.org>
CommitDate: 2023-02-28 16:28:41 +0000

    profiles: broken vim versions removed, drop mask
    
    Closes: https://bugs.gentoo.org/898446
    
    Signed-off-by: Ben Kohler <bkohler@gentoo.org>

 profiles/package.mask | 7 -------
 1 file changed, 7 deletions(-)

Additionally, it has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=8c307cc4d3bab65ec72593fd2cab648d33e9c40e

commit 8c307cc4d3bab65ec72593fd2cab648d33e9c40e
Author:     Ben Kohler <bkohler@gentoo.org>
AuthorDate: 2023-02-28 16:25:23 +0000
Commit:     Ben Kohler <bkohler@gentoo.org>
CommitDate: 2023-02-28 16:28:39 +0000

    app-editors/vim: add 9.0.1363
    
    Bug: https://bugs.gentoo.org/898446
    
    Signed-off-by: Ben Kohler <bkohler@gentoo.org>

 app-editors/vim/Manifest            |   1 +
 app-editors/vim/vim-9.0.1363.ebuild | 374 ++++++++++++++++++++++++++++++++++++
 2 files changed, 375 insertions(+)