Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 897880 - =dev-libs/libgit2-1.6.1 installs as git2-experimental
Summary: =dev-libs/libgit2-1.6.1 installs as git2-experimental
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Michał Górny
URL: https://github.com/libgit2/libgit2/is...
Whiteboard:
Keywords: PMASKED
Depends on:
Blocks:
 
Reported: 2023-02-26 10:43 UTC by Alexander Maltsev
Modified: 2023-02-26 15:25 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Alexander Maltsev 2023-02-26 10:43:13 UTC
Reproducible: always

dev-libs/libgit2-1.6.1 ebuild sets build flag -DEXPERIMENTAL_SHA256=ON, which results in package being installed as libgit2-experimental instead of libgit2, e.g.

/usr/include/git2-experimental.h
/usr/lib64/libgit2-experimental.so.1.6.1
/usr/lib64/pkgconfig/git2-experimental.pc

and so on. As a result, other packages depending on libgit2 (e.g. libgit2-glib) can't find it as "pkg-config libgit2" fails.

Filename change is done by libgit2-1.6.1/cmake/ExperimentalFeatures.cmake if any experimental feature is enabled.
Comment 1 Ulrich Müller gentoo-dev 2023-02-26 10:48:20 UTC
For example, it break app-emacs/libegit2:

/tmp/portage/app-emacs/libegit2-0.0.20200515-r1/work/libegit2-0ef8b13aef011a98b7da756e4f1ce3bb18e4d55a/src/egit-annotated-commit.c:2:10: fatal error: git2.h: No such file or directory
    2 | #include "git2.h"
      |          ^~~~~~~~
compilation terminated.
Comment 2 Larry the Git Cow gentoo-dev 2023-02-26 10:54:27 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=fdb464c9310978a7a3a051d9ed53840f7b31de3a

commit fdb464c9310978a7a3a051d9ed53840f7b31de3a
Author:     Ulrich Müller <ulm@gentoo.org>
AuthorDate: 2023-02-26 10:52:57 +0000
Commit:     Ulrich Müller <ulm@gentoo.org>
CommitDate: 2023-02-26 10:54:16 +0000

    profiles: package.mask dev-libs/libgit2-1.6.1
    
    Bug: https://bugs.gentoo.org/897880
    Signed-off-by: Ulrich Müller <ulm@gentoo.org>

 profiles/package.mask | 5 +++++
 1 file changed, 5 insertions(+)
Comment 3 Ionen Wolkens gentoo-dev 2023-02-26 10:57:17 UTC
On my system, cargo-c failed to use it too -- still builds but that's because it fallsback to bundled libgit2 if it doesn't find it.
Comment 4 Ionen Wolkens gentoo-dev 2023-02-26 11:27:53 UTC
The experimental bit is a side effect of -DEXPERIMENTAL_SHA256=ON, but either way there is also https://github.com/libgit2/libgit2/issues/6507 (pkg-config file is misnamed differently) so should wait till 1.6.2 to unmask.
Comment 5 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2023-02-26 14:50:21 UTC
Sorry about that.  I'll update the ebuild now, so it's good for the next bump but wait for 1.6.2 instead of unmasking it right now.
Comment 6 Larry the Git Cow gentoo-dev 2023-02-26 15:25:17 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=ee92dab11ac1e407c8485a69a9dcabf722b15d91

commit ee92dab11ac1e407c8485a69a9dcabf722b15d91
Author:     Michał Górny <mgorny@gentoo.org>
AuthorDate: 2023-02-26 14:51:08 +0000
Commit:     Michał Górny <mgorny@gentoo.org>
CommitDate: 2023-02-26 15:25:09 +0000

    dev-libs/libgit2: Disable experimental SHA256 support
    
    Enabling experimental SHA256 support causes the library to be renamed
    which is not desired.  Disable it again.
    
    The release remains masked because of misnamed pkg-config file,
    1.6.2 is expected soon.
    
    Closes: https://bugs.gentoo.org/897880
    Signed-off-by: Michał Górny <mgorny@gentoo.org>

 dev-libs/libgit2/libgit2-1.6.1.ebuild | 1 -
 1 file changed, 1 deletion(-)