Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 897786 - java-pkg-simple.eclass: MANIFEST.MF receives upstream's "Created-By: " in case of using predefined MANIFEST.MF
Summary: java-pkg-simple.eclass: MANIFEST.MF receives upstream's "Created-By: " in cas...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Eclasses (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Java team
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks:
 
Reported: 2023-02-26 07:35 UTC by Volkmar W. Pogatzki
Modified: 2023-02-27 08:29 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Volkmar W. Pogatzki 2023-02-26 07:35:21 UTC 
Steps to reproduce:

1. emerge dev-java/xpp3-1.1.4c-r6
2. jar xvf /usr/share/xpp3/lib/xpp3.jar META-INF
3. cat META-INF/MANIFEST.MF
Manifest-Version: 1.0
Created-By: 1.5.0_13 (Sun Microsystems Inc.)
Comment 1 Larry the Git Cow gentoo-dev 2023-02-27 08:29:01 UTC 
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=f9921e9eb94a060287dbedb71012c729fe5750b7

commit f9921e9eb94a060287dbedb71012c729fe5750b7
Author:     Volkmar W. Pogatzki <gentoo@pogatzki.net>
AuthorDate: 2023-02-26 08:40:39 +0000
Commit:     Miroslav Šulc <fordfrog@gentoo.org>
CommitDate: 2023-02-27 08:28:55 +0000

    java-pkg-simple.eclass: MANIFEST.MF show Gentoo in "Created-By: "
    
    Presently, MANIFEST.MF can receive upstream's "Created-By:" if such line
    is found in a predefined META-INF/MANIFEST.MF in ${JAVA_RESOURCE_DIRS}.
    This change removes such line before the jar command creates the final
    MANIFEST.MF putting "Created-By: (Gentoo)"
    
    Closes: https://bugs.gentoo.org/897786
    Signed-off-by: Volkmar W. Pogatzki <gentoo@pogatzki.net>
    Closes: https://github.com/gentoo/gentoo/pull/29801
    Signed-off-by: Miroslav Šulc <fordfrog@gentoo.org>

 eclass/java-pkg-simple.eclass | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)