Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 897078 - net-analyzer/wireshark: needs upgrade to Python 3.11 (PythonCompatUpdate)
Summary: net-analyzer/wireshark: needs upgrade to Python 3.11 (PythonCompatUpdate)
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All All
: Normal normal
Assignee: Sam James
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 896398
  Show dependency tree
 
Reported: 2023-02-25 09:48 UTC by Michał Górny
Modified: 2023-05-25 06:44 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2023-02-25 09:48:35 UTC
This package does not support Python 3.11.  Please test it with Python 3.11 as a matter of urgency as the default will change in early June, as per message on gentoo-dev: https://archives.gentoo.org/gentoo-dev/message/abb5788ea81c7bbf4d40a2995b682eb9.  Please check the information provided in the tracker.  Ask in #gentoo-python on IRC if need any help.
Comment 1 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2023-03-04 06:58:40 UTC
3.x unfortunately fails tests with Python 3.11, while 4.x doesn't. 4.x is stable now (and has been for a while) so I'm not that worried about this and will just cleanup 3.x in due course.

(There's no real reason for anyone to be using 3.x, it's just the LTS release. I plan on dropping it soon enough.)
Comment 2 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2023-03-04 07:18:18 UTC
No, I was completely wrong - I misremembered, apparently.
Comment 3 Klaus Kusche 2023-04-20 07:40:07 UTC
The issue https://gitlab.com/wireshark/wireshark/-/issues/18740 only affects wireshark tests.

Will a wireshark build with USE=-test succeed with python 3.11?

If so, can the wireshark ebuild be modified to accept python 3.11 when building with USE=-test?
Comment 4 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2023-04-20 10:34:14 UTC
(In reply to Klaus Kusche from comment #3)
> The issue https://gitlab.com/wireshark/wireshark/-/issues/18740 only affects
> wireshark tests.
> 
> Will a wireshark build with USE=-test succeed with python 3.11?
> 
> If so, can the wireshark ebuild be modified to accept python 3.11 when
> building with USE=-test?

Not really, unfortunately, but what I'm likely to do is, with reluctance, is use unittest to run the test suite, not pytest. But it'll make them much slower and it means I have to patch out things to skip them, I think. :(
Comment 5 Larry the Git Cow gentoo-dev 2023-05-01 08:00:53 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=ba8d3ccfbcb2693d480c960c864545f358ac6be7

commit ba8d3ccfbcb2693d480c960c864545f358ac6be7
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2023-05-01 07:59:34 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2023-05-01 08:00:42 +0000

    net-analyzer/wireshark: enable py3.11, restrict tests temporarily
    
    We need to restrict tests for now because Wireshark w/ py3.11 uses pytest
    internals that got removed. Unfortunately, when running tests w/ unittest,
    some tests end up failing (and it's not easy to skip them), and it's much
    slower.
    
    Closes: https://bugs.gentoo.org/897078
    Signed-off-by: Sam James <sam@gentoo.org>

 net-analyzer/wireshark/wireshark-3.6.12-r1.ebuild | 6 ++++--
 net-analyzer/wireshark/wireshark-3.6.13.ebuild    | 6 ++++--
 net-analyzer/wireshark/wireshark-4.0.4-r1.ebuild  | 6 ++++--
 net-analyzer/wireshark/wireshark-4.0.5.ebuild     | 6 ++++--
 net-analyzer/wireshark/wireshark-9999.ebuild      | 6 ++++--
 5 files changed, 20 insertions(+), 10 deletions(-)
Comment 6 Larry the Git Cow gentoo-dev 2023-05-25 06:44:08 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=c542ffc3e5039307ede5f9f150c34e94c23c17e1

commit c542ffc3e5039307ede5f9f150c34e94c23c17e1
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2023-05-25 06:40:44 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2023-05-25 06:43:23 +0000

    net-analyzer/wireshark: re-enable tests for live
    
    Upstream now hard-require pytest in master (good!)
    
    Bug: https://bugs.gentoo.org/897078
    Signed-off-by: Sam James <sam@gentoo.org>

 net-analyzer/wireshark/wireshark-9999.ebuild | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)