Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 896256 - media-sound/audacious: version bump to 4.3-beta1
Summary: media-sound/audacious: version bump to 4.3-beta1
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Sound Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-02-24 13:33 UTC by Maciej S. Szmigiero
Modified: 2023-04-07 09:30 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Maciej S. Szmigiero 2023-02-24 13:33:02 UTC
Audacious 4.3-beta1 has been released [1].

Please also restore ability to build the GTK UI, now that Audacious supports GTK3 once again, since the Qt one in classic mode is still missing important features like "jump to track" [2].

[1]: https://audacious-media-player.org/news/55-audacious-4-3-beta1-released
[2]: https://www.redmine.audacious-media-player.org/issues/978
Comment 1 Andreas Sturmlechner gentoo-dev 2023-02-24 15:21:33 UTC
Supporting both toolkits in the same ebuild would be a complete and utter mess.

You would be asking for an entirely different package e.g. called "audacious-gtk3".
Comment 2 Maciej S. Szmigiero 2023-02-24 15:31:18 UTC
> Supporting both toolkits in the same ebuild would be a complete and utter mess.

AFAIK both Qt and GTK can be enabled in a single Audacious meson build so you don't have to run the build twice for that.

There are multiple packages that allow building multiple toolkits at the same time, quick search uncovers at least:
app-crypt/pinentry
media-gfx/zbar
sci-visualization/gnuplot
Comment 3 Andreas Sturmlechner gentoo-dev 2023-02-24 16:17:15 UTC
Let's keep this about audacious please.

So far, different toolkits were released in different tarballs, and Gentoo has been using autotools buildsystem up until and including the current stable release. I don't know if that changed with meson, as I do not maintain it anymore.

Qt5 and GTK3 in audacious - so far - also have had cascading implications on IUSE validity, causing complicated and frustrating REQUIRED_USE constructs.
Comment 4 Maciej S. Szmigiero 2023-02-24 16:34:10 UTC
> So far, different toolkits were released in different tarballs
It's a single tarball at [1].

> and Gentoo has been using autotools buildsystem up until and including the current stable release. 
Autotools version also allows building both Qt and GTK GUIs at the same time [2].

> Qt5 and GTK3 in audacious - so far - also have had cascading implications on IUSE validity, causing complicated and frustrating REQUIRED_USE constructs.
Since these flags are independent now (and both can be off to build a headless player) a REQUIRED_USE construct shouldn't be necessary at all.

Personally, I would be satisfied with having just "gtk" or "gtk3" USE flag to optionally build the GTK UI, with the Qt one being enabled unconditionally (as it is now).


[1]: https://distfiles.audacious-media-player.org/audacious-4.3-beta1.tar.bz2

[2]: https://github.com/audacious-media-player/audacious/blob/595f77f6d34afdaefe44576672802a6359561c8a/configure.ac#L152
https://github.com/audacious-media-player/audacious/blob/595f77f6d34afdaefe44576672802a6359561c8a/acinclude.m4#L184
Comment 5 Enne Eziarc 2023-02-24 19:44:58 UTC
(In reply to Andreas Sturmlechner from comment #1)
> Supporting both toolkits in the same ebuild would be a complete and utter
> mess.
> 
> You would be asking for an entirely different package e.g. called
> "audacious-gtk3".

(In reply to Andreas Sturmlechner from comment #3)
> Let's keep this about audacious please.
> 
> So far, different toolkits were released in different tarballs, and Gentoo
> has been using autotools buildsystem up until and including the current
> stable release. I don't know if that changed with meson, as I do not
> maintain it anymore.
> 
> Qt5 and GTK3 in audacious - so far - also have had cascading implications on
> IUSE validity, causing complicated and frustrating REQUIRED_USE constructs.

Choosing the frontend is done with a CLI flag, they are both part of the same tarball, and adding gtk3 to the ebuild is a straightforward ~25 line patch.
Comment 6 Larry the Git Cow gentoo-dev 2023-04-07 08:12:23 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=6486b501e6934eec041390b1c8e5359ad80f7463

commit 6486b501e6934eec041390b1c8e5359ad80f7463
Author:     dakrk <dark@darkok.xyz>
AuthorDate: 2023-04-05 15:34:42 +0000
Commit:     Miroslav Šulc <fordfrog@gentoo.org>
CommitDate: 2023-04-07 08:09:42 +0000

    media-sound/audacious: bump to 4.3
    
    Closes: https://bugs.gentoo.org/896256
    Signed-off-by: Joseph Matthews <dark@darkok.xyz>
    Signed-off-by: Miroslav Šulc <fordfrog@gentoo.org>

 media-sound/audacious/Manifest             |  1 +
 media-sound/audacious/audacious-4.3.ebuild | 67 ++++++++++++++++++++++++++++++
 2 files changed, 68 insertions(+)
Comment 7 Maciej S. Szmigiero 2023-04-07 09:30:36 UTC
Since the above version bump seems to *not* restore ability to build the GTK UI (despite requests to do so in this bug) I have create bug #903970 about that.