Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 895946 - sys-libs/fts-standalone: rename to sys-libs/musl-standalone and/or stop renaming .pc file?
Summary: sys-libs/fts-standalone: rename to sys-libs/musl-standalone and/or stop renam...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Anthony Basile
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-02-22 22:18 UTC by Sam James
Modified: 2024-07-02 00:10 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Sam James archtester Gentoo Infrastructure gentoo-dev Security 2023-02-22 22:18:04 UTC
Right now, we have:
```
src_install() {

        default
        find "${ED}" -name '*.la' -delete || die
        mv "${ED}"/usr/$(get_libdir)/pkgconfig/{musl-fts,fts-standalone}.pc || die
}
```

This looks a bit suspicious to me. My attention was recently drawn to https://github.com/theimpossibleastronaut/rmw/pull/385/files#diff-bcc0bb780c91d9a76bbcca08d6b03b54729ded44ea3cdf39b9cfda45c5d0f2feR1 and I suspect this wouldn't be able to detect our sys-libs/fts-standalone because we're renaming the .pc file...?
Comment 1 noneofyourbusiness 2023-12-25 22:27:58 UTC
I'd call it musl-fts (as the repo is called upstream), and name the pc file the same as upstream.

This is consistent with one example, void linux, where musl-fts-devel ships musl-fts.pc
Comment 2 Ross Burton 2024-07-01 10:57:50 UTC
With the caveat that I'm not a gentoo developer or user, I do agree with renaming this to musl-fts.

It's the name of the upstream project and .pc file. It's also the name that Void, Alpine, and OpenEmbedded use.

I discovered this divergence because I'm trying to build libabigail on musl and it looks for fts-standalone, which appears to be specific to gentoo.
Comment 3 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2024-07-01 11:16:34 UTC
(In reply to Ross Burton from comment #2)

Thanks, let me ask around. AFAICT, the only real fallout is broken checks, so maybe we should install a symlink for the old ("our") name.
Comment 4 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2024-07-01 11:17:00 UTC
(That said, it's potentially annoying for any other libcs where there's a missing fts, but it is what it is, it's not up to us to make up a fts-standalone name even if it feels more pure.)
Comment 5 Larry the Git Cow gentoo-dev 2024-07-02 00:03:45 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=a403fe6c61d1aaeecd58d521f3def2f6d3513449

commit a403fe6c61d1aaeecd58d521f3def2f6d3513449
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2024-07-02 00:01:13 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2024-07-02 00:03:12 +0000

    sys-libs/fts-standalone: stop renaming .pc file
    
    Stop renaming musl-fts.pc -> fts-standalone.pc. While it might be more
    pure as a name (as it might be useful on other libcs), it's not within our
    gift to rename this and it has ecosystem-wide effects.
    
    Other distributions are using the upstream name.
    
    Also, install a symlink for the old fts-standalone name to keep broken
    checks working.
    
    While here, fix MisplacedWeakBlocker too.
    
    Closes: https://bugs.gentoo.org/895946
    Signed-off-by: Sam James <sam@gentoo.org>

 .../fts-standalone/fts-standalone-1.2.7-r1.ebuild  | 39 ++++++++++++++++++++++
 1 file changed, 39 insertions(+)
Comment 6 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2024-07-02 00:10:42 UTC
Thanks for the nudge, Ross. Apologies for the hassle!