Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 895944 - mail-filter/opendkim-2.10.3-r29: has unnecessary dependency on ldns
Summary: mail-filter/opendkim-2.10.3-r29: has unnecessary dependency on ldns
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Francisco Blas Izquierdo Riera (RETIRED)
URL:
Whiteboard:
Keywords: PATCH
Depends on:
Blocks:
 
Reported: 2023-02-22 22:15 UTC by Gil Kloepfer
Modified: 2023-02-23 01:03 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
patch to correct dependency, ebuild -r29 to -r30 (opendkim-ebuild-ldns-dependency.patch,709 bytes, patch)
2023-02-22 22:19 UTC, Gil Kloepfer
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Gil Kloepfer 2023-02-22 22:15:18 UTC
When attempting to install opendkim without unbound enabled, ldns is pulled-in as a dependency.  The README from upstream (http://opendkim.org/INSTALL) clearly says that ldns is "required for unbound" - it does not appear to be needed when unbound is disabled.  However, the ebuild appears to require ldns only when the unbound use flag is NOT selected.

Will attach recommended patch (r30), however please note that I have not tested compiling this with unbound enabled.

Reproducible: Always

Steps to Reproduce:
1.  Do not enable the unbound use flag for opendkim, ldns not installed
2.  emerge --pretend opendkim
3.  Notice dependency on ldns
Actual Results:  
# emerge --pretend =mail-filter/opendkim-2.10.3-r29

These are the packages that would be merged, in order:

Calculating dependencies... done!
[ebuild  N     ] acct-group/opendkim-0-r1 
[ebuild  N     ] net-libs/ldns-1.8.0-r4  USE="dane ecdsa -doc -ed448 -ed25519 -examples -gost -python -static-libs -vim-syntax" ABI_X86="(64) -32 (-x32)" PYTHON_SINGLE_TARGET="python3_10 -python3_9" 
[ebuild  N     ] acct-user/opendkim-0-r1 
[ebuild  N     ] mail-filter/opendkim-2.10.3-r29  USE="ssl -berkdb -ldap -lmdb -lua -memcached -opendbx -poll -querycache -sasl (-selinux) -static-libs -stats -test -unbound" LUA_SINGLE_TARGET="lua5-1" 


Expected Results:  
(Same as actual results without dependency on ldns)
# emerge --pretend =mail-filter/opendkim-2.10.3-r30

These are the packages that would be merged, in order:

Calculating dependencies... done!
[ebuild  N     ] acct-group/opendkim-0-r1 
[ebuild  N     ] acct-user/opendkim-0-r1 
[ebuild  N     ] mail-filter/opendkim-2.10.3-r30  USE="ssl -berkdb -ldap -lmdb -lua -memcached -opendbx -poll -querycache -sasl (-selinux) -static-libs -stats -test -unbound" LUA_SINGLE_TARGET="lua5-1" 



# emerge --info
Portage 3.0.43 (python 3.10.9-final-0, default/linux/amd64/17.1, gcc-12, glibc-2.36-r5, 6.0.2-x86_64-linode157 x86_64)
=================================================================
System uname: Linux-6.0.2-x86_64-linode157-x86_64-AMD_EPYC_7601_32-Core_Processor-with-glibc2.36
KiB Mem:     4000584 total,   2281644 free
KiB Swap:    1048572 total,   1048572 free
Timestamp of repository gentoo: Wed, 01 Feb 2023 21:15:01 +0000
Head commit of repository gentoo: 505019f147a4547e25839592d10a20e43087112c
Timestamp of repository kloepfer: Sun, 08 Jan 2023 22:23:37 +0000
sh bash 5.1_p16-r2
ld GNU ld (Gentoo 2.39 p5) 2.39.0
app-misc/pax-utils:        1.3.5::gentoo
app-shells/bash:           5.1_p16-r2::gentoo
dev-lang/perl:             5.36.0-r1::gentoo
dev-lang/python:           3.10.9-r1::gentoo, 3.11.1-r1::gentoo
dev-util/cmake:            3.24.3::gentoo
dev-util/meson:            0.64.1::gentoo
sys-apps/baselayout:       2.9::gentoo
sys-apps/openrc:           0.45.2-r2::gentoo
sys-apps/sandbox:          2.29::gentoo
sys-devel/autoconf:        2.71-r5::gentoo
sys-devel/automake:        1.16.5::gentoo
sys-devel/binutils:        2.39-r4::gentoo
sys-devel/binutils-config: 5.4.1::gentoo
sys-devel/gcc:             12.2.1_p20230121-r1::gentoo
sys-devel/gcc-config:      2.8::gentoo
sys-devel/libtool:         2.4.7-r1::gentoo
sys-devel/make:            4.3::gentoo
sys-kernel/linux-headers:  5.15-r3::gentoo (virtual/os-headers)
sys-libs/glibc:            2.36-r5::gentoo
Repositories:

gentoo
    location: /sysbuild/portage
    sync-type: rsync
    sync-uri: rsync://rsync.namerica.gentoo.org/gentoo-portage
    priority: -1000
    volatile: True
    sync-rsync-extra-opts: 
    sync-rsync-verify-max-age: 24
    sync-rsync-verify-metamanifest: yes
    sync-rsync-verify-jobs: 1

kloepfer
    location: /sysbuild/kloepfer-overlay
    sync-type: rsync
    sync-uri: rsync://limbic/kloepfer-overlay
    masters: gentoo
    volatile: True
    sync-rsync-extra-opts: 

ACCEPT_KEYWORDS="amd64"
ACCEPT_LICENSE="*"
CBUILD="x86_64-pc-linux-gnu"
CFLAGS="-O2 -march=nocona -pipe -fomit-frame-pointer -fno-ident -mno-tls-direct-seg-refs"
CHOST="x86_64-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/share/gnupg/qualified.txt /var/bind"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/env.d /etc/gconf /etc/gentoo-release /etc/init.d /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo"
CXXFLAGS="-O2 -march=nocona -pipe -fomit-frame-pointer -fno-ident -mno-tls-direct-seg-refs"
DISTDIR="/sysbuild/distfiles"
EMERGE_DEFAULT_OPTS="--jobs=3 --load-average=3"
ENV_UNSET="CARGO_HOME DBUS_SESSION_BUS_ADDRESS DISPLAY GDK_PIXBUF_MODULE_FILE GOBIN GOPATH PERL5LIB PERL5OPT PERLPREFIX PERL_CORE PERL_MB_OPT PERL_MM_OPT XAUTHORITY XDG_CACHE_HOME XDG_CONFIG_HOME XDG_DATA_HOME XDG_RUNTIME_DIR XDG_STATE_HOME"
FCFLAGS="-O2 -pipe"
FEATURES="assume-digests binpkg-docompress binpkg-dostrip binpkg-logs buildpkg-live config-protect-if-modified distlocks ebuild-locks fixlafiles ipc-sandbox merge-sync multilib-strict network-sandbox news parallel-fetch pid-sandbox preserve-libs protect-owned qa-unresolved-soname-deps sandbox sfperms strict unknown-features-warn unmerge-logs unmerge-orphans userfetch userpriv usersandbox usersync xattr"
FFLAGS="-O2 -pipe"
GENTOO_MIRRORS="http://distfiles.gentoo.org"
LANG="C"
LDFLAGS="-Wl,-O1 -Wl,--as-needed"
LEX="flex"
MAKEOPTS="-j3"
PKGDIR="/sysbuild/packages"
PORTAGE_CONFIGROOT="/"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --omit-dir-times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages --exclude=/.git"
PORTAGE_TMPDIR="/var/tmp"
SHELL="/bin/bash"
USE="acl amd64 bzip2 cli crypt dri gdbm iconv ipv6 libglvnd libtirpc multilib ncurses nls nptl openmp pam pcre readline seccomp split-usr sqlite ssl test-rust unicode xattr zlib" ABI_X86="64" ADA_TARGET="gnat_2021" APACHE2_MODULES="authn_core authz_core socache_shmcb unixd actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" APACHE2_MPMS="prefork" CALLIGRA_FEATURES="karbon sheets words" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" CPU_FLAGS_X86="aes avx avx2 f16c fma3 mmx mmxext pclmul popcnt rdrand sha sse sse2 sse3 sse4_1 sse4_2 sse4a ssse3" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock greis isync itrax mtk3301 nmea ntrip navcom oceanserver oldstyle oncore rtcm104v2 rtcm104v3 sirf skytraq superstar2 timing tsip tripmate tnt ublox ubx" INPUT_DEVICES="libinput" KERNEL="linux" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LIBREOFFICE_EXTENSIONS="presenter-console presenter-minimizer" LUA_SINGLE_TARGET="lua5-1" LUA_TARGETS="lua5-1" OFFICE_IMPLEMENTATION="libreoffice" PHP_TARGETS="php7-4 php8-0" POSTGRES_TARGETS="postgres12 postgres13" PYTHON_SINGLE_TARGET="python3_10" PYTHON_TARGETS="python3_10" RUBY_TARGETS="ruby27 ruby30" USERLAND="GNU" VIDEO_CARDS="amdgpu fbdev intel nouveau radeon radeonsi vesa dummy v4l" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq proto steal rawnat logmark ipmark dhcpmac delude chaos account"
Unset:  ADDR2LINE, AR, ARFLAGS, AS, ASFLAGS, CC, CCLD, CONFIG_SHELL, CPP, CPPFLAGS, CTARGET, CXX, CXXFILT, ELFEDIT, EXTRA_ECONF, F77FLAGS, FC, GCOV, GPROF, INSTALL_MASK, LC_ALL, LD, LFLAGS, LIBTOOL, LINGUAS, MAKE, MAKEFLAGS, NM, OBJCOPY, OBJDUMP, PORTAGE_BINHOST, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS, RANLIB, READELF, RUSTFLAGS, SIZE, STRINGS, STRIP, YACC, YFLAGS
Comment 1 Gil Kloepfer 2023-02-22 22:19:45 UTC
Created attachment 854024 [details, diff]
patch to correct dependency, ebuild -r29 to -r30

Proposed patch to bring ebuild from -r29 to -r30 which appears to resolve the issue described in the bug report, as well as maintain the proper functionality for the unbound use flag.
Comment 2 Michael Orlitzky gentoo-dev 2023-02-23 00:42:20 UTC
Nice catch. I find it extremely unlikely that --with-ldns does anything at all. Unbound itself hasn't used ldns in a decade.

I'll run some tests and drop the flag/dependency if they pass.
Comment 3 Larry the Git Cow gentoo-dev 2023-02-23 01:03:14 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=770d624809c1f462eb5c6c8feb2f818a75e4900b

commit 770d624809c1f462eb5c6c8feb2f818a75e4900b
Author:     Michael Orlitzky <mjo@gentoo.org>
AuthorDate: 2023-02-23 00:56:19 +0000
Commit:     Michael Orlitzky <mjo@gentoo.org>
CommitDate: 2023-02-23 01:02:14 +0000

    mail-filter/opendkim: new revision to drop the net-libs/ldns dependency.
    
    This just... doesn't do anything. And the logic was backwards this whole
    time, so I'm extra sure that it doesn't do anything.
    
    Thanks to Gil Kloepfer for noticing it!
    
    Closes: https://bugs.gentoo.org/895944
    Signed-off-by: Michael Orlitzky <mjo@gentoo.org>

 mail-filter/opendkim/opendkim-2.10.3-r30.ebuild | 249 ++++++++++++++++++++++++
 1 file changed, 249 insertions(+)