Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 895870 - www-client/librewolf-109.0.1_p2[system-libevent] depends on dev-libs/libevent[threads] but threads flag was removed
Summary: www-client/librewolf-109.0.1_p2[system-libevent] depends on dev-libs/libevent...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Overlays (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Gentoo Linux bug wranglers
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-02-22 13:54 UTC by Joe Breuer
Modified: 2023-02-24 09:00 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Joe Breuer 2023-02-22 13:54:17 UTC
Bug #894270 identically affects current www-client/librewolf-109.0.1_p2 (which is a firefox fork). Presumably all other librewolf versions in the tree as well.

I've had a look at the commits referenced in that bug, I cannot figure out what change would have fixed this for firefox. 

I'm happy to try things out locally and submit patches.

What would be considered the 'correct' way to fix this in the ebuild? Just drop the [threads(+)] USE flag requirement? Formulate a (pseuodocode follows) "libevent-old[threads(+)] OR libevent-newenough" dependency? Something else entirely?
Comment 1 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2023-02-22 14:01:11 UTC
It's now gone in libevent because it's always on => threads(+) in the dependency.

Fixed in firefox for...
```
commit 7b2c4f8d2864279021fe44bf822d891e20bf4e35
Author: Mike Gilbert <floppym@gentoo.org>
Date:   Mon Feb 13 15:13:10 2023 -0500

    www-client/firefox: adjust libevent dependency

    Bug: https://bugs.gentoo.org/869722
    Signed-off-by: Mike Gilbert <floppym@gentoo.org>

diff --git a/www-client/firefox/firefox-102.7.0.ebuild b/www-client/firefox/firefox-102.7.0.ebuild
index 637c41fc7fe7a..5e995f7b919a6 100644
--- a/www-client/firefox/firefox-102.7.0.ebuild
+++ b/www-client/firefox/firefox-102.7.0.ebuild
@@ -164,7 +164,7 @@ COMMON_DEPEND="${FF_ONLY_DEPEND}
        )
        system-icu? ( >=dev-libs/icu-71.1:= )
        system-jpeg? ( >=media-libs/libjpeg-turbo-1.2.1 )
-       system-libevent? ( >=dev-libs/libevent-2.1.12:0=[threads] )
+       system-libevent? ( >=dev-libs/libevent-2.1.12:0=[threads(+)] )
        system-libvpx? ( >=media-libs/libvpx-1.8.2:0=[postproc] )
        system-png? ( >=media-libs/libpng-1.6.35:0=[apng] )
        system-webp? ( >=media-libs/libwebp-1.1.0:0= )
diff --git a/www-client/firefox/firefox-109.0.1.ebuild b/www-client/firefox/firefox-109.0.1.ebuild
index 8a57456afd7fe..4c2e376c70456 100644
--- a/www-client/firefox/firefox-109.0.1.ebuild
+++ b/www-client/firefox/firefox-109.0.1.ebuild
@@ -172,7 +172,7 @@ COMMON_DEPEND="${FF_ONLY_DEPEND}
        )
        system-icu? ( >=dev-libs/icu-71.1:= )
        system-jpeg? ( >=media-libs/libjpeg-turbo-1.2.1 )
-       system-libevent? ( >=dev-libs/libevent-2.1.12:0=[threads] )
+       system-libevent? ( >=dev-libs/libevent-2.1.12:0=[threads(+)] )
        system-libvpx? ( >=media-libs/libvpx-1.8.2:0=[postproc] )
        system-png? ( >=media-libs/libpng-1.6.35:0=[apng] )
        system-webp? ( >=media-libs/libwebp-1.1.0:0= )
```

I don't know what overlay librewolf is in, please specify.
Comment 2 Joe Breuer 2023-02-22 14:08:57 UTC
Ah sorry, completely slipped my mind that they maintain their own overlay. I'll bump the issue over there.

Thanks a lot for the concise diff!
Comment 3 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2023-02-22 14:10:32 UTC
no problem :)
Comment 4 Joe Breuer 2023-02-24 09:00:51 UTC
My own investigations had crossed over the appropriate fix already being applied in the librewolf repo. I can confirm that with a current sync of that repo, the issue is fixed (at least in versions 109.0.1_p2-r1 and 110.0_p2).