Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 895790 - GLEP 68: Allow EAPI 5 dependency specifications in restrict attribute
Summary: GLEP 68: Allow EAPI 5 dependency specifications in restrict attribute
Status: RESOLVED FIXED
Alias: None
Product: Documentation
Classification: Unclassified
Component: GLEP Changes (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: GLEP Editors
URL:
Whiteboard:
Keywords: PATCH
Depends on:
Blocks:
 
Reported: 2023-02-22 07:35 UTC by Ulrich Müller
Modified: 2023-03-12 20:10 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
glep-0068: Allow EAPI 5 dependency specifications (0001-glep-0068-Allow-EAPI-5-dependency-specifications.patch,2.65 KB, patch)
2023-02-22 07:35 UTC, Ulrich Müller
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ulrich Müller gentoo-dev 2023-02-22 07:35:00 UTC
Created attachment 853732 [details, diff]
glep-0068: Allow EAPI 5 dependency specifications

As discussed in #gentoo-council on 2023-01-22:

<@ulm> mgorny: anyway, why I have looked at GLEP 68, in the first place: I wonder if we could allow EAPI 5 dependency specification in the restrict attribute? slots, in particular
<@mgorny> i don't see why not
[...]
<@ulm> mgorny: how about this? https://dpaste.com/D999F5YSZ
<@ulm> or rather, https://dpaste.com/APW3MHJC4 (with version increased)
<@ulm> gah, also slot should be the same in lines 42 and 48. corrected locally
<@mgorny> LGTM
<@mgorny> no clue if anything actually parses restrict="" though
<+Arsen> iirc equery did
<@ulm> hm, and does it support EAPI 5?
<@ulm> Arsen: looks like it simply displays the restriction, and it does so only for the maintainer
<+Arsen> hm, yeah, that sounds about right

Please review attached patch.
Comment 1 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2023-02-22 14:34:45 UTC
LGTM.  Perhaps it'd make sense to have a "Changes" section but I don't want to force you to look through history for previous changes to fill it in.
Comment 2 Larry the Git Cow gentoo-dev 2023-03-12 20:10:16 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/data/glep.git/commit/?id=d9ee35e0bd53b28e7cc1ffd6f2c4e4f1ad028b0a

commit d9ee35e0bd53b28e7cc1ffd6f2c4e4f1ad028b0a
Author:     Ulrich Müller <ulm@gentoo.org>
AuthorDate: 2023-02-22 07:23:19 +0000
Commit:     Ulrich Müller <ulm@gentoo.org>
CommitDate: 2023-02-22 15:59:52 +0000

    glep-0068: Allow EAPI 5 dependency specifications
    
    This applies to the "restrict" attribute which is used with the
    "maintainer", "longdescription", "flag", and "stabilize-allarches"
    elements.
    
    Closes: https://bugs.gentoo.org/895790
    Reviewed-by: Michał Górny <mgorny@gentoo.org>
    Signed-off-by: Ulrich Müller <ulm@gentoo.org>

 glep-0068.rst | 16 +++++++++++-----
 1 file changed, 11 insertions(+), 5 deletions(-)