Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 895314 - app-portage/gs-elpa fails with dev-python/sexpdata-0.0.4 (PATCH)
Summary: app-portage/gs-elpa fails with dev-python/sexpdata-0.0.4 (PATCH)
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Layman Overlay Manager project
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-02-18 20:26 UTC by Markus Walter
Modified: 2023-05-20 09:23 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
patch to adjust gs-elpa to new sexpdata (0001-Adjust-to-sexpdata-version-0.0.4.patch,1.66 KB, patch)
2023-02-18 20:26 UTC, Markus Walter
Details | Diff
patch to adjust gs-elpa to new sexpdata v2 (0001-Adjust-to-sexpdata-version-0.0.4.patch,1.85 KB, patch)
2023-02-19 10:56 UTC, Markus Walter
Details | Diff
Standard error from "eix-update" (err,1.81 KB, text/plain)
2023-02-24 17:00 UTC, Rainer W
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Markus Walter 2023-02-18 20:26:19 UTC
Created attachment 852772 [details, diff]
patch to adjust gs-elpa to new sexpdata

There was a significant API change in sexpdata from version 0.0.3 to 0.0.4. The attached patch adjusts gs-elpa (sadly in a backwards-incompatible way).
Comment 1 Ulrich Müller gentoo-dev 2023-02-19 09:42:29 UTC
gs-elpa $ curl -sL 'https://895314.bugs.gentoo.org/attachment.cgi?id=852772' | git am -sS
Applying: Adjust to sexpdata version 0.0.4.
warning: gs_elpa/elpa_db.py has type 100644, expected 100755
error: patch failed: gs_elpa/elpa_db.py:83
error: gs_elpa/elpa_db.py: patch does not apply
Patch failed at 0001 Adjust to sexpdata version 0.0.4.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
Comment 2 Markus Walter 2023-02-19 10:56:16 UTC
Created attachment 852822 [details, diff]
patch to adjust gs-elpa to new sexpdata v2

Ah sorry, I've some minor personal patches (here: [1]) which caused a conflict. I rebased it and it should now apply cleanly.


[1] https://github.com/houseofsuns/gs-elpa
Comment 3 Larry the Git Cow gentoo-dev 2023-02-19 14:58:33 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=af65eb423ba9a623181729a22e32217cdc6162ef

commit af65eb423ba9a623181729a22e32217cdc6162ef
Author:     Ulrich Müller <ulm@gentoo.org>
AuthorDate: 2023-02-19 14:57:41 +0000
Commit:     Ulrich Müller <ulm@gentoo.org>
CommitDate: 2023-02-19 14:58:21 +0000

    app-portage/gs-elpa: add 0.2.2
    
    Closes: https://bugs.gentoo.org/895314
    Signed-off-by: Ulrich Müller <ulm@gentoo.org>

 app-portage/gs-elpa/Manifest             |  1 +
 app-portage/gs-elpa/gs-elpa-0.2.2.ebuild | 27 +++++++++++++++++++++++++++
 2 files changed, 28 insertions(+)

Additionally, it has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=91e0eda05d7671038c7951672acf418abeec0e08

commit 91e0eda05d7671038c7951672acf418abeec0e08
Author:     Ulrich Müller <ulm@gentoo.org>
AuthorDate: 2023-02-19 14:56:54 +0000
Commit:     Ulrich Müller <ulm@gentoo.org>
CommitDate: 2023-02-19 14:58:21 +0000

    app-portage/gs-elpa: Depend on <sexpdata-0.0.4
    
    Bug: https://bugs.gentoo.org/895314
    Signed-off-by: Ulrich Müller <ulm@gentoo.org>

 app-portage/gs-elpa/gs-elpa-0.2.1-r1.ebuild | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Comment 4 Ulrich Müller gentoo-dev 2023-02-24 09:02:34 UTC
Reopening. gs-elpa-0.2.2 with sexpdata-0.0.4 (and g-sorcery-0.2.2-r1) doesn't see any repositories:

$ layman -L | grep elpa
$ 

With gs-elpa-0.2.1-r1 and sexpdata-0.0.3-r2 I get the expected behaviour:

$ layman -L | grep elpa
 * gnu-elpa                  [g-sorcery ] (gs-elpa gnu-elpa                    )
 * marmalade                 [g-sorcery ] (gs-elpa marmalade                   )
 * melpa                     [g-sorcery ] (gs-elpa melpa                       )
 * melpa-stable              [g-sorcery ] (gs-elpa melpa-stable                )
$
Comment 5 Ulrich Müller gentoo-dev 2023-02-24 10:00:56 UTC
(In reply to Ulrich Müller from comment #4)
> Reopening. gs-elpa-0.2.2 with sexpdata-0.0.4 (and g-sorcery-0.2.2-r1)
> doesn't see any repositories:
> 
> $ layman -L | grep elpa
> $ 

Should be fixed in 0.2.2-r1.
Comment 6 Rainer W 2023-02-24 17:00:06 UTC
Created attachment 854400 [details]
Standard error from "eix-update"
Comment 7 Rainer W 2023-02-24 17:07:28 UTC
Comment on attachment 854400 [details]
Standard error from "eix-update"

Sorry to rain on the party:

After upgrading to "=app-portage/gs-elpa-0.2.2-r1" "layman" did again find the four "*elpa" overlays, but running "eix-update" started spitting an apparently endless stream of error messages (probably one for each package found in the "*elpa* overlays), one of which I attached.
Comment 8 Ulrich Müller gentoo-dev 2023-02-24 18:22:32 UTC
(In reply to Rainer W from comment #7)

This should be fixed in g-sorcery-0.2.3. Sorry for the hassle.
Comment 9 Ulrich Müller gentoo-dev 2023-02-25 09:01:42 UTC
From #gentoo-python:

<+ulm> I was trying to update app-portage/gs-elpa in order to avoid a warning about "PEP517" (whatever that is) from distutils-r1
<+ulm> naively setting DISTUTILS_USE_PEP517=setuptools doesn't work though, e.g. files that should be installed in /etc end up in /usr/lib/python3.10/site-packages
<+ulm> any hints?
[...]
<@mgorny> ulm: mv. Brilliant minds in python world don't consider any directory outside site-packages really significant
<@mgorny> ulm: /usr works by the miracle of legacy
<+ulm> mgorny: I am a little confused, DISTUTILS_USE_PEP517 doc seems to indicate that its value should be "setuptools" for legacy mode
<+ulm> but the ebuild had DISTUTILS_USE_SETUPTOOLS=no before
<+ulm> how do I indicate distutils without setuptools?
<@mgorny> Distutils is dead, you always use setuptools
<+ulm> so I just remove the DISTUTILS_USE_SETUPTOOLS line and use the default?
<@mgorny> Yes
<+ulm> ok, that gets rid of the warning, and the installed image is identical
<@mgorny> That is, you set setuptools as the bs
<@mgorny> https://peps.python.org/pep-0491/ was supposed to add sane install dir support
<@mgorny> But it never went anywhere
<@mgorny> "But that won't work in virtualenv! "
Comment 10 Ulrich Müller gentoo-dev 2023-05-20 09:22:17 UTC
sexpdata upstream re-added value():
https://github.com/jd-boyd/sexpdata/commit/861cc5c8c96724b3e34ee1b6e15997b1d136635d

No release yet, but perspectively we could revert the change in gs-elpa.
Comment 11 Ulrich Müller gentoo-dev 2023-05-20 09:23:34 UTC
(In reply to Ulrich Müller from comment #10)
> sexpdata upstream re-added value():
> https://github.com/jd-boyd/sexpdata/commit/
> 861cc5c8c96724b3e34ee1b6e15997b1d136635d
> 
> No release yet, but perspectively we could revert the change in gs-elpa.

Sorry, this fix _is_ in the 1.0.0 release.