Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 895152 - sys-libs/efivar: Fix issues when building on musl (PATCH)
Summary: sys-libs/efivar: Fix issues when building on musl (PATCH)
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Mike Gilbert
URL:
Whiteboard:
Keywords: PATCH
Depends on:
Blocks: 831363
  Show dependency tree
 
Reported: 2023-02-17 20:25 UTC by Veronika
Modified: 2023-02-17 22:08 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
the git-format patch for repo/gentoo.git (0001-sys-libs-efivar-Fix-issues-when-building-on-musl.patch,6.14 KB, patch)
2023-02-17 20:25 UTC, Veronika
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Veronika 2023-02-17 20:25:57 UTC
Created attachment 852306 [details, diff]
the git-format patch for repo/gentoo.git

Hi!

This commit would fix bug #831363 by importing two commits from upstream that fix the issue.

Specifically these:
cece3ffd5be2f8641eb694513f2b73e5eb97ffd3  efisecdb: fix build with musl libc
df09b472419466987f2f30176dd00937e640aa9a  efisecdb: do not free optarg
I can't post links yet, the repo is rhboot/efivar on GitHub.

The git-formatted patch for repo/gentoo.git I've attached contains the patch for efivar itself, and the added line for the ebuild.

I tried building it in a chroot and it should work.

Veronika
Comment 1 Veronika 2023-02-17 20:45:49 UTC
Also, I forgot to unmask the package in the musl profile
Comment 2 Mike Gilbert gentoo-dev 2023-02-17 22:01:39 UTC
Is there a reason you combined the upstream commits? I generally prefer to maintain them as separate patches with their full commit messages.
Comment 3 Larry the Git Cow gentoo-dev 2023-02-17 22:08:31 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=e84fe06747ac63707f1a46dd16a658dc033d57f8

commit e84fe06747ac63707f1a46dd16a658dc033d57f8
Author:     Mike Gilbert <floppym@gentoo.org>
AuthorDate: 2023-02-17 22:08:08 +0000
Commit:     Mike Gilbert <floppym@gentoo.org>
CommitDate: 2023-02-17 22:08:08 +0000

    sys-libs/efivar: backport a couple fixes
    
    Closes: https://bugs.gentoo.org/831363
    Closes: https://bugs.gentoo.org/895152
    Signed-off-by: Mike Gilbert <floppym@gentoo.org>

 sys-libs/efivar/efivar-38.ebuild                   |   2 +
 .../efivar/files/efivar-38-efisecdb-musl.patch     | 179 +++++++++++++++++++++
 .../efivar/files/efivar-38-efisecdb-optarg.patch   |  51 ++++++
 3 files changed, 232 insertions(+)