Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 894644 - app-text/djvu-3.5.28-r3 fails to compile (MUSL-CLANG-SYSTEM): GBitmap.h:623:3: error: ISO C++17 does not allow register storage class specifier [-Wregister]
Summary: app-text/djvu-3.5.28-r3 fails to compile (MUSL-CLANG-SYSTEM): GBitmap.h:623:3...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: TeX project
URL:
Whiteboard:
Keywords: PATCH, PullRequest
Depends on:
Blocks:
 
Reported: 2023-02-15 18:57 UTC by Agostino Sarubbo
Modified: 2024-03-01 14:51 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log (build.log,77.98 KB, text/plain)
2023-02-15 18:57 UTC, Agostino Sarubbo
Details
Fixes the compilation issues on clang. (djvu-clang.patch,634 bytes, patch)
2023-06-28 10:48 UTC, Guillaume de Volpiano
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Agostino Sarubbo gentoo-dev 2023-02-15 18:57:29 UTC
https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: app-text/djvu-3.5.28-r3 fails to compile (MUSL-CLANG-SYSTEM).
Discovered on: amd64 (internal ref: tinderbox_musl)

NOTE:
(MUSL-CLANG-SYSTEM) in the summary means that bug was found on a machine that runs MUSL libc + clang16 but this bug MAY or MAY NOT BE related to musl/clang16.
Comment 1 Agostino Sarubbo gentoo-dev 2023-02-15 18:57:31 UTC
Created attachment 851480 [details]
build.log

build log and emerge --info
Comment 2 Guillaume de Volpiano 2023-06-19 19:17:20 UTC
For what it's worth, it also fails on a clang/libcxx system, but compiles fine with CXXFLAGS="${CXXFLAGS} -Wno-register"
Comment 3 Guillaume de Volpiano 2023-06-28 10:48:58 UTC
Created attachment 864778 [details, diff]
Fixes the compilation issues on clang.

This patch fixes the compilation issues on clang by removing the deprecated (and unneeded) register keyword from GBitmap.h
Comment 4 ernsteiswuerfel archtester 2023-07-18 18:15:27 UTC
Guillaumes patch just works fine!
Comment 5 Larry the Git Cow gentoo-dev 2023-08-19 05:50:48 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=1c370b3aebafad706edbb6aecbad93f5ad0eebb6

commit 1c370b3aebafad706edbb6aecbad93f5ad0eebb6
Author:     Brahmajit Das <brahmajit.xyz@gmail.com>
AuthorDate: 2023-08-17 18:09:22 +0000
Commit:     Joonas Niilola <juippis@gentoo.org>
CommitDate: 2023-08-19 05:50:45 +0000

    app-text/djvu: Fix C++17 does not allow register storage class
    
    Closes: https://bugs.gentoo.org/894644
    Signed-off-by: Brahmajit Das <brahmajit.xyz@gmail.com>
    Closes: https://github.com/gentoo/gentoo/pull/32359
    Signed-off-by: Joonas Niilola <juippis@gentoo.org>

 app-text/djvu/djvu-3.5.28-r4.ebuild                | 71 ++++++++++++++++++++++
 ...djvu-3.5.28-drop-register-keyword-clang16.patch | 21 +++++++
 2 files changed, 92 insertions(+)