Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 894498 - dev-libs/leveldb-1.23-r5 adds -Werror flag on its own (MUSL-CLANG-SYSTEM)
Summary: dev-libs/leveldb-1.23-r5 adds -Werror flag on its own (MUSL-CLANG-SYSTEM)
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Arthur Zamarin
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: werror
  Show dependency tree
 
Reported: 2023-02-15 07:02 UTC by Agostino Sarubbo
Modified: 2024-04-12 19:23 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log (build.log,92.63 KB, text/plain)
2023-02-15 07:02 UTC, Agostino Sarubbo
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Agostino Sarubbo gentoo-dev 2023-02-15 07:02:39 UTC
https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: dev-libs/leveldb-1.23-r5 adds -Werror flag on its own (MUSL-CLANG-SYSTEM).
Discovered on: amd64 (internal ref: tinderbox_musl)

NOTE:
(MUSL-CLANG-SYSTEM) in the summary means that bug was found on a machine that runs MUSL libc + clang16 but this bug MAY or MAY NOT BE related to musl/clang16.
-Werror is not recommended for releases and should always be disabled when encountered in build-logs, because there are numerous cases where this breaks without purpose.
See also: https://devmanual.gentoo.org/ebuild-writing/common-mistakes/index.html.
Comment 1 Agostino Sarubbo gentoo-dev 2023-02-15 07:02:41 UTC
Created attachment 851172 [details]
build.log

build log and emerge --info
Comment 2 Anna Vyalkova 2024-04-09 00:03:36 UTC
Worse. It adds "-Werror" to all CMake projects that use it

See /usr/lib64/cmake/leveldb/leveldbTargets.cmake
Comment 3 Arthur Zamarin archtester Gentoo Infrastructure gentoo-dev Security 2024-04-12 19:21:24 UTC
I don't know what Google are smoking, but this is added only on llvm toolchain

https://github.com/google/leveldb/blob/068d5ee1a3ac40dabd00d211d5013af44be55bea/CMakeLists.txt#L265-L269

Will drop ASAP
Comment 4 Larry the Git Cow gentoo-dev 2024-04-12 19:23:19 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=1025d0c164b905ef041e8aefa4d4df5bfac8831b

commit 1025d0c164b905ef041e8aefa4d4df5bfac8831b
Author:     Arthur Zamarin <arthurzam@gentoo.org>
AuthorDate: 2024-04-12 19:22:48 +0000
Commit:     Arthur Zamarin <arthurzam@gentoo.org>
CommitDate: 2024-04-12 19:23:09 +0000

    dev-libs/leveldb: fix -Werror
    
    Closes: https://bugs.gentoo.org/894498
    Signed-off-by: Arthur Zamarin <arthurzam@gentoo.org>

 dev-libs/leveldb/{leveldb-1.23-r5.ebuild => leveldb-1.23-r6.ebuild} | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)