Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 894166 - dev-libs/apr-util-1.6.3: SED: some expressions in the following did not cause any changes
Summary: dev-libs/apr-util-1.6.3: SED: some expressions in the following did not cause...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Apache Team - Bugzilla Reports
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-02-13 12:02 UTC by Michał Górny
Modified: 2023-02-14 06:37 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
/var/log/portage/dev-libs:apr-util-1.6.3:20230213-114111.log (dev-libs:apr-util-1.6.3:20230213-114111.log,64.81 KB, text/plain)
2023-02-13 12:02 UTC, Michał Górny
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2023-02-13 12:02:10 UTC
Created attachment 850674 [details]
/var/log/portage/dev-libs:apr-util-1.6.3:20230213-114111.log

I suppose the first two may be fine but the third one is suspicious:

 * Messages for package dev-libs/apr-util-1.6.3:
 * Log file: /var/log/portage/dev-libs:apr-util-1.6.3:20230213-114111.log

 * SED: some expressions in the following did not cause any changes
 *     sed -i -r -e "/^(apr_builddir|apr_builders|top_builddir)=/s:=:=${SYSROOT}:" -e "/^CC=/s:=.*:=$(tc-getCC):" -e '/^(C|CPP|CXX|LD)FLAGS=/d' -e '/^LTFLAGS/s:--silent::' build/rules.mk || die
 * no-op: -e /^(apr_builddir|apr_builders|top_builddir)=/s:=:=:
 * no-op: -e /^CC=/s:=.*:=x86_64-pc-linux-gnu-gcc:
 * no-op: -e /^(C|CPP|CXX|LD)FLAGS=/d
Comment 1 Ionen Wolkens gentoo-dev 2023-02-13 12:41:33 UTC
Seems it switched to using '?=' at some point (CFLAGS?=), meaning sed'ing them out is no longer necessary and env is used either way.
Comment 2 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2023-02-14 04:39:22 UTC
looking
Comment 3 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2023-02-14 04:47:20 UTC
The others appear to be needed, but *FLAGS is indeed fine now.
Comment 4 Larry the Git Cow gentoo-dev 2023-02-14 06:37:29 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=9f7bb25c5e3f6a2a392dc75e7f37af876971a710

commit 9f7bb25c5e3f6a2a392dc75e7f37af876971a710
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2023-02-14 04:47:35 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2023-02-14 06:37:07 +0000

    dev-libs/apr-util: cleanup sed
    
    No longer need *FLAGS substitution as it uses ?=.
    
    Closes: https://bugs.gentoo.org/894166
    Signed-off-by: Sam James <sam@gentoo.org>

 dev-libs/apr-util/apr-util-1.6.3.ebuild | 1 -
 1 file changed, 1 deletion(-)