Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 894068 - gui-apps/waybar-0.9.17: add USE flag for enabling mpris support
Summary: gui-apps/waybar-0.9.17: add USE flag for enabling mpris support
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal enhancement
Assignee: Jonas Toth
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks:
 
Reported: 2023-02-12 17:46 UTC by Dale Whinham
Modified: 2023-04-16 00:11 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Dale Whinham 2023-02-12 17:46:49 UTC
As of version 0.9.17, waybar can be compiled with the meson "mpris" option enabled to allow the bar to display and control currently-playing media.

This feature requires libplayerctl, which is provided in Gentoo by media-sound/
playerctl.

It would be nice if this package could gain a USE flag to enable this feature.

As an example of precedent, x11-misc/yabar has a "playerctl" USE flag for this purpose.

Reproducible: Always
Comment 1 Larry the Git Cow gentoo-dev 2023-04-10 05:22:11 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=a5064961fea762cf204de7bed03e018dbaf5acee

commit a5064961fea762cf204de7bed03e018dbaf5acee
Author:     Julien Roy <julien@jroy.ca>
AuthorDate: 2023-04-09 22:21:57 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2023-04-10 05:21:34 +0000

    gui-apps/waybar: add several USE flags
    
    evdev, jack, libinput, logind, mpris, pipewire, systemd, test, upower
    drop net-wireless/rfkill DEPEND
    
    Closes: https://bugs.gentoo.org/894068
    Signed-off-by: Julien Roy <julien@jroy.ca>
    Signed-off-by: Sam James <sam@gentoo.org>

 gui-apps/waybar/files/systemd-0.9.17.patch |  35 ++++++++++
 gui-apps/waybar/metadata.xml               |   7 +-
 gui-apps/waybar/waybar-0.9.17-r1.ebuild    | 102 +++++++++++++++++++++++++++++
 gui-apps/waybar/waybar-9999.ebuild         |  46 ++++++++++---
 4 files changed, 181 insertions(+), 9 deletions(-)
Comment 2 Rodrigo Kochenburger 2023-04-11 18:31:45 UTC
It looks like the this change introduced a pulseaudio useflag and introduced a pipewire flag.

However, if using pipewire's pulseaudio implementation, the module does not seem to work correctly when -pulseaudio +pipewire is enabled.

I wasn't sure if that is intended or if it requires a config change for pipewire to work, so I wanted to ask here first before adding another bug.
Comment 3 Julien Roy 2023-04-11 18:34:52 UTC
(In reply to Rodrigo Kochenburger from comment #2)

Bug https://bugs.gentoo.org/904165 mentions a different (but similar) issue with regards to pulseaudio and pipewire.
The fix for that bug should cover your use case, but you can add a comment to that bug to mention this other problem as well.
Comment 4 Tomasz Golinski 2023-04-14 13:27:08 UTC
I have also compiled waybar with +mpris -pulseaudio +pipewire and the module mpris doesn't seem to be present. Waybar reports:

[2023-04-14 15:13:17.603] [warning] module mpris: Unknown module: mpris
Comment 5 Julien Roy 2023-04-14 20:40:15 UTC
(In reply to Tomasz Golinski from comment #4)
> I have also compiled waybar with +mpris -pulseaudio +pipewire and the module
> mpris doesn't seem to be present. Waybar reports:
> 
> [2023-04-14 15:13:17.603] [warning] module mpris: Unknown module: mpris

That's because the mpris module will only be built if the `logind` USE flag is turned on as well.
I will update the ebuild to reflect this, thanks for reporting it.
Comment 6 Larry the Git Cow gentoo-dev 2023-04-16 00:11:46 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=8d5b83c04eafed28c97d9ef5909f7eaedbb69078

commit 8d5b83c04eafed28c97d9ef5909f7eaedbb69078
Author:     Julien Roy <julien@jroy.ca>
AuthorDate: 2023-04-15 15:20:59 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2023-04-16 00:10:30 +0000

    gui-apps/waybar: add 0.9.17-r2
    
    Fix pulseaudio USE flag dependency
    Remove systemd patch
    Improme logind USE flag description
    Add REQUIRED_USE for mpris and upower
    Make libinput USE flag enabled by default
    
    Bug: https://bugs.gentoo.org/894068
    Closes: https://bugs.gentoo.org/904163
    Closes: https://bugs.gentoo.org/904165
    Signed-off-by: Julien Roy <julien@jroy.ca>
    Signed-off-by: Sam James <sam@gentoo.org>

 gui-apps/waybar/metadata.xml            |   2 +-
 gui-apps/waybar/waybar-0.9.17-r2.ebuild | 106 ++++++++++++++++++++++++++++++++
 gui-apps/waybar/waybar-9999.ebuild      |  15 ++---
 3 files changed, 115 insertions(+), 8 deletions(-)