Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 893740 - dev-util/ruff-0.0.243 fails to compile: error: usage of an unsafe block
Summary: dev-util/ruff-0.0.243 fails to compile: error: usage of an unsafe block
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Patrick McLean
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-02-09 07:53 UTC by Agostino Sarubbo
Modified: 2023-02-09 20:04 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log (build.log,385.57 KB, text/plain)
2023-02-09 07:53 UTC, Agostino Sarubbo
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Agostino Sarubbo gentoo-dev 2023-02-09 07:53:40 UTC
https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: dev-util/ruff-0.0.243 fails to compile.
Discovered on: amd64 (internal ref: ci)
Comment 1 Agostino Sarubbo gentoo-dev 2023-02-09 07:53:42 UTC
Created attachment 850268 [details]
build.log

build log and emerge --info
Comment 2 Patrick McLean gentoo-dev 2023-02-09 19:16:46 UTC
It looks like the build here adds these parameters to rustc, very likely causing the failure:

-Dunsafe_code '-Wclippy::pedantic' '-Wclippy::char_lit_as_u8' '-Aclippy::collapsible_else_if' '-Aclippy::collapsible_if' '-Aclippy::implicit_hasher' '-Aclippy::match_same_arms' '-Aclippy::missing_errors_doc' '-Aclippy::missing_panics_doc' '-Aclippy::module_name_repetitions' '-Aclippy::must_use_candidate' '-Aclippy::similar_names' '-Aclippy::too_many_lines' '-Wclippy::print_stdout' '-Wclippy::print_stderr' '-Wclippy::dbg_macro'

Please don't add a bunch of extra checking parameters to rust code, we can trust upstream to provide the parameters their code needs to compile.

Raw comparison:
$ rg common/src/lib.rs ago-build.log build.log
build.log
1134:     Running `rustc --crate-name rustpython_common --edition=2021 /var/tmp/portage/dev-util/ruff-0.0.243/work/RustPython-adc23253e4b58980b407ba2760dbe61681d752fc/common/src/lib.rs --error-format=json --json=diagnostic-rendered-ansi,artifacts,future-incompat --crate-type lib --emit=dep-info,metadata,link -C opt-level=3 -C panic=abort -C codegen-units=1 -C metadata=1a313ecc68cfc271 -C extra-filename=-1a313ecc68cfc271 --out-dir /var/tmp/portage/dev-util/ruff-0.0.243/work/ruff-0.0.243/target/release/deps -L dependency=/var/tmp/portage/dev-util/ruff-0.0.243/work/ruff-0.0.243/target/release/deps --extern ascii=/var/tmp/portage/dev-util/ruff-0.0.243/work/ruff-0.0.243/target/release/deps/libascii-f327744700f868e1.rmeta --extern bitflags=/var/tmp/portage/dev-util/ruff-0.0.243/work/ruff-0.0.243/target/release/deps/libbitflags-a6d29a85a8a3790d.rmeta --extern cfg_if=/var/tmp/portage/dev-util/ruff-0.0.243/work/ruff-0.0.243/target/release/deps/libcfg_if-22e12202d69d0b08.rmeta --extern hexf_parse=/var/tmp/portage/dev-util/ruff-0.0.243/work/ruff-0.0.243/target/release/deps/libhexf_parse-13cf840f7e94d60d.rmeta --extern itertools=/var/tmp/portage/dev-util/ruff-0.0.243/work/ruff-0.0.243/target/release/deps/libitertools-25938fc9532085c1.rmeta --extern lexical_parse_float=/var/tmp/portage/dev-util/ruff-0.0.243/work/ruff-0.0.243/target/release/deps/liblexical_parse_float-a226a75c39c4df1d.rmeta --extern libc=/var/tmp/portage/dev-util/ruff-0.0.243/work/ruff-0.0.243/target/release/deps/liblibc-56b0204f7608638a.rmeta --extern lock_api=/var/tmp/portage/dev-util/ruff-0.0.243/work/ruff-0.0.243/target/release/deps/liblock_api-97ee476bb83cff72.rmeta --extern num_bigint=/var/tmp/portage/dev-util/ruff-0.0.243/work/ruff-0.0.243/target/release/deps/libnum_bigint-a73041a446baff5a.rmeta --extern num_complex=/var/tmp/portage/dev-util/ruff-0.0.243/work/ruff-0.0.243/target/release/deps/libnum_complex-67f9a89da46e1715.rmeta --extern num_traits=/var/tmp/portage/dev-util/ruff-0.0.243/work/ruff-0.0.243/target/release/deps/libnum_traits-f31e98e6288f42e8.rmeta --extern once_cell=/var/tmp/portage/dev-util/ruff-0.0.243/work/ruff-0.0.243/target/release/deps/libonce_cell-bbfdf0b921e942ba.rmeta --extern radium=/var/tmp/portage/dev-util/ruff-0.0.243/work/ruff-0.0.243/target/release/deps/libradium-c88ac52a211df5a1.rmeta --extern rand=/var/tmp/portage/dev-util/ruff-0.0.243/work/ruff-0.0.243/target/release/deps/librand-fe58a1f8a03ebcc0.rmeta --extern siphasher=/var/tmp/portage/dev-util/ruff-0.0.243/work/ruff-0.0.243/target/release/deps/libsiphasher-9429e574c64b1e60.rmeta --extern unic_ucd_category=/var/tmp/portage/dev-util/ruff-0.0.243/work/ruff-0.0.243/target/release/deps/libunic_ucd_category-9f3f860b8f535a01.rmeta --extern volatile=/var/tmp/portage/dev-util/ruff-0.0.243/work/ruff-0.0.243/target/release/deps/libvolatile-95a5f9f91e76e115.rmeta -C target-cpu=znver2 -C opt-level=3 -v`

ago-build.log
1079:     Running `rustc --crate-name rustpython_common --edition=2021 /var/tmp/portage/dev-util/ruff-0.0.243/work/RustPython-adc23253e4b58980b407ba2760dbe61681d752fc/common/src/lib.rs --error-format=json --json=diagnostic-rendered-ansi,artifacts,future-incompat --crate-type lib --emit=dep-info,metadata,link -C embed-bitcode=no -C debuginfo=2 -C metadata=60355393787d0bf8 -C extra-filename=-60355393787d0bf8 --out-dir /var/tmp/portage/dev-util/ruff-0.0.243/work/ruff-0.0.243/target/debug/deps -L dependency=/var/tmp/portage/dev-util/ruff-0.0.243/work/ruff-0.0.243/target/debug/deps --extern ascii=/var/tmp/portage/dev-util/ruff-0.0.243/work/ruff-0.0.243/target/debug/deps/libascii-93749fc0ffbc609c.rmeta --extern bitflags=/var/tmp/portage/dev-util/ruff-0.0.243/work/ruff-0.0.243/target/debug/deps/libbitflags-0b8e9e8c83c36be3.rmeta --extern cfg_if=/var/tmp/portage/dev-util/ruff-0.0.243/work/ruff-0.0.243/target/debug/deps/libcfg_if-8ef7d541bda7818f.rmeta --extern hexf_parse=/var/tmp/portage/dev-util/ruff-0.0.243/work/ruff-0.0.243/target/debug/deps/libhexf_parse-4402c2beed250fcd.rmeta --extern itertools=/var/tmp/portage/dev-util/ruff-0.0.243/work/ruff-0.0.243/target/debug/deps/libitertools-a201efe663c783c8.rmeta --extern lexical_parse_float=/var/tmp/portage/dev-util/ruff-0.0.243/work/ruff-0.0.243/target/debug/deps/liblexical_parse_float-e06d71975d83d9d9.rmeta --extern libc=/var/tmp/portage/dev-util/ruff-0.0.243/work/ruff-0.0.243/target/debug/deps/liblibc-e7b4e9f547dd56bd.rmeta --extern lock_api=/var/tmp/portage/dev-util/ruff-0.0.243/work/ruff-0.0.243/target/debug/deps/liblock_api-6e9e55d8120d1598.rmeta --extern num_bigint=/var/tmp/portage/dev-util/ruff-0.0.243/work/ruff-0.0.243/target/debug/deps/libnum_bigint-7c6b267dbec31e31.rmeta --extern num_complex=/var/tmp/portage/dev-util/ruff-0.0.243/work/ruff-0.0.243/target/debug/deps/libnum_complex-9ee3eb80a8734c0b.rmeta --extern num_traits=/var/tmp/portage/dev-util/ruff-0.0.243/work/ruff-0.0.243/target/debug/deps/libnum_traits-7973d0fb1ac72b81.rmeta --extern once_cell=/var/tmp/portage/dev-util/ruff-0.0.243/work/ruff-0.0.243/target/debug/deps/libonce_cell-fb42ff5058d8f167.rmeta --extern radium=/var/tmp/portage/dev-util/ruff-0.0.243/work/ruff-0.0.243/target/debug/deps/libradium-9027ad72f6bfe3da.rmeta --extern rand=/var/tmp/portage/dev-util/ruff-0.0.243/work/ruff-0.0.243/target/debug/deps/librand-4e2cc800a00ebb8c.rmeta --extern siphasher=/var/tmp/portage/dev-util/ruff-0.0.243/work/ruff-0.0.243/target/debug/deps/libsiphasher-5bdf6571def87391.rmeta --extern unic_ucd_category=/var/tmp/portage/dev-util/ruff-0.0.243/work/ruff-0.0.243/target/debug/deps/libunic_ucd_category-eec9936614beaff6.rmeta --extern volatile=/var/tmp/portage/dev-util/ruff-0.0.243/work/ruff-0.0.243/target/debug/deps/libvolatile-4d5be2c8409c76b9.rmeta -Dunsafe_code '-Wclippy::pedantic' '-Wclippy::char_lit_as_u8' '-Aclippy::collapsible_else_if' '-Aclippy::collapsible_if' '-Aclippy::implicit_hasher' '-Aclippy::match_same_arms' '-Aclippy::missing_errors_doc' '-Aclippy::missing_panics_doc' '-Aclippy::module_name_repetitions' '-Aclippy::must_use_candidate' '-Aclippy::similar_names' '-Aclippy::too_many_lines' '-Wclippy::print_stdout' '-Wclippy::print_stderr' '-Wclippy::dbg_macro'`
Comment 3 Agostino Sarubbo gentoo-dev 2023-02-09 19:39:48 UTC
I'm not adding anything, this is the first time I see these flags
Comment 4 Agostino Sarubbo gentoo-dev 2023-02-09 19:40:27 UTC
did you try with USE=debug ?
Comment 5 Larry the Git Cow gentoo-dev 2023-02-09 20:04:16 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=c19441ef3dba108713925ab3db8550ad1528f02b

commit c19441ef3dba108713925ab3db8550ad1528f02b
Author:     Patrick McLean <chutzpah@gentoo.org>
AuthorDate: 2023-02-09 20:02:54 +0000
Commit:     Patrick McLean <chutzpah@gentoo.org>
CommitDate: 2023-02-09 20:04:12 +0000

    dev-util/ruff: Make sure RUSTFLAGS is set to avoid clippy errors (bug #893740)
    
    Closes: https://bugs.gentoo.org/893740
    Signed-off-by: Patrick McLean <chutzpah@gentoo.org>

 dev-util/ruff/ruff-0.0.244.ebuild | 1 +
 1 file changed, 1 insertion(+)