Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 893644 - media-sound/easytag-2.4.3-r5: switch from media-libs/id3lib to media-libs/taglib
Summary: media-sound/easytag-2.4.3-r5: switch from media-libs/id3lib to media-libs/taglib
Status: CONFIRMED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Gentoo Sound Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-02-08 19:57 UTC by jon R-B
Modified: 2025-02-14 15:11 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description jon R-B 2023-02-08 19:57:08 UTC
easytag depends on id3lib for mp3 tag editing. 
Due to https://bugs.gentoo.org/893642 id3lib is unable to build.

When reviewing the homepage for id3lib https://sourceforge.net/projects/id3lib/

id3lib is/was a software library for reading, writing, and manipulating ID3v2 tags. Additionally it is possible to get some basic mp3 header information like bitrate etc.
However, we now recommend moving to taglib. https://taglib.org/


the ebuild was edited to use taglib instead and easytag builds, runs and edits mp3's fine 


diff -u easytag-2.4.3-r5.ebuild easytag-2.4.3-r6.ebuild
--- easytag-2.4.3-r5.ebuild	2022-12-21 17:11:40.929533178 +0000
+++ easytag-2.4.3-r6.ebuild	2023-02-08 19:40:57.899078402 +0000
@@ -25,7 +25,7 @@
 	>=x11-libs/gtk+-3.10:3
 	flac? ( >=media-libs/flac-1.3:= )
 	mp3? (
-		>=media-libs/id3lib-3.8.3-r8
+		>=media-libs/taglib-1.13
 		>=media-libs/libid3tag-0.15.1b-r4:=
 	)
 	mp4? ( >=media-libs/taglib-1.9.1[mp4(+)] )



Recommend changing the dependency.


This replacement could also be viable for:

media-sound/kid3
media-sound/id3v2
media-sound/split2flac
media-sound/ripperx
media-sound/tagtool
media-sound/splay
media-sound/grip
kde-apps/kwave
media-sound/audiotag
media-sound/split2flac
Comment 1 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2023-02-08 20:00:11 UTC
We'll have to make some change to the build system to make it actuallly choose which to use, otherwise it's automagic.
Comment 2 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2023-02-08 20:01:25 UTC
It may still need id3tag for mp3? https://gitlab.gnome.org/GNOME/easytag/-/blob/master/configure.ac#L252
Comment 3 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2023-02-08 20:01:32 UTC
id3lib*
Comment 4 jon R-B 2023-02-08 20:11:04 UTC
yup I just dug into it a bit more... its not as simple :(
Comment 5 Larry the Git Cow gentoo-dev 2025-02-04 15:47:24 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=5b0d1e373dcd8c4f79735d033d205a6f36698c59

commit 5b0d1e373dcd8c4f79735d033d205a6f36698c59
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2025-02-04 15:46:17 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2025-02-04 15:46:17 +0000

    media-libs/id3lib: fix C23 issues as best we can
    
    The situation here is complicated. With C23, 'bool' is exposed properly
    out of the box (as the same type as '_Bool'). But this is problematic
    when it comes to C++ where 'bool' was always '_Bool' (or near-enough
    guaranteed), and where we have existing C applications that we don't
    want to break ABI for.
    
    For C++, id3tag was always using native C++ 'bool', so we don't want to change
    that now when looking at C23 compat. This means the ABI issues between
    C and C++ remain: typedef bool my_bool.
    
    For C, continue using the old 'int bool' that the project did before
    C23. This doesn't solve the pre-existing C/C++ ABI issue here where
    C++ always had "good _Bool-as-bool", unfortunately: typedef int my_bool.
    
    Really, we need people to port to taglib ASAP.
    
    Bug: https://bugs.gentoo.org/893644
    Bug: https://bugs.gentoo.org/949086
    Signed-off-by: Sam James <sam@gentoo.org>

 media-libs/id3lib/files/id3lib-3.8.3-fix-c23.patch | 2202 +-------------------
 1 file changed, 51 insertions(+), 2151 deletions(-)