Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 893172 - distutils-r1.eclass: Add a check for packages installing data files straight into site-packages
Summary: distutils-r1.eclass: Add a check for packages installing data files straight ...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Eclasses (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Python Gentoo Team
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks:
 
Reported: 2023-02-04 04:17 UTC by Michał Górny
Modified: 2023-02-07 14:31 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2023-02-04 04:17:19 UTC
Given how bad poetry is, we really need a specific check:

 * package dev-python/python-box-7.0.0 NOT merged
 * 
 * Detected file collision(s):
 * 
 *      /usr/lib/python3.11/site-packages/LICENSE
 *      /usr/lib/python3.10/site-packages/LICENSE
 *      /usr/lib/python3.9/site-packages/LICENSE
 * 
 * Searching all installed packages for file collisions...
 * 
 * Press Ctrl-C to Stop
 * 
 * dev-python/flask-babel-3.0.1:0::gentoo
 *      /usr/lib/python3.10/site-packages/LICENSE
 *      /usr/lib/python3.11/site-packages/LICENSE
 *      /usr/lib/python3.9/site-packages/LICENSE
Comment 1 Larry the Git Cow gentoo-dev 2023-02-07 14:31:18 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=81b315aa895f4224958bbc4f9abe9c655205f60d

commit 81b315aa895f4224958bbc4f9abe9c655205f60d
Author:     Michał Górny <mgorny@gentoo.org>
AuthorDate: 2023-02-04 17:56:13 +0000
Commit:     Michał Górny <mgorny@gentoo.org>
CommitDate: 2023-02-07 14:24:39 +0000

    distutils-r1.eclass: Report stray top-level files in site-packages
    
    In addition to checking for known-bad package names, detect stray
    files installed into top-level site-packages directory.  This is
    primarily meant to cover the common mistake in using `include`
    in Poetry-built packages.
    
    Closes: https://bugs.gentoo.org/893172
    Closes: https://github.com/gentoo/gentoo/pull/29425
    Signed-off-by: Michał Górny <mgorny@gentoo.org>

 eclass/distutils-r1.eclass | 30 ++++++++++++++++++++++++++----
 1 file changed, 26 insertions(+), 4 deletions(-)