Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 893122 - dev-util/bpftrace: bpftrace-0.17.0-install-libs.patch missing install() for `bpftracearch`
Summary: dev-util/bpftrace: bpftrace-0.17.0-install-libs.patch missing install() for `...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Patrick McLean
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-02-03 18:53 UTC by Rafael Ristovski
Modified: 2023-02-06 09:13 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Rafael Ristovski 2023-02-03 18:53:08 UTC
The bpftrace-0.17.0-install-libs.patch patch is missing a single line (copy-paste mishap?): `install(TARGETS bpftracearch LIBRARY DESTINATION ${CMAKE_INSTALL_LIBDIR})`, this causes bpftrace to fail to run due to the `bpftracearch` lib not being installed.

You can compare the following linked lines to spot the missing `install()` statement:

Working: https://gitweb.gentoo.org/repo/gentoo.git/tree/dev-util/bpftrace/files/bpftrace-0.15.0-install-libs.patch?id=90756882da5d06a2e4b4e7d0f718d97dad65f136#n122
Broken: https://gitweb.gentoo.org/repo/gentoo.git/tree/dev-util/bpftrace/files/bpftrace-0.17.0-install-libs.patch?id=90756882da5d06a2e4b4e7d0f718d97dad65f136#n248

Reproducible: Always
Comment 1 Rafael Ristovski 2023-02-03 19:02:33 UTC
> diff --git a/src/arch/CMakeLists.txt b/src/arch/CMakeLists.txt
> index 7d96587..82bfecc 100644
> --- a/src/arch/CMakeLists.txt
> +++ b/src/arch/CMakeLists.txt
> @@ -19,3 +19,5 @@ elseif(CMAKE_SYSTEM_PROCESSOR STREQUAL "loongarch64")
>  else()
>    message(FATAL_ERROR "Unsupported architecture: ${CMAKE_SYSTEM_PROCESSOR}")
>  endif()
> +
> +install(TARGETS bpftracearch LIBRARY DESTINATION ${CMAKE_INSTALL_LIBDIR})
Comment 2 Larry the Git Cow gentoo-dev 2023-02-06 02:04:28 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=c769d53008070e3795d5999bc5732f2d966e01c7

commit c769d53008070e3795d5999bc5732f2d966e01c7
Author:     Patrick McLean <chutzpah@gentoo.org>
AuthorDate: 2023-02-06 02:03:48 +0000
Commit:     Patrick McLean <chutzpah@gentoo.org>
CommitDate: 2023-02-06 02:03:48 +0000

    dev-util/bpftrace: revbump to 0.17.0-r2 Install bpstracearch (bug #893122)
    
    Closes: https://bugs.gentoo.org/893122
    Signed-off-by: Patrick McLean <chutzpah@gentoo.org>

 .../{bpftrace-0.17.0-r1.ebuild => bpftrace-0.17.0-r2.ebuild}        | 0
 dev-util/bpftrace/files/bpftrace-0.17.0-install-libs.patch          | 6 ++++--
 2 files changed, 4 insertions(+), 2 deletions(-)
Comment 3 Holger Hoffstätte 2023-02-06 09:13:26 UTC
Should this patch not go upstream? I couldn't find a corresponding bug or PR.