Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 892709 - [kde overlay] kde-plasma/plasma-nm: fails to compile without dev-qt/qtwebengine
Summary: [kde overlay] kde-plasma/plasma-nm: fails to compile without dev-qt/qtwebengine
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Overlays (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo KDE team
URL:
Whiteboard:
Keywords: PATCH, UPSTREAM
Depends on:
Blocks:
 
Reported: 2023-01-31 11:16 UTC by Urmet Saar
Modified: 2023-02-23 22:43 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
patch fixing qtwebengine dependency in CMakeLists.txt (plasma-nm.patch,711 bytes, patch)
2023-01-31 11:17 UTC, Urmet Saar
Details | Diff
build log (file_892709.txt,5.13 KB, text/plain)
2023-02-23 09:57 UTC, Urmet Saar
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Urmet Saar 2023-01-31 11:16:40 UTC
I don't have qtwebengine installed and don't use openconnect, but plasma-nm CMakeLists.txt depends on web engine components unconditionally while it's only used for openconnect UI. 

Reproducible: Always

Steps to Reproduce:
1. try to install plasma-nm on a system without qtwebengine package installed


Actual Results:  
installation fails at configuration step


I added two extra sed commands to src_prepare step to remove references to webengine if openconnect isn't used
Comment 1 Urmet Saar 2023-01-31 11:17:54 UTC
Created attachment 849551 [details, diff]
patch fixing qtwebengine dependency in CMakeLists.txt
Comment 2 Andreas Sturmlechner gentoo-dev 2023-02-05 10:53:04 UTC
Version, build.log?
Comment 3 Andreas Sturmlechner gentoo-dev 2023-02-23 07:51:16 UTC
ping
Comment 4 Urmet Saar 2023-02-23 09:57:38 UTC
Created attachment 854080 [details]
build log

Sorry, missed the previous email. Issue appears with 9999 version from overlay, build log attached. 

And I now also found the cause. upstream added unconditional webengine requirement about a month ago when they added SAML login support to openconnect plugin. 
https://github.com/KDE/plasma-nm/commit/6ef64be8645ac32fc0b42df2cee5d9ff3b57e485

I guess I'll go report it over there too now.
Comment 5 Larry the Git Cow gentoo-dev 2023-02-23 22:43:12 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/proj/kde.git/commit/?id=812c4dc366899fdd36ffb61d4b6b0137186a256b

commit 812c4dc366899fdd36ffb61d4b6b0137186a256b
Author:     Andreas Sturmlechner <asturm@gentoo.org>
AuthorDate: 2023-02-23 22:39:01 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2023-02-23 22:42:38 +0000

    kde-plasma/plasma-nm: Fix IUSE openconnect, add new dependency
    
    See also:
    https://invent.kde.org/plasma/plasma-nm/-/merge_requests/222
    
    Closes: https://bugs.gentoo.org/892709
    Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>

 .../plasma-nm-5.27.80-openconnect-optional.patch   | 77 ++++++++++++++++++++++
 kde-plasma/plasma-nm/plasma-nm-9999.ebuild         | 14 ++--
 2 files changed, 85 insertions(+), 6 deletions(-)