A friend pointed out that macports does this: ``` Warning: Configuration logfiles contain indications of -Wimplicit-function-declaration; check that features were not accidentally disabled: alignof: found in texinfo-7.0/tp/Texinfo/XS/config.log re_search: found in texinfo-7.0/config.log re_compile_pattern: found in texinfo-7.0/config.log re_set_syntax: found in texinfo-7.0/config.log MIN: found in texinfo-7.0/config.log strchr: found in texinfo-7.0/config.log, texinfo-7.0/tp/Texinfo/XS/config.log ``` This could be pretty useful for us, I think.
Their check is https://github.com/macports/macports-base/blob/15270571ab178ddff693fbd722163fe1d638ed55/src/port1.0/portconfigure.tcl#L1853.
We can probably implement this as a postinst QA check like in bin/install-qa-check.d/* (I think it probably belongs in portage rather than ::gentoo).
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/proj/portage.git/commit/?id=dc1e8d7b9ad8f7253fa14e068547b63b14c829b7 commit dc1e8d7b9ad8f7253fa14e068547b63b14c829b7 Author: Oskari Pirhonen <xxc3ncoredxx@gmail.com> AuthorDate: 2023-02-01 04:32:20 +0000 Commit: Sam James <sam@gentoo.org> CommitDate: 2023-02-26 20:22:42 +0000 install-qa-check.d/90config-impl-decl: check config log for warnings Check for -Wimplicit-function-declaration in: - config.log - CMakeError.log - meson-log.txt and log the config log, line number, and function name on-screen and in qa.log under the tag 'config.log-impl-decl'. In ebuilds, use the `QA_CONFIG_IMPL_DECL_SKIP` array to skip false positives. Closes: https://bugs.gentoo.org/892651 Signed-off-by: Oskari Pirhonen <xxc3ncoredxx@gmail.com> Signed-off-by: Sam James <sam@gentoo.org> bin/install-qa-check.d/90config-impl-decl | 87 +++++++++++++++++++++++++++++++ 1 file changed, 87 insertions(+)
The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=cd8ade10313d72cb0e3dd2229df02e0ea8681daa commit cd8ade10313d72cb0e3dd2229df02e0ea8681daa Author: Sam James <sam@gentoo.org> AuthorDate: 2023-02-26 22:01:01 +0000 Commit: Sam James <sam@gentoo.org> CommitDate: 2023-02-26 22:01:10 +0000 sys-apps/portage: add 3.0.45 Bug: https://bugs.gentoo.org/891001 Bug: https://bugs.gentoo.org/889330 Bug: https://bugs.gentoo.org/890777 Bug: https://bugs.gentoo.org/891391 Bug: https://bugs.gentoo.org/893638 Bug: https://bugs.gentoo.org/795825 Bug: https://bugs.gentoo.org/884869 Bug: https://bugs.gentoo.org/888585 Bug: https://bugs.gentoo.org/892651 Bug: https://bugs.gentoo.org/895526 Signed-off-by: Sam James <sam@gentoo.org> sys-apps/portage/Manifest | 1 + sys-apps/portage/portage-3.0.45.ebuild | 288 +++++++++++++++++++++++++++++++++ 2 files changed, 289 insertions(+)
