Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 892471 - net-analyzer/monitoring-plugins-2.3.2-r1 : check_ping has wrong hardcoded path to ping binary
Summary: net-analyzer/monitoring-plugins-2.3.2-r1 : check_ping has wrong hardcoded pat...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Tomáš Mózes
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks:
 
Reported: 2023-01-28 21:56 UTC by Carlos Konstanski
Modified: 2024-06-26 11:36 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Konstanski 2023-01-28 21:56:53 UTC
The check_ping binary looks for ping at /bin/ping. But (perhaps due to a recent change in other gentoo packages) ping now resides at /usr/bin/ping.

root@sphinkpad:/usr/lib64/nagios/plugins # ./check_ping -H 192.168.43.2 -4 -w 170,170% -c 250,250%
/bin/ping -4 -n -U -w 10 -c 5 192.168.43.2
CRITICAL - Could not interpret output from ping command
root@sphinkpad:/usr/lib64/nagios/plugins # which ping
/usr/bin/ping

Reproducible: Always
Comment 1 Michael Orlitzky gentoo-dev 2023-01-28 22:40:07 UTC
Yeah, net-misc/iputils moved it out from under us. A new version of monitoring-plugins went stable today and if you emerge that, it will pick up the correct path. Or if you had the ~arch monitoring-plugins keyworded already, just re-emerge it.

The stabilization of iputils today is what caused the issue, and there's really no good way for us to trigger a rebuild of monitoring-plugins (and nagios-plugins, which has the same problem). We tried to stabilize them at the same time, but it's not foolproof.
Comment 2 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2023-01-28 22:45:30 UTC
When iputils is stable everywhere, we can add >= deps in them, I guess.
Comment 3 Tomáš Mózes 2023-02-03 18:51:01 UTC
(In reply to Sam James from comment #2)
> When iputils is stable everywhere, we can add >= deps in them, I guess.

The ping command path is detected during package configuration:
https://github.com/gentoo/gentoo/blob/master/net-analyzer/monitoring-plugins/monitoring-plugins-2.3.2-r1.ebuild#L77

How about we add a slot to net-misc/iputils and add DEPEND="net-misc/iputils:=" to monitoring-plugins? We would need to bump the slot in iputils when paths change.
Comment 4 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2023-02-03 19:12:56 UTC
I don't anticipate the paths changing again so a oke off revbump to >= should work
Comment 5 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2023-02-03 19:30:33 UTC
Ugh, I forgot that we don't actually depend on iputils in the ebuild right now, as we might be using another ping...
Comment 6 NHO 2024-06-26 06:40:25 UTC
Appears to be fixed in 2.3.5
Comment 7 Larry the Git Cow gentoo-dev 2024-06-26 11:36:52 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=f80b374043945c811c758e13516f1c9f98f1fe3f

commit f80b374043945c811c758e13516f1c9f98f1fe3f
Author:     NHOrus <jy6x2b32pie9@yahoo.com>
AuthorDate: 2024-06-26 06:25:37 +0000
Commit:     Michael Orlitzky <mjo@gentoo.org>
CommitDate: 2024-06-26 11:21:02 +0000

    net-analyzer/monitoring-plugins: drop 2.3.3-r2
    
    We have 2.3.5 that fixed those errors and is stable.
    
    Closes: https://bugs.gentoo.org/871519
    Closes: https://bugs.gentoo.org/892471
    Closes: https://github.com/gentoo/gentoo/pull/37306
    Signed-off-by: NHOrus <jy6x2b32pie9@yahoo.com>
    Signed-off-by: Michael Orlitzky <mjo@gentoo.org>

 net-analyzer/monitoring-plugins/Manifest           |   1 -
 .../monitoring-plugins-2.3.3-r2.ebuild             | 110 ---------------------
 2 files changed, 111 deletions(-)