Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 892165 - games-action/supertuxkart-1.4 adds -Werror flag on its own
Summary: games-action/supertuxkart-1.4 adds -Werror flag on its own
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Gentoo Games
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: werror
  Show dependency tree
 
Reported: 2023-01-27 06:13 UTC by Agostino Sarubbo
Modified: 2023-01-28 05:11 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log.xz (build.log.xz,91.73 KB, application/x-xz)
2023-01-27 06:13 UTC, Agostino Sarubbo
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Agostino Sarubbo gentoo-dev 2023-01-27 06:13:46 UTC
https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: games-action/supertuxkart-1.4 adds -Werror flag on its own.
Discovered on: amd64 (internal ref: ci)

NOTE:
-Werror is not recommended for releases and should always be disabled when encountered in build-logs, because there are numerous cases where this breaks without purpose.
See also: https://devmanual.gentoo.org/ebuild-writing/common-mistakes/index.html.
Comment 1 Agostino Sarubbo gentoo-dev 2023-01-27 06:13:48 UTC
Created attachment 849267 [details]
build.log.xz

build log and emerge --info (compressed because it exceeds attachment limit, use 'xzless' to read it)
Comment 2 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2023-01-27 08:28:50 UTC
I'll fix later. https://github.com/supertuxkart/stk-code/commit/99bd8a338adaefff49e2ca49378e87594f60d6c7 is post-tag.
Comment 3 Larry the Git Cow gentoo-dev 2023-01-28 05:11:03 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=f7a47b020609f8fedaa6286396c94dcbe45ae966

commit f7a47b020609f8fedaa6286396c94dcbe45ae966
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2023-01-28 04:03:04 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2023-01-28 05:10:52 +0000

    games-action/supertuxkart: make vulkan unconditional for now
    
    Fixed in next release upstream.
    
    Closes: https://bugs.gentoo.org/892165
    Signed-off-by: Sam James <sam@gentoo.org>

 games-action/supertuxkart/metadata.xml                        |  1 -
 .../{supertuxkart-1.4.ebuild => supertuxkart-1.4-r1.ebuild}   | 11 ++++++-----
 2 files changed, 6 insertions(+), 6 deletions(-)