Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 891533 - sys-devel/dev86: error: a function definition without a prototype is deprecated in all versions of C and is not supported in C2x
Summary: sys-devel/dev86: error: a function definition without a prototype is deprecat...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: No maintainer - Look at https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers if you want to take care of it
URL: https://codeberg.org/jbruchon/dev86/i...
Whiteboard:
Keywords: PATCH
Depends on:
Blocks: c23-porting gcc-14-stable
  Show dependency tree
 
Reported: 2023-01-21 06:49 UTC by Peter Levine
Modified: 2025-02-07 23:52 UTC (History)
4 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
dev86-clang16.patch (dev86-clang16.patch,126.77 KB, patch)
2023-02-11 04:57 UTC, Peter Levine
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Peter Levine 2023-01-21 06:49:58 UTC
Building with sys-devel/clang-16.0.0_pre20230107 fails with:

> ifdef.c:63:1: error: a function definition without a prototype is deprecated in all versions of C and is not supported in
>       C2x [-Werror,-Wdeprecated-non-prototype]
> main(argc, argv)
> ^
> ifdef.c:109:6: error: a function definition without a prototype is deprecated in all versions of C and is not supported
>       in C2x [-Werror,-Wdeprecated-non-prototype]
> void Usage(prog)
>      ^
> ifdef.c:129:1: error: a function definition without a prototype is deprecated in all versions of C and is not supported
>       in C2x [-Werror,-Wdeprecated-non-prototype]
> save_name(varname, state)
> ^
> ifdef.c:155:1: error: a function definition without a prototype is deprecated in all versions of C and is not supported
>       in C2x [-Werror,-Wdeprecated-non-prototype]
> do_file(fname)
> ^
> ifdef.c:195:1: error: a function definition without a prototype is deprecated in all versions of C and is not supported
>       in C2x [-Werror,-Wdeprecated-non-prototype]
> set_line(lineno)
> ^
> ifdef.c:256:1: error: a function definition without a prototype is deprecated in all versions of C and is not supported
>       in C2x [-Werror,-Wdeprecated-non-prototype]
> do_ifdef(p, which)
> ^
> ifdef.c:373:1: error: a function definition without a prototype is deprecated in all versions of C and is not supported
>       in C2x [-Werror,-Wdeprecated-non-prototype]
> check_name(nm)
> ^
> ifdef.c:399:1: error: a function definition without a prototype is deprecated in all versions of C and is not supported
>       in C2x [-Werror,-Wdeprecated-non-prototype]
> fatal(msg)
> ^
> 8 errors generated.
Comment 1 Jonas Stein gentoo-dev 2023-01-21 23:07:56 UTC
this should be reported upstream with a patch. There are forks which are still maintained and who likely will merge it.
Comment 2 Peter Levine 2023-01-22 02:28:30 UTC
(In reply to Jonas Stein from comment #1)
> this should be reported upstream with a patch. There are forks which are
> still maintained and who likely will merge it.

I'm working on several bugs for this package, including this one.

The list of forks: https://techgaun.github.io/active-forks/index.html#lkundrak/dev86

I assume the jbruchon fork would be the best choice.
Comment 3 Peter Levine 2023-02-11 04:57:20 UTC
Created attachment 850368 [details, diff]
dev86-clang16.patch

I started this with the best of intentions but I don't think I can devote much more time to this.  Aside from the clang-16 issues, there were a number of bcc runtime parsing errors that I'm not inclined to debug. I've attached the clang-16 fixes if anyone wants to continue.
Comment 4 NHO 2024-04-02 11:49:19 UTC
Waiting for new release upstream
https://codeberg.org/jbruchon/dev86/issues/1
Comment 5 Andreas K. Hüttel archtester gentoo-dev 2024-10-22 13:34:06 UTC
Technically not a c99 issue.
Comment 6 NHO 2024-12-10 17:46:30 UTC
Need version bump, upstream just updated.
Comment 7 Larry the Git Cow gentoo-dev 2025-02-07 23:52:11 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=a4da4b4af030eac0ab3c1f1bcf1dc12483da42b1

commit a4da4b4af030eac0ab3c1f1bcf1dc12483da42b1
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2025-02-07 23:51:33 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2025-02-07 23:51:49 +0000

    sys-devel/dev86: build 0.16.21-r3 with -std=gnu89
    
    And we'll try do better in the newer version.
    
    Closes: https://bugs.gentoo.org/757675
    Closes: https://bugs.gentoo.org/891533
    Closes: https://bugs.gentoo.org/920450
    Signed-off-by: Sam James <sam@gentoo.org>

 sys-devel/dev86/dev86-0.16.21-r3.ebuild | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

Additionally, it has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=297c2d0cdc7628da67adb795f4c0f8fae5780f06

commit 297c2d0cdc7628da67adb795f4c0f8fae5780f06
Author:     Z. Liu <zhixu.liu@gmail.com>
AuthorDate: 2025-01-22 13:50:39 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2025-02-07 23:51:49 +0000

    sys-devel/dev86: bump to v1.0.1
    
    use "-std=c89" as workaround
    
    Bug: https://bugs.gentoo.org/757675
    Bug: https://bugs.gentoo.org/891533
    Bug: https://bugs.gentoo.org/920450
    Closes: https://bugs.gentoo.org/699812
    Signed-off-by: Z. Liu <zhixu.liu@gmail.com>
    Closes: https://github.com/gentoo/gentoo/pull/40267
    Signed-off-by: Sam James <sam@gentoo.org>

 sys-devel/dev86/Manifest                         |  1 +
 sys-devel/dev86/dev86-1.0.1.ebuild               | 69 ++++++++++++++++++++++++
 sys-devel/dev86/files/dev86-1.0.1-makefile.patch | 66 +++++++++++++++++++++++
 sys-devel/dev86/metadata.xml                     |  1 +
 4 files changed, 137 insertions(+)