Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 891381 - sys-kernel/linux-firmware: Simplify LICENSE
Summary: sys-kernel/linux-firmware: Simplify LICENSE
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Chí-Thanh Christopher Nguyễn
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-01-19 10:06 UTC by Ulrich Müller
Modified: 2023-01-21 16:54 UTC (History)
5 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
licenses: Add note about binary-only images to linux-fw-redistributable (0001-licenses-Add-note-about-binary-only-images-to-linux-.patch,1.17 KB, patch)
2023-01-19 10:08 UTC, Ulrich Müller
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ulrich Müller gentoo-dev 2023-01-19 10:06:41 UTC
As discussed in #gentoo-dev:

linux-firmware currently has:

LICENSE="GPL-2 GPL-2+ GPL-3 BSD MIT || ( MPL-1.1 GPL-2 )
    redistributable? (
        linux-fw-redistributable ( BSD-2 BSD BSD-4 ISC MIT no-source-code ) )
    unknown-license? ( all-rights-reserved )"

With the redistributable flag being enabled by an IUSE default, the user must add an exception for both "linux-fw-redistributable" and "no-source-code" to package.license.

The suggestion is to simplify this, namely by dropping no-source-code from LICENSE and adding a note to licenses/linux-fw-redistributable instead. That is, the ebuild would have:

LICENSE="GPL-2 GPL-2+ GPL-3 BSD MIT || ( MPL-1.1 GPL-2 )
    redistributable? ( linux-fw-redistributable BSD-2 BSD BSD-4 ISC MIT )
    unknown-license? ( all-rights-reserved )"
Comment 1 Ulrich Müller gentoo-dev 2023-01-19 10:08:05 UTC
Created attachment 848821 [details, diff]
licenses: Add note about binary-only images to linux-fw-redistributable
Comment 2 Mike Pagano gentoo-dev 2023-01-21 13:17:06 UTC
LGTM
Comment 3 Larry the Git Cow gentoo-dev 2023-01-21 16:54:19 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=199e4bde07788a60b18c0cd10dde492955d0ba6c

commit 199e4bde07788a60b18c0cd10dde492955d0ba6c
Author:     Ulrich Müller <ulm@gentoo.org>
AuthorDate: 2023-01-21 16:48:32 +0000
Commit:     Ulrich Müller <ulm@gentoo.org>
CommitDate: 2023-01-21 16:54:12 +0000

    sys-kernel/linux-firmware: Simplify LICENSE
    
    Drop no-source-code from LICENSE and add a note to the
    linux-fw-redistributable license file instead. This means that the user
    must only add a single license exception for the package when using the
    default configuration ("+redistributable" in IUSE).
    
    Closes: https://bugs.gentoo.org/891381
    Signed-off-by: Ulrich Müller <ulm@gentoo.org>

 sys-kernel/linux-firmware/linux-firmware-20220209.ebuild    | 5 ++---
 sys-kernel/linux-firmware/linux-firmware-20220310.ebuild    | 5 ++---
 sys-kernel/linux-firmware/linux-firmware-20220411.ebuild    | 5 ++---
 sys-kernel/linux-firmware/linux-firmware-20220509.ebuild    | 5 ++---
 sys-kernel/linux-firmware/linux-firmware-20220610.ebuild    | 5 ++---
 sys-kernel/linux-firmware/linux-firmware-20220708.ebuild    | 5 ++---
 sys-kernel/linux-firmware/linux-firmware-20220815.ebuild    | 5 ++---
 sys-kernel/linux-firmware/linux-firmware-20220913-r2.ebuild | 5 ++---
 sys-kernel/linux-firmware/linux-firmware-20221012-r1.ebuild | 5 ++---
 sys-kernel/linux-firmware/linux-firmware-20221012.ebuild    | 5 ++---
 sys-kernel/linux-firmware/linux-firmware-20221109.ebuild    | 5 ++---
 sys-kernel/linux-firmware/linux-firmware-20221214.ebuild    | 5 ++---
 sys-kernel/linux-firmware/linux-firmware-20230117.ebuild    | 3 +--
 sys-kernel/linux-firmware/linux-firmware-99999999.ebuild    | 5 ++---
 14 files changed, 27 insertions(+), 41 deletions(-)

Additionally, it has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=da0574c5b5db9bd2077203048727da6e6b029bec

commit da0574c5b5db9bd2077203048727da6e6b029bec
Author:     Ulrich Müller <ulm@gentoo.org>
AuthorDate: 2023-01-19 10:04:46 +0000
Commit:     Ulrich Müller <ulm@gentoo.org>
CommitDate: 2023-01-21 16:54:11 +0000

    licenses: Add note about binary-only images to linux-fw-redistributable
    
    Bug: https://bugs.gentoo.org/891381
    Signed-off-by: Ulrich Müller <ulm@gentoo.org>

 licenses/linux-fw-redistributable | 4 ++++
 1 file changed, 4 insertions(+)