Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 890959 - x11-themes/mate-themes: last-rites now x11-themes/mate-themes-meta is gone?
Summary: x11-themes/mate-themes: last-rites now x11-themes/mate-themes-meta is gone?
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: No maintainer - Look at https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers if you want to take care of it
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks:
 
Reported: 2023-01-15 15:44 UTC by Sam James
Modified: 2024-01-01 20:35 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Sam James archtester Gentoo Infrastructure gentoo-dev Security 2023-01-15 15:44:19 UTC
From #gentoo-dev:
<@ulm> sam_: had you seen my question in the -dev ML about mate-themes{,-meta}?
<@ulm> basically, mate-themes-meta was dropped as a dependency of mate[themes], so x11-themes/mate-themes won't be pulled in any more
<@ulm> which made me wonder if mate-themes is obsolete

See also https://archives.gentoo.org/gentoo-dev/message/c18fb748b01ced7c2f15562b2b49f9a9.

Do we need x11-themes/mate-themes still? Should it be an optfeature on another package, or something else?

I'm not saying we need to get rid of it - just wondering if it's useful still.
Comment 1 Larry the Git Cow gentoo-dev 2023-12-22 06:46:36 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=b9a78c55c371d9ece05d4fda4996c4fb5d1cb282

commit b9a78c55c371d9ece05d4fda4996c4fb5d1cb282
Author:     Ian Jordan <immoloism@gmail.com>
AuthorDate: 2023-12-22 02:23:45 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2023-12-22 06:42:42 +0000

    x11-themes/mate-themes: update theme pack
    
    Closes: https://bugs.gentoo.org/890959
    Signed-off-by: Ian Jordan <immoloism@gmail.com>
    Signed-off-by: Sam James <sam@gentoo.org>

 x11-themes/mate-themes/Manifest                    |  3 +-
 x11-themes/mate-themes/mate-themes-3.22.21.ebuild  | 37 ----------------------
 ...s-3.22.22.ebuild => mate-themes-3.22.24.ebuild} |  6 ++--
 3 files changed, 3 insertions(+), 43 deletions(-)
Comment 2 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2023-12-22 06:49:57 UTC
immolo, nothing depends on x11-themes/mate-themes now (has been the case for a while, see original comment) - is that intentional?

mate-base/mate's USE=themes does not pull in mate-themes. Perhaps it should?
Comment 3 immolo 2023-12-22 08:45:12 UTC
You are right, I confused two packages is what happened here with -meta part of the bug.

Upstream still support this package so we should too is my view.

I agree we should pull this in with +themes as I think it's reasonable to assume it would pull this in as well.

Revbump incoming for a real fix to the bug.
Comment 4 Larry the Git Cow gentoo-dev 2024-01-01 20:35:20 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=2510dd9a715d53dfd0500fad29567c8d2fe6694f

commit 2510dd9a715d53dfd0500fad29567c8d2fe6694f
Author:     Ian Jordan <immoloism@gmail.com>
AuthorDate: 2023-12-22 09:16:41 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2024-01-01 20:34:22 +0000

    mate-base/mate: +theme depends on x11-themes/mate-themes
    
    As per bug, it is reasonable to assume that +themes would pull x11-themes/mate-themes in the meta package.
    
    Closes: https://bugs.gentoo.org/890959
    Signed-off-by: Ian Jordan <immoloism@gmail.com>
    Closes: https://github.com/gentoo/gentoo/pull/34413
    Signed-off-by: Sam James <sam@gentoo.org>

 mate-base/mate/mate-1.26.0-r1.ebuild | 83 +++++++++++++++++++++++++++++++++++
 mate-base/mate/mate-1.27.0-r1.ebuild | 85 ++++++++++++++++++++++++++++++++++++
 2 files changed, 168 insertions(+)