Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 890672 - dev-util/bpftrace: Make systemtap support optional via IUSE
Summary: dev-util/bpftrace: Make systemtap support optional via IUSE
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Patrick McLean
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-01-13 12:59 UTC by Rafael Ristovski
Modified: 2023-01-26 18:57 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Rafael Ristovski 2023-01-13 12:59:46 UTC
Right now, dev-util/bpftrace has an explicit dev-util/systemtap RDEPEND even though bpftrace itself can be built without systemtap support as can be seen by looking at the code: https://github.com/search?q=repo%3Aiovisor%2Fbpftrace%20HAVE_SYSTEMTAP_SYS_SDT_H&type=code

It would be optimal if systemtap support was optional through IUSE instead

Reproducible: Always
Comment 1 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2023-01-13 19:31:56 UTC
  1 commit 076a7638d504bd9e5d1ca454f71ff79394e02196
  2 Author: Patrick McLean <chutzpah@gentoo.org>
  3 Date:   Fri Jan 13 10:39:55 2023 -0800
  4
  5     dev-util/bpftrace: Revbump, add ~ keywords, drop systemtap dep
  6
  7     Signed-off-by: Patrick McLean <chutzpah@gentoo.org>
Comment 2 Holger Hoffstätte 2023-01-13 20:12:23 UTC
...
>>> Installing (5 of 5) dev-util/bpftrace-0.16.0-r1::gentoo
>>> Jobs: 5 of 5 complete                           Load avg: 4.17, 2.27, 1.09
 * After world updates, it is important to remove obsolete packages with
 * emerge --depclean. Refer to `man emerge` for more information.
..
$sudo bpftrace -e 'tracepoint:raw_syscalls:sys_enter { @[comm] = count(); }'
bpftrace: /usr/lib/llvm/15/include/llvm/IR/Type.h:389: llvm::Type* llvm::Type::getNonOpaquePointerElementType() const: Assertion `NumContainedTys && "Attempting to get element type of opaque pointer"' failed.
zsh: IOT instruction  bpftrace -e 'tracepoint:raw_syscalls:sys_enter { @[comm] = count(); }'

You will have to apply the opaque-pointer fixes to make 0.16.0 work or wait
for the next release.
Comment 3 Larry the Git Cow gentoo-dev 2023-01-26 18:57:21 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=1d68a256d8d1ee428ce51403bb5d2b443ad29a19

commit 1d68a256d8d1ee428ce51403bb5d2b443ad29a19
Author:     Patrick McLean <chutzpah@gentoo.org>
AuthorDate: 2023-01-26 18:56:42 +0000
Commit:     Patrick McLean <chutzpah@gentoo.org>
CommitDate: 2023-01-26 18:56:42 +0000

    dev-util/bpftrace: Pull in OpaquePointer fix for 0.16 (bug #890672)
    
    Closes: https://bugs.gentoo.org/890672
    Signed-off-by: Patrick McLean <chutzpah@gentoo.org>

 dev-util/bpftrace/bpftrace-0.16.0-r2.ebuild        |  93 +++++
 .../files/bpftrace-0.16.0-opaquepointer.patch      | 450 +++++++++++++++++++++
 2 files changed, 543 insertions(+)