Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 890340 - xfce-base/libxfce4windowing revdeps: rekeyword
Summary: xfce-base/libxfce4windowing revdeps: rekeyword
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Keywording (show other bugs)
Hardware: All Linux
: Normal enhancement (vote)
Assignee: XFCE Team
URL:
Whiteboard:
Keywords: CC-ARCHES, PullRequest
Depends on:
Blocks:
 
Reported: 2023-01-10 13:00 UTC by Michał Górny
Modified: 2023-12-30 01:33 UTC (History)
3 users (show)

See Also:
Package list:
<xfce-base/xfdesktop-4.19.1 alpha arm arm64 hppa ia64 loong mips ppc ppc64 riscv sparc x86 xfce-base/xfce4-panel alpha arm arm64 hppa ia64 loong mips ppc ppc64 riscv sparc x86 gui-libs/gtk-layer-shell alpha arm arm64 hppa ia64 loong mips ppc ppc64 riscv sparc x86 xfce-base/libxfce4windowing alpha arm arm64 hppa ia64 loong mips ppc ppc64 riscv sparc x86 xfce-extra/xfce4-pulseaudio-plugin alpha arm64 ppc ppc64 x11-terms/xfce4-terminal xfce-base/xfce4-settings sparc
Runtime testing required: ---
nattka: sanity-check+

Attachments
build log for USE="-x -wayland" xfce-base/xfdesktop-4.19.0 (build.log,19.15 KB, application/octet-stream)
2023-01-11 06:30 UTC, jinqiang zhang 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2023-01-10 13:00:16 UTC 
Please restore keywords.
Comment 1 Joonas Niilola gentoo-dev 2023-01-11 06:27:46 UTC 
x86 done
Comment 2 jinqiang zhang 2023-01-11 06:30:07 UTC 
Created attachment 848191 [details]
build log for USE="-x -wayland" xfce-base/xfdesktop-4.19.0
Comment 3 jinqiang zhang 2023-01-11 06:30:59 UTC 
In rsicv (and probably on all architectures), xfce-base/xfdesktop-4.19.0 compiles with errors when USE="-X -wayland", which causes test failures and other USE errors.

configure: error: Either both X11 and Wayland support was disabled, or required dependencies are missing. One of the two must be enabled.


I didn't add X or Wayland to the global USE in my test environment, but I think xfce users will add one of them. So should I add it in the test environment, or the maintainer to modify the ebuild?

And xfce-base/libxfce4windowing-4.19.1 looks good.

emerge -qpvO xfce-base/xfdesktop
[ebuild R] xfce-base/xfdesktop-4.19.0 USE="thunar -X -libnotify -wayland"

 FEATURES=' test' failed for =xfce-base/xfdesktop-4.19.0
USE='-X -libnotify -thunar -wayland' failed for =xfce-base/xfdesktop-4.19.0
USE='X -libnotify -thunar -wayland' succeeded for =xfce-base/xfdesktop-4.19.0
USE='-X libnotify -thunar -wayland' failed for =xfce-base/xfdesktop-4.19.0
USE='-X -libnotify thunar -wayland' failed for =xfce-base/xfdesktop-4.19.0
USE='X -libnotify thunar -wayland' succeeded for =xfce-base/xfdesktop-4.19.0
USE='-X libnotify thunar -wayland' failed for =xfce-base/xfdesktop-4.19.0
USE='X libnotify thunar -wayland' succeeded for =xfce-base/xfdesktop-4.19.0
USE='X -libnotify -thunar wayland' succeeded for =xfce-base/xfdesktop-4.19.0
USE='-X libnotify -thunar wayland' succeeded for =xfce-base/xfdesktop-4.19.0
USE='X libnotify -thunar wayland' succeeded for =xfce-base/xfdesktop-4.19.0
USE='-X -libnotify thunar wayland' succeeded for =xfce-base/xfdesktop-4.19.0
USE='X -libnotify thunar wayland' succeeded for =xfce-base/xfdesktop-4.19.0

FEATURES=' test' USE='' succeeded for =xfce-base/libxfce4windowing-4.19.1
USE='-X -introspection -wayland' succeeded for =xfce-base/libxfce4windowing-4.19.1
USE='X -introspection -wayland' succeeded for =xfce-base/libxfce4windowing-4.19.1
USE='-X introspection -wayland' succeeded for =xfce-base/libxfce4windowing-4.19.1
USE='X introspection -wayland' succeeded for =xfce-base/libxfce4windowing-4.19.1
USE='-X -introspection wayland' succeeded for =xfce-base/libxfce4windowing-4.19.1
USE='X -introspection wayland' succeeded for =xfce-base/libxfce4windowing-4.19.1
USE='-X introspection wayland' succeeded for =xfce-base/libxfce4windowing-4.19.1
USE='X introspection wayland' succeeded for =xfce-base/libxfce4windowing-4.19.1
Comment 4 Joonas Niilola gentoo-dev 2023-01-11 06:31:55 UTC 
(In reply to jinqiang zhang from comment #2)
> Created attachment 848191 [details]
> build log for USE="-x -wayland" xfce-base/xfdesktop-4.19.0

I can guess what this is about, I made a new bug about it:
bug #890437

No one would be running a desktop without X or wayland so it's just a tinderbox bug and not a blocker here :)
Comment 5 Joonas Niilola gentoo-dev 2023-01-11 06:37:08 UTC 
(In reply to jinqiang zhang from comment #3)
> 
> And xfce-base/libxfce4windowing-4.19.1 looks good.
> 
> emerge -qpvO xfce-base/xfdesktop
> [ebuild R] xfce-base/xfdesktop-4.19.0 USE="thunar -X -libnotify -wayland"
> 

How was xfce4-panel? It doesn't seem to be keyworded for riscv yet. Do you use nattka to get a local package list to be tested?
Comment 6 jinqiang zhang 2023-01-11 06:44:49 UTC 
(In reply to Joonas Niilola from comment #4)
> (In reply to jinqiang zhang from comment #2)
> > Created attachment 848191 [details]
> > build log for USE="-x -wayland" xfce-base/xfdesktop-4.19.0
> 
> I can guess what this is about, I made a new bug about it:
> bug #890437
> 
> No one would be running a desktop without X or wayland so it's just a
> tinderbox bug and not a blocker here :)

Yes, I also don't think there will be a block here, it's just a little confusing.

(In reply to Joonas Niilola from comment #5)
> (In reply to jinqiang zhang from comment #3)
> > 
> > And xfce-base/libxfce4windowing-4.19.1 looks good.
> > 
> > emerge -qpvO xfce-base/xfdesktop
> > [ebuild R] xfce-base/xfdesktop-4.19.0 USE="thunar -X -libnotify -wayland"
> > 
> 
> How was xfce4-panel? It doesn't seem to be keyworded for riscv yet. Do you
> use nattka to get a local package list to be tested?

Thanks, xfce4-panel is still testing use flags and no bugs have been encountered yet. The compilation on riscv is slow, I just want to report the problem of xfdesktop first. Will post the test results of xfce4-panel later.
Comment 7 jinqiang zhang 2023-01-11 08:27:22 UTC 
xfce-base/xfce4-panel-4.19.0 looks good on ~riscv.

USE tests started on Wed Jan 11 06:20:09 -00 2023

FEATURES=' test' USE='' succeeded for =xfce-base/xfce4-panel-4.19.0
USE='-X -dbusmenu -introspection -vala -wayland' succeeded for =xfce-base/xfce4-panel-4.19.0
USE='-X dbusmenu -introspection -vala -wayland' succeeded for =xfce-base/xfce4-panel-4.19.0
USE='X dbusmenu -introspection -vala -wayland' succeeded for =xfce-base/xfce4-panel-4.19.0
USE='-X -dbusmenu introspection -vala -wayland' succeeded for =xfce-base/xfce4-panel-4.19.0
USE='X -dbusmenu introspection -vala -wayland' succeeded for =xfce-base/xfce4-panel-4.19.0
USE='-X -dbusmenu introspection vala -wayland' succeeded for =xfce-base/xfce4-panel-4.19.0
USE='X -dbusmenu introspection vala -wayland' succeeded for =xfce-base/xfce4-panel-4.19.0
USE='-X -dbusmenu -introspection -vala wayland' succeeded for =xfce-base/xfce4-panel-4.19.0
USE='-X dbusmenu -introspection -vala wayland' succeeded for =xfce-base/xfce4-panel-4.19.0
USE='X dbusmenu -introspection -vala wayland' succeeded for =xfce-base/xfce4-panel-4.19.0
USE='X -dbusmenu introspection vala wayland' succeeded for =xfce-base/xfce4-panel-4.19.0
USE='X dbusmenu introspection vala wayland' succeeded for =xfce-base/xfce4-panel-4.19.0
Comment 8 Joonas Niilola gentoo-dev 2023-01-11 08:55:36 UTC 
riscv done
Comment 9 Arthur Zamarin archtester Gentoo Infrastructure gentoo-dev Security 2023-01-13 11:51:03 UTC 
ia64 done
Comment 10 Arthur Zamarin archtester Gentoo Infrastructure gentoo-dev Security 2023-01-13 14:19:51 UTC 
ppc done
Comment 11 Arthur Zamarin archtester Gentoo Infrastructure gentoo-dev Security 2023-01-14 10:00:22 UTC 
hppa done
Comment 12 WANG Xuerui gentoo-dev 2023-01-25 15:50:30 UTC 
loong done
Comment 13 Arthur Zamarin archtester Gentoo Infrastructure gentoo-dev Security 2023-02-24 17:11:51 UTC 
arm done
Comment 14 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2023-04-14 04:03:19 UTC 
arm64 done
Comment 15 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2023-04-14 20:49:37 UTC 
ppc64 done
Comment 16 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2023-06-01 14:40:04 UTC 
Ping.
Comment 17 NATTkA bot gentoo-dev 2023-11-25 11:04:41 UTC Comment hidden (obsolete)
Comment 18 NATTkA bot gentoo-dev 2023-11-25 11:20:36 UTC 
All sanity-check issues have been resolved
Comment 19 matoro archtester 2023-12-10 20:16:32 UTC 
x11-terms/xfce4-terminal also needs to enforce REQUIRED_USE="|| ( X wayland )"
Comment 20 Larry the Git Cow gentoo-dev 2023-12-16 03:06:24 UTC 
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=948851cd16df528dfb38b08fcc3ae47fc9bc750f

commit 948851cd16df528dfb38b08fcc3ae47fc9bc750f
Author:     Matoro Mahri <matoro_gentoo@matoro.tk>
AuthorDate: 2023-12-15 19:55:28 +0000
Commit:     Michał Górny <mgorny@gentoo.org>
CommitDate: 2023-12-16 03:06:21 +0000

    x11-terms/xfce4-terminal: add REQUIRED_USE for wayland/X
    
    Bug: https://bugs.gentoo.org/890340
    Signed-off-by: Matoro Mahri <matoro_gentoo@matoro.tk>
    Closes: https://github.com/gentoo/gentoo/pull/34298
    Signed-off-by: Michał Górny <mgorny@gentoo.org>

 x11-terms/xfce4-terminal/xfce4-terminal-1.1.1.ebuild | 1 +
 1 file changed, 1 insertion(+)
Comment 21 matoro archtester 2023-12-19 05:21:49 UTC 
mips done
Comment 22 matoro archtester 2023-12-22 05:15:35 UTC 
alpha done
Comment 23 matoro archtester 2023-12-30 01:33:23 UTC 
sparc done

all arches done