Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 890298 - media-sound/upmpdcli-1.5.20 - mv: cannot stat upmpdcli.conf-dist: No such file or directory
Summary: media-sound/upmpdcli-1.5.20 - mv: cannot stat upmpdcli.conf-dist: No such fil...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Erik Mackdanz
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-01-09 18:52 UTC by Toralf Förster
Modified: 2023-02-09 02:54 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
emerge-info.txt (emerge-info.txt,17.86 KB, text/plain)
2023-01-09 18:52 UTC, Toralf Förster
Details
emerge-history.txt (emerge-history.txt,200.63 KB, text/plain)
2023-01-09 18:52 UTC, Toralf Förster
Details
environment (environment,64.60 KB, text/plain)
2023-01-09 18:52 UTC, Toralf Förster
Details
etc.clang.tar.bz2 (etc.clang.tar.bz2,795 bytes, application/x-bzip)
2023-01-09 18:52 UTC, Toralf Förster
Details
etc.portage.tar.bz2 (etc.portage.tar.bz2,26.00 KB, application/x-bzip)
2023-01-09 18:52 UTC, Toralf Förster
Details
logs.tar.bz2 (logs.tar.bz2,6.68 KB, application/x-bzip)
2023-01-09 18:52 UTC, Toralf Förster
Details
media-sound:upmpdcli-1.5.20:20230109-131845.log (media-sound:upmpdcli-1.5.20:20230109-131845.log,28.81 KB, text/plain)
2023-01-09 18:52 UTC, Toralf Förster
Details
temp.tar.bz2 (temp.tar.bz2,19.34 KB, application/x-bzip)
2023-01-09 18:52 UTC, Toralf Förster
Details
Working install phase (upmpdcli-works.log,12.23 KB, text/x-log)
2023-01-15 21:13 UTC, Erik Mackdanz
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Toralf Förster gentoo-dev 2023-01-09 18:52:45 UTC
 /usr/sbin/mkdir -p '/var/tmp/portage/media-sound/upmpdcli-1.5.20/image/usr/bin'
  /usr/lib/portage/python3.10/ebuild-helpers/xattr/install -c upmpdcli scctl '/var/tmp/portage/media-sound/upmpdcli-1.5.20/image/usr/bin'
make  install-data-hook
make[2]: Entering directory '/var/tmp/portage/media-sound/upmpdcli-1.5.20/work/upmpdcli-1.5.20'
(cd /var/tmp/portage/media-sound/upmpdcli-1.5.20/image/etc; test -f upmpdcli.conf || \
	mv upmpdcli.conf-dist upmpdcli.conf; chmod 600 upmpdcli.conf)
mv: cannot stat 'upmpdcli.conf-dist': No such file or directory
chmod: cannot access 'upmpdcli.conf': No such file or directory
make[2]: *** [Makefile:2006: install-data-hook] Error 1 shuffle=3347390069

  -------------------------------------------------------------------

  This is an unstable amd64 chroot image at a tinderbox (==build bot)
  name: 23.0_systemd-j4-20230108-050029

  -------------------------------------------------------------------

GNUMAKEFLAGS="$GNUMAKEFLAGS --shuffle"
gcc-config -l:
 [1] x86_64-pc-linux-gnu-10
 [2] x86_64-pc-linux-gnu-12 *
clang/llvm (if any):
clang version 15.0.6
Target: x86_64-pc-linux-gnu
Thread model: posix
InstalledDir: /usr/lib/llvm/15/bin
Configuration file: /etc/clang/clang.cfg
/usr/lib/llvm/15
15.0.6
Python 3.10.9
Available Ruby profiles:
  [1]   ruby27 (with Rubygems)
  [2]   ruby30 (with Rubygems) *
The following VMs are available for generation-2:
1)	Eclipse Temurin JDK 11.0.17_p8 [openjdk-bin-11]
*)	Eclipse Temurin JDK 17.0.5_p8 [openjdk-bin-17]
3)	Eclipse Temurin JDK 8.352_p08 [openjdk-bin-8]
Available Java Virtual Machines:
  [1]   openjdk-bin-8 
  [2]   openjdk-bin-11 
  [3]   openjdk-bin-17  system-vm

php cli (if any):

  HEAD of ::gentoo
commit 06f63dfdf7c8b489bc24da0080970da9509eeff2
Author: Repository mirror & CI <repomirrorci@gentoo.org>
Date:   Mon Jan 9 12:17:08 2023 +0000

    2023-01-09 12:17:07 UTC

emerge -qpvO media-sound/upmpdcli
[ebuild  N    ] media-sound/upmpdcli-1.5.20  USE="-thirdparty"
Comment 1 Toralf Förster gentoo-dev 2023-01-09 18:52:46 UTC
Created attachment 848029 [details]
emerge-info.txt
Comment 2 Toralf Förster gentoo-dev 2023-01-09 18:52:47 UTC
Created attachment 848030 [details]
emerge-history.txt
Comment 3 Toralf Förster gentoo-dev 2023-01-09 18:52:49 UTC
Created attachment 848031 [details]
environment
Comment 4 Toralf Förster gentoo-dev 2023-01-09 18:52:49 UTC
Created attachment 848032 [details]
etc.clang.tar.bz2
Comment 5 Toralf Förster gentoo-dev 2023-01-09 18:52:51 UTC
Created attachment 848033 [details]
etc.portage.tar.bz2
Comment 6 Toralf Förster gentoo-dev 2023-01-09 18:52:52 UTC
Created attachment 848034 [details]
logs.tar.bz2
Comment 7 Toralf Förster gentoo-dev 2023-01-09 18:52:53 UTC
Created attachment 848035 [details]
media-sound:upmpdcli-1.5.20:20230109-131845.log
Comment 8 Toralf Förster gentoo-dev 2023-01-09 18:52:54 UTC
Created attachment 848036 [details]
temp.tar.bz2
Comment 9 Erik Mackdanz gentoo-dev 2023-01-15 21:13:13 UTC
Created attachment 848625 [details]
Working install phase

I'm failing to reproduce this, or to see how it could happen.

It looks like upmpdcli.conf-dist wasn't installed to the image (install-dist_sysconfDATA make target via install-exec-am make target via install-am make target via install make target) before the mv command (install-data-hook make target via install-data-am target via install-am make target via install make target).

It feels like there was a race condition between these two operations but they are ordered determinstically by the install-am target.  My setup that can't reproduce it is parallel (-j9).

I'll come back to look at this another time but right now I'm stuck.
Comment 10 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2023-01-15 21:15:52 UTC
(In reply to Erik Mackdanz from comment #9)

> It feels like there was a race condition between these two operations but
> they are ordered determinstically by the install-am target.  My setup that
> can't reproduce it is parallel (-j9).
> 

Try with make --shuffle=3347390069?
Comment 11 Erik Mackdanz gentoo-dev 2023-02-07 02:30:13 UTC
Thanks for the pointer, Sam.

I still fail to reproduce it even when I replicate exactly the install command:
make -j4 --shuffle=3347390069 DESTDIR=/var/tmp/portage/media-sound/upmpdcli-1.5.20/image install

...and identical USE and FEATURES:
USE:        abi_x86_64 amd64 elibc_glibc kernel_linux userland_GNU
FEATURES:   network-sandbox preserve-libs sandbox userpriv usersandbox

The build succeeds.  Still stuck and unlikely to spend more time on it.
Comment 12 Erik Mackdanz gentoo-dev 2023-02-07 15:27:07 UTC
I set --shuffle=random and ran the install stage repeatedly.  I reproduced the error on the 26th try.  I'll try to patch the Makefile and then call it fixed if it runs 50-80 times without error.
Comment 13 Larry the Git Cow gentoo-dev 2023-02-09 02:54:23 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=73f7abb9421ae66329a0f82a2b00962356252684

commit 73f7abb9421ae66329a0f82a2b00962356252684
Author:     Erik Mackdanz <stasibear@gentoo.org>
AuthorDate: 2023-02-09 02:37:32 +0000
Commit:     Erik Mackdanz <stasibear@gentoo.org>
CommitDate: 2023-02-09 02:54:08 +0000

    media-sound/upmpdcli: fix race in 'make install'
    
    Closes: https://bugs.gentoo.org/890298
    Signed-off-by: Erik Mackdanz <stasibear@gentoo.org>

 media-sound/upmpdcli/files/makefile.patch   | 22 ++++++++++++++++++++++
 media-sound/upmpdcli/upmpdcli-1.5.20.ebuild | 11 ++++++++++-
 media-sound/upmpdcli/upmpdcli-1.6.3.ebuild  | 11 ++++++++++-
 3 files changed, 42 insertions(+), 2 deletions(-)