Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 889714 - [guru] www-client/woob-3.1 fails to compile: Package installs tests package which is forbidden and likely a bug in the build system
Summary: [guru] www-client/woob-3.1 fails to compile: Package installs tests package w...
Status: RESOLVED PKGREMOVED
Alias: None
Product: GURU
Classification: Unclassified
Component: Package issues (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: GURU project
URL:
Whiteboard:
Keywords: PMASKED
Depends on:
Blocks:
 
Reported: 2023-01-04 14:49 UTC by Agostino Sarubbo
Modified: 2024-07-18 13:18 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log (build.log,304.64 KB, text/plain)
2023-01-04 14:49 UTC, Agostino Sarubbo
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Agostino Sarubbo gentoo-dev 2023-01-04 14:49:11 UTC
https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: www-client/woob-3.1 fails to compile.
Discovered on: amd64 (internal ref: guru_ci)
Comment 1 Agostino Sarubbo gentoo-dev 2023-01-04 14:49:13 UTC
Created attachment 847224 [details]
build.log

build log and emerge --info
Comment 2 Jack 2023-12-01 16:04:15 UTC
Still present with woob-3.1-r1 and python 3.11
Comment 3 Jack 2023-12-05 18:28:52 UTC
Is there any easy (i.e., quick and dirty) patch possible, prior to a correct fix?  I had thought removing whatever was incorrectly being installed would avoid the error.  I don't know if I'm looking in the wrong place, because the error changed a bit from 3.1 to 3.1-r1.  I've been trying various "rm ..." in various of the ebuild functions, but can't seem to prevent the error.
Comment 4 Eli Schwartz gentoo-dev 2023-12-06 00:19:36 UTC
Upstream seems to have tagged a 3.6 version, which fixes this.

In 3.1: https://gitlab.com/woob/woob/-/blob/3.1/setup.py#L32

Notice that find_packages() grabs everything other than "modules/".

In 3.6: https://gitlab.com/woob/woob/-/blob/3.6/pyproject.toml#L4

Notice that it's only finding a specific 3 patterns, now.
Comment 5 Jack 2023-12-06 21:45:39 UTC
That was non-trivial, but maybe just because I'm not used to writing ebuilds for python based packages.  

Adding SETUPTOOLD_USE_DISTUTILE=local and removing the src_prepare to the ebuild and patching pyobject.toml to add [build-system] as the first line and to remove the two lines removed by the sed in src_prepare, I get a clean emerge, but woob fails with "ModuleNotFoundError: No module named 'woob_applications'."  

I'll keep working on it, but I probably don't know enough Python to figure out what I'm missing or what else needs patching.
Comment 6 Jack 2023-12-06 22:57:34 UTC
dev-python/rich needs to be added to deps, and the first thing you need to do is run "woob update" then things seem OK.  dev-pythong/pytest is needed for enabling tests, all of which pass except one which I think fails only because network access is disabled in sandbox.
Comment 7 Larry the Git Cow gentoo-dev 2024-05-31 08:55:27 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/proj/guru.git/commit/?id=ca4c03d60b5e125b87c88443aa3f4eddc031b104

commit ca4c03d60b5e125b87c88443aa3f4eddc031b104
Author:     Haelwenn (lanodan) Monnier <contact@hacktivis.me>
AuthorDate: 2024-05-31 04:17:56 +0000
Commit:     Haelwenn (lanodan) Monnier <contact@hacktivis.me>
CommitDate: 2024-05-31 04:19:12 +0000

    www-client/woob: treeclean
    
    Haven't used it in more than a year and is several versions out of date.
    
    Closes: https://bugs.gentoo.org/889714
    Closes: https://bugs.gentoo.org/897772
    Closes: https://bugs.gentoo.org/931490
    Signed-off-by: Haelwenn (lanodan) Monnier <contact@hacktivis.me>

 www-client/woob/Manifest           |  1 -
 www-client/woob/metadata.xml       | 11 -------
 www-client/woob/woob-3.1-r1.ebuild | 63 --------------------------------------
 www-client/woob/woob-9999.ebuild   | 63 --------------------------------------
 4 files changed, 138 deletions(-)
Comment 8 Jack 2024-05-31 15:33:03 UTC
So the only version has been removed, but the bug not closed.  Does that mean there is a plan to add 3.6, or is this just being abandoned in Gentoo?  (I don't use it myself, but try to support it's potential use in KMyMoney.)
Comment 9 Viorel Munteanu gentoo-dev 2024-06-01 07:10:39 UTC
The remove has been reverted, now it is masked for 30 days and dropped to maintainer-needed.

So if you are interested in this package, you can consider taking it over.
Comment 10 Larry the Git Cow gentoo-dev 2024-07-17 08:40:18 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/proj/guru.git/commit/?id=c7cc6bf04ee978cf97a3567c3db58b961c80d699

commit c7cc6bf04ee978cf97a3567c3db58b961c80d699
Author:     Lucio Sauer <watermanpaint@posteo.net>
AuthorDate: 2024-07-17 01:47:55 +0000
Commit:     Lucio Sauer <watermanpaint@posteo.net>
CommitDate: 2024-07-17 01:47:55 +0000

    www-client/woob: treeclean
    
    Closes: https://bugs.gentoo.org/889714
    Closes: https://bugs.gentoo.org/931490
    Closes: https://bugs.gentoo.org/897772
    Signed-off-by: Lucio Sauer <watermanpaint@posteo.net>

 profiles/package.mask              |  9 ------
 www-client/woob/Manifest           |  1 -
 www-client/woob/metadata.xml       |  8 -----
 www-client/woob/woob-3.1-r1.ebuild | 63 --------------------------------------
 www-client/woob/woob-9999.ebuild   | 63 --------------------------------------
 5 files changed, 144 deletions(-)