After 3.3.3 some issues came up with 3.4.0 that are fixed now in 3.4.1. Tested locally by simply copying the current ebuild. No additional changes necessary. Reproducible: Always
https://github.com/gentoo/gentoo/pull/28930 – feasible?
Updated commit message.
Build errors reported[1] make[1]: Entering directory '/mnt/tmp/portage/dev-db/sqlitestudio-3.4.1/work/sqlitestudio-3.4.1/output/build/Plugins/ScriptingPython' x86_64-pc-linux-gnu-g++ -c -O2 -pipe -g2 -ggdb -march=znver2 -mno-3dnow -mno-rdrnd -mno-rdseed -msahf --param l1-cache-size=32 --param l1-cache-line-size=64 --param l2-cache-size=512 -mtune=znver2 -frecord-gcc-switches -Wno-cast-function-type -std=gnu++1z -Wall -Wextra -D_REENTRANT -fPIC -Dtests -DPROJECT_MODULE_NAME=ScriptingPython -DSCRIPTINGPYTHON_LIBRARY -DQT_NO_DEBUG -DQT_PLUGIN -DQT_CORE_LIB -I../../../../Plugins/ScriptingPython -I. -I../../../../SQLiteStudio3/coreSQLiteStudio -I../../../../SQLiteStudio3/coreSQLiteStudio -I../../../../Plugins -I/usr/include/qt5 -I/usr/include/qt5/QtCore -I../../../build -I/usr/lib64/qt5/mkspecs/linux-g++ -o ../../../build/scriptingpython.o ../../../../Plugins/ScriptingPython/scriptingpython.cpp x86_64-pc-linux-gnu-g++ -Wl,-O1 -Wl,--as-needed -Wl,--defsym=__gentoo_check_ldflags__=0 -shared -o libConfigMigration.so ../../../build/configmigration.o ../../../build/configmigrationwizard.o ../../../build/qrc_configmigration.o ../../../build/qrc_qmake_qmake_qm_files.o ../../../build/moc_configmigration.o ../../../build/moc_configmigrationwizard.o -L/mnt/tmp/portage/dev-db/sqlitestudio-3.4.1/work/sqlitestudio-3.4.1/SQLiteStudio3/../output/SQLiteStudio /usr/lib64/libQt5Widgets.so /usr/lib64/libQt5Gui.so /usr/lib64/libQt5Core.so -lGL -pthread In file included from ../../../../Plugins/ScriptingPython/scriptingpython.cpp:1: ../../../../Plugins/ScriptingPython/scriptingpython.h:4:10: fatal error: Python.h: No such file or directory 4 | #include <Python.h> | ^~~~~~~~~~ compilation terminated. make[1]: *** [Makefile:1081: ../../../build/scriptingpython.o] Error 1 make[1]: Leaving directory '/mnt/tmp/portage/dev-db/sqlitestudio-3.4.1/work/sqlitestudio-3.4.1/output/build/Plugins/ScriptingPython' make: *** [Makefile:364: sub-ScriptingPython-make_first] Error 2 This was added in 3.4.0. I plan to add python as USE flag and enable ScriptingPython conditionally. Regarding Bug#838325 I asked upstream[2] whether this is better solved there instead of ironing dependencies with sed in Qt project files. The trick with QMAKE_CFLAGS_ISYSTEM in src_configure() breaks parallel builds. With it quite often ld errors out with offset issues in .strtab. (invalid string offset <long> >= <small-int> for section `.strtab') The shipped compile.sh already uses make -j <cpu-count> and different attempts using it didn't show the same error. Couldn't test USE tcl yet to verify issues with stdlib.h. Any hints on that just in case? [1] https://github.com/gentoo/gentoo/pull/28930#issuecomment-1383119366 [2] https://github.com/pawelsalawa/sqlitestudio/issues/4660
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=1cdd81378ca0682a6dd00dd9181bba818d7b39bc commit 1cdd81378ca0682a6dd00dd9181bba818d7b39bc Author: Onkobu Tanaake <onkobu@onkobutanaake.de> AuthorDate: 2023-01-01 20:35:52 +0000 Commit: Viorel Munteanu <ceamac@gentoo.org> CommitDate: 2023-02-17 09:44:07 +0000 dev-db/sqlitestudio: bump 3.4.3 - drop unnecessary sed invocation - introduce USE python - ncurses fix is not necessary anymore, dependency was removed/ unnecessary - drop 3.2.1, source could not be downloaded anymore - add patch to fix linking of python - update manifest - Copyright - sed expression must fix all paths - delete test artifacts/ avoid installation Signed-off-by: Onkobu Tanaake <onkobu@onkobutanaake.de> Reported-by: Onkobu Tanaake <onkobu@onkobutanaake.de> Closes: https://github.com/gentoo/gentoo/pull/28930 Closes: https://bugs.gentoo.org/889314 Signed-off-by: Viorel Munteanu <ceamac@gentoo.org> dev-db/sqlitestudio/Manifest | 2 +- .../files/sqlitestudio-3.4.3-fix-python.patch | 13 ++++ ...o-3.2.1-r1.ebuild => sqlitestudio-3.4.3.ebuild} | 76 ++++++++++++++++------ 3 files changed, 71 insertions(+), 20 deletions(-)
