Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 889300 - sys-apps/portage: enable FEATURES=pkgdir-index-trusted by default
Summary: sys-apps/portage: enable FEATURES=pkgdir-index-trusted by default
Status: RESOLVED FIXED
Alias: None
Product: Portage Development
Classification: Unclassified
Component: Core - Configuration (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Portage team
URL:
Whiteboard:
Keywords: InVCS
Depends on: 912676
Blocks:
  Show dependency tree
 
Reported: 2023-01-01 18:14 UTC by John Helmert III
Modified: 2023-12-24 16:50 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description John Helmert III archtester Gentoo Infrastructure gentoo-dev Security 2023-01-01 18:14:36 UTC
Commit fbbe0cfe29020313ae44fb2a6afa87c2951ae028 indicates that the rationale for having this disabled is to tolerate manual additions/removals of binpkgs in the PKGDIR. I don't think there are many people doing this, so it should be safe to enable this by default for quicker operations with PKGDIR.
Comment 1 Ionen Wolkens gentoo-dev 2023-01-01 19:42:21 UTC
While I actually do this at times, I've always run `emaint --fix binhost` to update the index after while assuming it was needed (never really noticed this feature, and now would rather it be enabled, or at least for the machine using sshfs for this).

I'm under the impression most people update it as needed too, but who knows.
Comment 2 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2023-01-01 19:43:53 UTC
I've been doing the same as Ionen and feel the same too.
Comment 3 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2023-09-19 07:17:39 UTC
Removing bug 877241 from See Also per Zac's comment (https://github.com/gentoo/portage/pull/970#issuecomment-1723786580):
"""
This feature only affects the local index. Reindexing a remote index is not really feasible since we don't have a mechanism to fetch the remote package metadata unless we fetch the whole package. In lib/portage/getbinpkg.py there's an old implementation that fetched remote package metadata, but we should not support it anymore at this point (it only supported xpak format and it was very slow).
"""
Comment 4 Larry the Git Cow gentoo-dev 2023-09-19 07:18:47 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/proj/portage.git/commit/?id=3bc7bfef51d88fd716e882d3931f2873e3493e01

commit 3bc7bfef51d88fd716e882d3931f2873e3493e01
Author:     John Helmert III <ajak@gentoo.org>
AuthorDate: 2023-01-01 18:14:57 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2023-09-19 07:18:44 +0000

    make.globals: default-on FEATURES=pkgdir-index-trusted
    
    Commit fbbe0cfe29020313ae44fb2a6afa87c2951ae028 indicates that the rationale for having
    this disabled is to tolerate manual additions/removals of binpkgs in the PKGDIR.
    
    I don't think there are many people doing this, so it should be safe to enable
    this by default for quicker operations with PKGDIR.
    
    [sam: This is only used for local operations, we don't reindex remote indexes,
    so there's no issue with not having indexes be signed (although we do plan
    on doing that at some point).]
    
    Bug: https://bugs.gentoo.org/889300
    Signed-off-by: John Helmert III <ajak@gentoo.org>
    Closes: https://github.com/gentoo/portage/pull/970
    Signed-off-by: Sam James <sam@gentoo.org>

 NEWS             | 5 +++++
 cnf/make.globals | 2 +-
 2 files changed, 6 insertions(+), 1 deletion(-)
Comment 5 Larry the Git Cow gentoo-dev 2023-09-29 07:20:22 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/proj/gentoolkit.git/commit/?id=e49cc3493ab77678a740bf8a27cf22e77e061409

commit e49cc3493ab77678a740bf8a27cf22e77e061409
Author:     Siddhanth Rathod <xsiddhanthrathod@gmail.com>
AuthorDate: 2023-09-28 18:54:44 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2023-09-29 07:20:18 +0000

    eclean-pkg: fix compatibility with FEATURES=pkgdir-index-trusted
    
    Portage recently enabled FEATURES=pkgdir-index-trusted by default which breaks
    the eclean-invalids feature.
    
    Force reindexing after cleaning up to fix this.
    
    See-also: https://github.com/gentoo/portage/commit/3bc7bfef51d88fd716e882d3931f2873e3493e01
    Bug: https://bugs.gentoo.org/889300
    Bug: https://bugs.gentoo.org/900224
    Signed-off-by: Siddhanth Rathod <xsiddhanthrathod@gmail.com>
    Closes: https://github.com/gentoo/gentoolkit/pull/34
    Signed-off-by: Sam James <sam@gentoo.org>

 pym/gentoolkit/eclean/search.py | 11 ++++++++---
 1 file changed, 8 insertions(+), 3 deletions(-)
Comment 6 Larry the Git Cow gentoo-dev 2023-10-03 15:39:16 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=9f9211a35abef13079f93a96f57f3a96083c69a7

commit 9f9211a35abef13079f93a96f57f3a96083c69a7
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2023-10-03 15:38:28 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2023-10-03 15:38:41 +0000

    sys-apps/portage: add 3.0.52
    
    Closes: https://bugs.gentoo.org/704866
    Closes: https://bugs.gentoo.org/877793
    Closes: https://bugs.gentoo.org/889300
    Closes: https://bugs.gentoo.org/900224
    Closes: https://bugs.gentoo.org/912676
    Closes: https://bugs.gentoo.org/912808
    Closes: https://bugs.gentoo.org/913070
    Closes: https://bugs.gentoo.org/913103
    Closes: https://bugs.gentoo.org/914159
    Closes: https://bugs.gentoo.org/915054
    Closes: https://bugs.gentoo.org/915119
    Signed-off-by: Sam James <sam@gentoo.org>

 sys-apps/portage/Manifest              |   1 +
 sys-apps/portage/portage-3.0.52.ebuild | 235 +++++++++++++++++++++++++++++++++
 2 files changed, 236 insertions(+)