Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 888996 - sys-devel/gettext still depends on Java 8/ upstream in progress
Summary: sys-devel/gettext still depends on Java 8/ upstream in progress
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Gentoo's Team for Core System packages
URL: https://savannah.gnu.org/bugs/?63385
Whiteboard:
Keywords: PATCH, PullRequest
Depends on:
Blocks:
 
Reported: 2022-12-30 15:35 UTC by onkobu
Modified: 2024-11-22 17:27 UTC (History)
4 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
java 17 patch (07-java-17-support.patch,2.89 KB, patch)
2023-06-27 16:04 UTC, Andrea Postiglione
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description onkobu 2022-12-30 15:35:14 UTC
sys-devel/gettext is one of the few packages that still depend on Java 8. It seems very likely that it is not ready for >11 (https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1012105 and https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=982526). Nevertheless there is some progress upstream. A patch is available.

Reproducible: Always



Expected Results:  
gettext builds/ runs with current LTS Java
Comment 1 Volkmar W. Pogatzki 2022-12-30 17:22:17 UTC
(In reply to onkobu from comment #0)
> [...]
> Expected Results:  
> gettext builds/ runs with current LTS Java

Compilation should not be the problem, at least for the split-off: https://github.com/gentoo/gentoo/pull/26163
Comment 2 Andrea Postiglione 2023-06-27 16:04:53 UTC
Created attachment 864722 [details, diff]
java 17 patch
Comment 3 Andrea Postiglione 2023-06-27 16:05:32 UTC
from debian packages
Comment 4 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2023-06-27 16:08:26 UTC
I think 0.22 might actually work already and I just didn't update the ebuild..
Comment 5 Andrea Postiglione 2023-07-05 21:05:36 UTC
(In reply to Sam James from comment #4)
> I think 0.22 might actually work already and I just didn't update the
> ebuild..

but why do we have to keep an old version of java that already sucks even when it's the latest
Comment 6 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2023-07-05 21:21:12 UTC
(In reply to Andrea Postiglione from comment #5)
> (In reply to Sam James from comment #4)
> > I think 0.22 might actually work already and I just didn't update the
> > ebuild..
> 
> but why do we have to keep an old version of java that already sucks even
> when it's the latest

Sorry, to be clear, that was me noting "hm, I just need to take a look at this, gettext-0.22 might be ok once I fix it."
Comment 7 neeshy 2024-04-15 18:37:03 UTC
(In reply to Sam James from comment #6)
I've been running this patch[1] for some time now without issue (specifically w/ i2p). Also, the relevant upstream bug[2] has been closed as fixed. Should be ready to just merge it.

1: https://github.com/gentoo/gentoo/pull/34854
2: https://savannah.gnu.org/bugs/index.php?63385
Comment 8 Volkmar W. Pogatzki 2024-10-20 09:56:25 UTC
(In reply to Andrea Postiglione from comment #2)
> Created attachment 864722 [details, diff] [details, diff]
> java 17 patch

Is it possible to replace "1.7" from the patch with "$(java-pkg_get-source)"
and $(java-pkg_get-target) ?

And using ">=virtual/jdk-1.8:*" and ">=virtual/jre-1.8:*" in the ebuild?
Would it work with openjdk:21?
Comment 9 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2024-10-20 10:01:40 UTC
Sorry, I'd missed that 0.22 included it.
Comment 10 Volkmar W. Pogatzki 2024-11-22 16:16:22 UTC
(In reply to Sam James from comment #9)
> Sorry, I'd missed that 0.22 included it.

I've tested https://github.com/gentoo/gentoo/pull/34854 and it works, both with openjdk:21 and openjdk-bin:24, 
i2p-2.7.0 builds fine with it, also with openjdk-bin:24.
Comment 11 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2024-11-22 16:27:29 UTC
Wait, so do we need the patch, or is the PR fine as it is? I'd rather merge the PR if it's ok then make more improvements incrementally.
Comment 12 Volkmar W. Pogatzki 2024-11-22 17:23:12 UTC
(In reply to Sam James from comment #11)
> Wait, so do we need the patch, or is the PR fine as it is? I'd rather merge
> the PR if it's ok then make more improvements incrementally.

PR is fine without any modification.
Comment 13 Larry the Git Cow gentoo-dev 2024-11-22 17:27:25 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=bb93b6c2ac9229ef23bf157048686767434ea2a3

commit bb93b6c2ac9229ef23bf157048686767434ea2a3
Author:     neeshy <neeshy@tfwno.gf>
AuthorDate: 2023-11-05 23:01:01 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2024-11-22 17:26:48 +0000

    sys-devel/gettext: build against java >=8
    
    Closes: https://bugs.gentoo.org/888996
    Signed-off-by: Nima Sadeghi <neeshy@tfwno.gf>
    Closes: https://github.com/gentoo/gentoo/pull/34854
    Signed-off-by: Sam James <sam@gentoo.org>

 sys-devel/gettext/gettext-0.22.5-r1.ebuild | 203 +++++++++++++++++++++++++++++
 1 file changed, 203 insertions(+)