888912 – sys-auth/elogind[selinux]: build failure on musl

Bug 888912 - sys-auth/elogind[selinux]: build failure on musl

Summary: sys-auth/elogind[selinux]: build failure on musl

Status:	RESOLVED FIXED

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	Current packages (show other bugs)
Hardware:	All Linux

Importance:	Normal major (vote)
Assignee:	Andreas Sturmlechner

URL:
Whiteboard:
Keywords:	PATCH

Depends on:
Blocks:

Reported:	2022-12-29 23:23 UTC by dsreyes1014
Modified:	2023-05-17 02:37 UTC (History)
CC List:	4 users (show)

See Also:
Package list:
Runtime testing required:	---

Attachments
selinux.patch (file_888912.txt,1.75 KB, text/plain) 2022-12-29 23:23 UTC, dsreyes1014	Details
emerge --info (file_888912.txt,6.45 KB, text/plain) 2022-12-29 23:24 UTC, dsreyes1014	Details
elogind/temp/build.log (file_888912.txt,147.11 KB, text/plain) 2022-12-29 23:31 UTC, dsreyes1014	Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description dsreyes1014 2022-12-29 23:23:09 UTC

Created attachment 845708 [details]
selinux.patch

I wasn't able to update elogind without a patch that was sent to me.  Attached is the patch that was sent.

Comment 1 dsreyes1014 2022-12-29 23:24:34 UTC

Created attachment 845710 [details]
emerge --info

Comment 2 dsreyes1014 2022-12-29 23:25:55 UTC

(In reply to dsreyes1014 from comment #0)
> Created attachment 845708 [details]
> selinux.patch
> 
> I wasn't able to update elogind without a patch that was sent to me. 
> Attached is the patch that was sent.

It seems it has something to do with selinux.

Comment 3 Sam James archtester

2022-12-29 23:27:50 UTC

We discussed this on IRC in #gentoo-hardened. It's fixed by https://github.com/elogind/elogind/commit/ab72a46f3104f44a32ef7bec7439aa9d3b5f0fdc and the issue was unguarded use of mallinfo() which is not implemented on musl.

The attached patch to this bug is a rebased version by concord.

Comment 4 dsreyes1014 2022-12-29 23:31:01 UTC

Created attachment 845712 [details]
elogind/temp/build.log

Comment 5 Larry the Git Cow gentoo-dev

2023-05-16 06:46:11 UTC

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=93f87ff3f4ae7df427ce82b3c95ac89b3f418142

commit 93f87ff3f4ae7df427ce82b3c95ac89b3f418142
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2023-05-16 06:45:23 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2023-05-16 06:45:58 +0000

    sys-auth/elogind: fix musl+selinux build
    
    Closes: https://bugs.gentoo.org/888912
    Thanks-to: Kenton Groombridge <concord@gentoo.org>
    Signed-off-by: Sam James <sam@gentoo.org>

 sys-auth/elogind/elogind-246.10-r3.ebuild          |  1 +
 .../files/elogind-246.10-musl-selinux.patch        | 57 ++++++++++++++++++++++
 2 files changed, 58 insertions(+)

Comment 6 Larry the Git Cow gentoo-dev

2023-05-17 02:37:40 UTC

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=0d01fa27133628b645a5127427d9a66a5654798e

commit 0d01fa27133628b645a5127427d9a66a5654798e
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2023-05-17 02:37:08 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2023-05-17 02:37:08 +0000

    sys-auth/elogind: fixup musl+selinux patch
    
    I was missing a few hunks (which weren't in the rebased version shared)
    and I should've noticed, oops.
    
    Closes: https://bugs.gentoo.org/888912
    Fixes: 93f87ff3f4ae7df427ce82b3c95ac89b3f418142
    Signed-off-by: Sam James <sam@gentoo.org>

 .../files/elogind-246.10-musl-selinux.patch        | 45 +++++++++++++++++++++-
 1 file changed, 43 insertions(+), 2 deletions(-)