Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 888845 - mail-filter/spamassassin-4.0.0 installs out-of-date geoip.cf file
Summary: mail-filter/spamassassin-4.0.0 installs out-of-date geoip.cf file
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal minor
Assignee: Philippe Chaintreuil
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks:
 
Reported: 2022-12-29 09:31 UTC by Reuben Farrelly
Modified: 2023-01-05 05:20 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Reuben Farrelly 2022-12-29 09:31:28 UTC
The current ebuild of spamassassin-4.0.0 installs a sample (Gentoo supplied) config file called geoip.conf.  This file containts references to settings that are now obsolete such as country_db_type, country_db_path etc.

These options are still valid for spamassassin-3.4, but not for 4.0.

Running various spamassassin tasks with these settings results in this warning:

"config: deprecated setting used, change country_db_type to geodb_module"

And from upstream release notes:

- New internal Mail::SpamAssassin::GeoDB module that provides unified interface to
  modules MaxMind::DB::Reader (GeoIP2), Geo::IP, IP::Country::DB_File, IP::Country::Fast.
  Utilized by RelayCountry and URILocalBL. Settings geodb_module, geodb_options,
  geodb_search_path. Deprecated settings country_db_type, country_db_path,
  uri_country_db_path, uri_country_db_isp_path still work but print a warning to
  migrate to geodb_module/options.

So in short - this file needs to be either split into a 3.4 and a 4.0 version, or a unified version that has comments relevant to both uptream versions included.

[It is also not clear if the new settings even need to be set at all or if spamassassin 4.0 simply does not require them to be set and does enough autodetect magic to work it out itself]
Comment 1 Philippe Chaintreuil 2022-12-29 13:00:22 UTC
Thanks for the bug report, Reuben.

I just submitted a pull request that adds a fork of geoip.cf that has the 4.0.0 settings.  It does seem like they've improved their auto-detection, so defaults actually work, which is good.
Comment 2 Larry the Git Cow gentoo-dev 2023-01-05 05:20:58 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=325ed1f8aca592694a776b3fc2095456b263964b

commit 325ed1f8aca592694a776b3fc2095456b263964b
Author:     Philippe Chaintreuil <gentoo_bugs_peep@parallaxshift.com>
AuthorDate: 2022-12-29 12:45:33 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2023-01-05 05:19:34 +0000

    mail-filter/spamassassin: Install 4.0.0 compat geoip.cf
    
    Closes: https://bugs.gentoo.org/888845
    Closes: https://github.com/gentoo/gentoo/pull/28888
    Signed-off-by: Philippe Chaintreuil <gentoo_bugs_peep@parallaxshift.com>
    Signed-off-by: Sam James <sam@gentoo.org>

 mail-filter/spamassassin/files/geoip-4.0.0.cf      |  86 ++++++
 .../spamassassin/spamassassin-4.0.0-r1.ebuild      | 331 +++++++++++++++++++++
 2 files changed, 417 insertions(+)